On dimanche, 10 décembre 2017 17.58:43 h CET Sebastian wrote:

Hi,

For the package python-termstyle[0] I want to deactivate the tests because of problems with the default encoding which I can't solve. The requirement of the project maintainers is to not comment them out but change the `%bcond_without tests` to `%bcond_with tests`. But now I have a problem inside %check, which looks like this:

%if %{with tests} %check export LANG=C.UTF-8 %ifpython2 python2 setup.py test -s test2 %endif %ifpython3 python3 setup.py test -s test3 %endif %endif

With `%bcond_without tests`, rpm does not complain (the checks fail, but we know that already), but when I use `%bcond_with tests` I get:

[ 52s] error: /home/abuild/rpmbuild/SOURCES/python-termstyle.spec:72: Got a %endif with no %if Where lne 72 is the last %endif in that section. If I comment out both %ifpythons, then it works.

Does someone maybe has a clue why this is happening?

Sebastian

[0]: https://build.opensuse.org/package/show/home:sebix:branches:devel:languages :python/python-termstyle

If i remember I've been hit by this perhaps using %python3_only %python2_only it could work ? I've been almost pretty sure this kind of writing would have work %check # A full language is needed to make test successful # C.UTF-8 used normally on obs is not enough %{python_expand #Try to build lang export LANG=en_US.UTF-8 $python setup.py test -s test$(echo "%{py_ver}" | cut -d "." -f1) } But I didn't get it right. Tried patch against your package are temporaly here http://susepaste.org/40610078 -- Bruno Friedmann Ioda-Net Sàrl www.ioda-net.ch Bareos Partner, openSUSE Member, fsfe fellowship GPG KEY : D5C9B751C4653227 irc: tigerfoot -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org

On Dez 10 2017, Sebastian wrote:

%if %{with tests} %check export LANG=C.UTF-8 %ifpython2 python2 setup.py test -s test2 %endif %ifpython3 python3 setup.py test -s test3 %endif %endif

Are both %ifpython2 and %ifpython3 defined macros? If either is undefined then the rpm parser will not see the %if that is presumably supposed to be hidden behind that. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org