On Saturday, May 2, 2020 11:33 AM, Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:
On Saturday, 2 May 2020 13:15:18 CEST Martin Pluskal wrote:
On Sat, 2020-05-02 at 13:02 +0200, Stefan Brüns wrote:
On Saturday, 2 May 2020 09:56:04 CEST Martin Pluskal wrote:
Hi On Sat, 2020-05-02 at 04:42 +0000, andythe_great wrote:
Hello, I have been trying to build Avogadrolibs https://github.com/OpenChemistry/avogadrolibs https://build.opensuse.org/package/live_build_log/home:andythe_great/a voga drolibs/openSUSE_Tumbleweed/x86_64 However, this error prevent it from building. E: lto-no-text-in-archive (Badness: 10000) I found this documentation: https://en.opensuse.org/openSUSE:LTO#LTO_enablement_in_openSUSE:Factor y Which it says to add the flag %global _lto_cflags %{?_lto_cflags} -ffat-lto-objects to fix the issue which it did. But Science repo maintainer won't accept it as a fix. https://build.opensuse.org/request/show/780593
But it is correct solution to rpmlint error
It would be a correct solution if the affected library were a library which should be shipped, but thats not the case here - it is just bunch of object files which should be statically linked to the shared libraries (here, dl'opened modules). There is a bugreport I have opened upstream, which has seen some progress lately. There currently is a patch in the package which fixes the problem correctly.
Well shipping of static libraries is usually undesirable, but existence of /avogadro2/staticplugins suggest that its something that is something that upstream wishes.
Wrong. Thats just an indication upstream also supports static plugins for deployments where dl'opened modules have issues.
The library which is mentioned is not a module, just a build artifact. But I have already said that, haven't I?
That being said I wonder why it was not communicated to author of original submit request i.e in sr#780593
The submitter has thrown several very low quality submissions over the fence. I have pointed him to the relevant packaging guidelines etc. several times.
Have a look at the SR - unmentioned patch, changelog inconsistent with the changes, etc. Patience has limits.
Regards,
Stefan
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Stefan Brüns / Bergstraße 21 / 52062 Aachen phone: +49 241 53809034 mobile: +49 151 50412019
The static libraries is needed for the Avogadroapp that required Avogadrolibs to function properly. But as you mention, it is not the correct approach? The patch which fix the issue is fix_libgwavi_linking.patch isn't it, but this only fix the libgwavi but not the rest of the static library right, so can the same method be applied to the other static libraries? Sorry for the bad sr, I could not find much explanation on the issue. Kind Regards, Andy -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org