On Sunday 26 August 2012 19.01:16 Togan Muftuoglu wrote:
On 08/26/2012 06:43 PM, Philipp Thomas wrote:
On Sun, 26 Aug 2012 17:18:55 +0200, Togan Muftuoglu firstname.lastname@example.org wrote:
First of let me clarify the process, as the configure command is not actually a configure thing, but to set the install variables to the shorewall install program, and this is approach is the same way upstream rpm specs
Andreas didn't check the script itself. In most cases, configure is the name of a script to configure sources for building. As shorewalls configure is meant for something completely different, you should add a comment in the script to make ist clear that this script sets up things during the installation and also add a comment to the .changes file to make it clear for any reviewer that you know what you're doing and why you do it that way. That should clear the way for a checkin to factory.
Ok sounds fine. In that case I would reopen the SR and do the changes in the next update as Shorewall is very active in terms of development and the next release will also enable me to remove some of the suse specific patches as they are now upstreamed
And keep the good work Togan, your shorewall packages are really appreciate.