On 4/1/2020 12:23, Pierre wrote:
So, if I understand your comment, the code currently have
binarystoragebuffer.cc: inline void BinaryStorageBuffer::store (void* stream, unsigned int nb_bytes)
binarystoragebuffer.h: void store (void* stream, unsigned int nb_bytes);
And it would be better to either have:
binarystoragebuffer.cc: void BinaryStorageBuffer::store (void* stream, unsigned int nb_bytes)
binarystoragebuffer.h: void store (void* stream, unsigned int nb_bytes);
That would be my choice, but I'm sure the developer is worried about performance and is trying to inline as much as possible.
Or:
binarystoragebuffer.cc: inline void BinaryStorageBuffer::store (void* stream, unsigned int nb_bytes)
binarystoragebuffer.h: inline void store (void* stream, unsigned int nb_bytes);
Almost. The function wouldn't be in binarystoragebuffer.cc at all anymore. I can send you patches later on for either option, but first I have to eat....
Am I understanding this right? Should I contact the dev about this?
Yeah. You can add a patch for it to work correctly on OBS, but ideally upstream (the dev) would make the code change there and you could drop the patch at that point.
Thank you all for your help! Pierre
thanks, -- Jason Craig -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org