On Tue, 18 Apr 2023, Johannes Kastl wrote:
Good morning Dan,
On 18.04.23 at 08:51 Dan ?erm?k wrote:
Johannes Kastl <kastl@b1-systems.de> writes:
Fabian and me had a chat about whether the following is actually still needed in a spec file for a go package:
%define __arch_install_post export NO_BRP_STRIP_DEBUG=true
I have quickly glanced over the rpm macros and none of the scripts included in %__spec_install_post (which in turn includes %__arch_install_post) reads the environment variable NO_BRP_STRIP_DEBUG.
However, it could be that it gets read by something else, so take this with a grain of salt?
Have you tried to just remove the %define and see what happens?
I have tried removing it for the linkerd-cli package and the package still built without errors.
ISTR that Go requires functional backtrace() for quite some of its functionality (which users expect to work) and without debug info the quality of that is severely degraded. So to check you'd have to actually run built go packages, compiling isn't good enough. A Go expert could chime in here. Richard. -- Richard Biener <rguenther@suse.de> SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman; HRB 36809 (AG Nuernberg)