Hi, On Wed, 15 Apr 2020 14:03:01 +0200 Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:
On Wednesday, 15 April 2020 13:42:45 CEST Christian wrote:
Am 15.04.20 um 12:17 schrieb Adam Majer:
This is not SUSE guys or some policy. This is probably just someone nitpicking because they can. But given how bad we are at making readable changelogs entries in internal submissions, I'm not sure that upper/lowercase is really a valid reason to reject.
Yes, it is nitpicking
As the lone reason, it would have been. But the SR was rejected because a patch was disabled, breaking reproducible builds.
You had to fix the SR anyway, why you did not respect the maintainers request to also fix any typos while at it is beyond my understanding.
Yes, this was my thinking. I just thought if he has to change something anyway, then let's make it totally right. On Wed, 15 Apr 2020 12:02:17 +0200 Christian wrote:
Are you SUSE guys _serious_ ??? Is this the way you encourage community to do volunteer work and deny their effort ?
What makes you think this has to do with me working for SUSE? I was an openSUSE contributor and user before and probably will be after. Honestly I don't see where I acted discouraging or rude. To me it looks like this happened: - You create SR#792020. Which is an update, edit of changes and disabling of patches. - I say: "why do you disable the reproducible patch? "update to 0.95.9" Upper case please. Same for 'rebase' etc." - Your answer contains three questionmarks. I don't know why, I guess either because you are very curious or already upset because I ask a simple question: "cause the code changed and the used "../../ChangeLog" does not exist ... so how should it work then ???" - To which I answer that you can make the patch work because the changelog is still there. So you didn't even care to look at the patch clearly, but just disabled it without any notice in the changelog. Which can happen to all of us, sometimes we are lazy. No problem, but if you get asked about it, why is it such a problem? Why not fix it if you want to contribute and improve things? - So you answer "ok ok ... did dig into it and did rework a level higher ... superseed will follow" which is nice. So after asking you two times you actually cared enough to fix the patch. And it means you took the time and touched the changelog and the package again. So at that time, why didn't you just change to uppercase? - You create SR#793111 which I decline because of the uppercase (which I told you about right from the start, when there was also something bigger to change) - You get upset, using several questionmarks again, which to me makes it likely that you were upset before already. Then you start to be quite unfriendly attacking me personally. And after that you come here and try to paint it like you have been treated unfairly by a "SUSE guy" and "maintainer god". Already the assumption that you are treated wrong by a person because that person works for a company is strange to me. I'm just a maintainer like any other. And the assumption that I want to express "power" by declining submit requests is also a funny one. Sometimes I do submit requests and have to adapt my changes 8 times because the maintainer doesn't like it as is. Often they also don't tell all changes in the first review but in each review pick on something else. I can't remember a fight breaking loose from it. Most of the time they are right and their way is a bit cleaner/better/more accurate. In any case, I just do it if it's not wrong. Otherwise I discuss. So I guess the question is what will happen now (since you just reopened the SR). And I guess I'll just accept it, change to uppercase myself, and move on. But I'm not sure whether I will have the feeling that your contribution was a good use of everybodys time and energy. And that a feeling of community work will prevail. Best, Michael -- To unsubscribe, e-mail: opensuse-packaging+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-packaging+owner@opensuse.org