Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 0dc740037ab83e81aa9913c71cfc6812d2652e90
https://github.com/openSUSE/open-build-service/commit/0dc740037ab83e81aa9913...
Author: Dany Marcoux
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M src/api/app/lib/routes_helper/routes_constraints.rb
M src/api/app/views/webui/groups/_group_members.html.haml
M src/api/app/views/webui/groups/_group_members_delete_dialog.html.haml
M src/api/config/routes/webui_routes.rb
Log Message:
-----------
Handle dots in user logins for group members page/route
Fixes #10955
Before, the `Delete group member` modal didn't appear for a user which
has dots in their login.
The routes /groups/<group>/users/<user> were also not handling dots
correctly, treating them as separators. Having a constraint for the user
login solves this. This is documented in Rails, see
https://guides.rubyonrails.org/routing.html#dynamic-segments
Commit: ea59432d6644068447129dbd35bbfefc03eb01db
https://github.com/openSUSE/open-build-service/commit/ea59432d6644068447129d...
Author: Dany Marcoux
Date: 2021-03-31 (Wed, 31 Mar 2021)
Changed paths:
M src/api/app/lib/routes_helper/routes_constraints.rb
M src/api/app/views/webui/groups/_group_members.html.haml
M src/api/app/views/webui/groups/_group_members_delete_dialog.html.haml
M src/api/config/routes/webui_routes.rb
Log Message:
-----------
Merge pull request #10958 from dmarcoux/issue-10955
Handle dots in user logins for group members page/route
Compare: https://github.com/openSUSE/open-build-service/compare/d323544a0060...ea5943...