[obs-commits] [openSUSE/open-build-service] f90e0d: Remove more usage of ActiveXML::Node
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f90e0d0bb99e691bf72f147fa400ca5be2323efe https://github.com/openSUSE/open-build-service/commit/f90e0d0bb99e691bf72f14... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/models/worker_status.rb M src/api/test/functional/attributes_test.rb M src/api/test/functional/build_controller_test.rb M src/api/test/functional/group_request_test.rb M src/api/test/functional/interconnect_test.rb M src/api/test/functional/kgraft_maintenance_test.rb Log Message: ----------- Remove more usage of ActiveXML::Node Mostly replaced by Xmlhash Commit: 155f02c2f44fc2fa6628fe9b2add92cf0b2eab6d https://github.com/openSUSE/open-build-service/commit/155f02c2f44fc2fa6628fe... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- Replace ActiveXML::Node in PackageController::package_files Commit: b50a35ae4b342bd5056a0b1bb673f37a451bf7f1 https://github.com/openSUSE/open-build-service/commit/b50a35ae4b342bd5056a0b... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: R src/api/script/import Log Message: ----------- Remove script/import (as ActiveXML::Node user) This imports a database from a backend - this looks obsolete since a decade Commit: 0c517c03e651229ca15cd2c3320ed97095dc32ff https://github.com/openSUSE/open-build-service/commit/0c517c03e651229ca15cd2... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/models/package.rb Log Message: ----------- Remove two ActiveXML::Node usages from package model Commit: 6791764c2f2dc72e334fcdc59cb414aca52b32d4 https://github.com/openSUSE/open-build-service/commit/6791764c2f2dc72e334fcd... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/controllers/statistics_controller.rb M src/api/app/controllers/status_controller.rb M src/api/app/controllers/status_messages_controller.rb M src/api/app/helpers/validation_helper.rb Log Message: ----------- Replace ActiveXML::Node with proper XML classes Commit: d81d8fdc6dde83414224fc8bab4a4a6b90c995f1 https://github.com/openSUSE/open-build-service/commit/d81d8fdc6dde83414224fc... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/controllers/application_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/request_controller.rb Log Message: ----------- Remove 3 more usages of ActiveXML::Node Mostly replaced by Nokogiri to manipulate Commit: d320f00088d76874ae5010d56d66da52918ddd2a https://github.com/openSUSE/open-build-service/commit/d320f00088d76874ae5010... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/helpers/maintenance_helper.rb Log Message: ----------- Replace ActiveXML::Node usage for _link parsing Commit: 0a36736e04123fdbf70f0864fff7ea0b4d103ea2 https://github.com/openSUSE/open-build-service/commit/0a36736e04123fdbf70f08... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/models/branch_package.rb M src/api/app/models/bs_request_action/differ/query_builder.rb M src/api/app/models/directory.rb M src/api/app/models/package.rb M src/api/config/initializers/activexml.rb Log Message: ----------- Remove ActiveXML::Node from Directory Most places used Directory.hashed already, which has nothing to do with ActiveXML Commit: f17d9a85568201dbfe915f6088fdc71ee5b58156 https://github.com/openSUSE/open-build-service/commit/f17d9a85568201dbfe915f... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/controllers/public_controller.rb M src/api/app/controllers/webui/project_controller.rb R src/api/app/models/collection.rb M src/api/app/models/project.rb M src/api/config/initializers/activexml.rb M src/api/lib/backend/api/search.rb Log Message: ----------- Drop the Collection 'model' It is used for a couple of /search routes in the backend. Used Backend::Api::Search functions for that now Commit: 1261d5c2599225f9828c8bf87687052bdadb35bb https://github.com/openSUSE/open-build-service/commit/1261d5c2599225f9828c8b... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/models/buildresult.rb M src/api/app/models/obs_factory/distribution_strategy_casp.rb M src/api/app/models/obs_factory/distribution_strategy_factory.rb M src/api/app/models/project.rb M src/api/config/initializers/activexml.rb M src/api/lib/backend/api/build_results/status.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/patchinfo_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/features/webui/projects_spec.rb M src/api/spec/models/local_build_result/for_package_spec.rb Log Message: ----------- Stop using ActiveXML in Buildresult It's basically only a namespace now - to get a xmlhash. I extended the Backend function to support more parameters to do so. Which creates a little overlap now, so possibly it makes sense to move this Buildresult module into lib/backend Commit: 7d627bdf7aedce2acd23dd22b7fca8a710750040 https://github.com/openSUSE/open-build-service/commit/7d627bdf7aedce2acd23dd... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/lib/backend/api/build/project.rb M src/api/lib/backend/api/build_results/binaries.rb Log Message: ----------- Move wipe_published_locked into Build::Project It was a little misfit in Build::Binaries Commit: 9793e6a554a611e5af6799c038eda75fdb56a9db https://github.com/openSUSE/open-build-service/commit/9793e6a554a611e5af6799... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/lib/backend/api/build/project.rb M src/api/spec/controllers/webui/patchinfo_controller_spec.rb Log Message: ----------- Move one special view of _result into its own function view=binarylist is used only in patchinfo controller Commit: f4357379297a54799d7c93c1c80b385e4be77d46 https://github.com/openSUSE/open-build-service/commit/f4357379297a54799d7c93... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/models/obs_factory/obs_project.rb M src/api/app/models/obs_factory/staging_project.rb M src/api/lib/backend/api/build_results/status.rb Log Message: ----------- Introduce Backend::Api::BuildResults::Status.failed_results Commit: 4d8bec49829c8421f2c2d2b06586ac12f0f2a21f https://github.com/openSUSE/open-build-service/commit/4d8bec49829c8421f2c2d2... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/patchinfo.rb M src/api/app/models/project.rb M src/api/spec/controllers/webui/patchinfo_controller_spec.rb Log Message: ----------- Remove ActiveXML::Node from patchinfo The patchinfo class urgently needs to split into one that represents the XML document and one that handles it. Commit: 9ee8b0740ee071d0736b8ef59f38e286630fc444 https://github.com/openSUSE/open-build-service/commit/9ee8b0740ee071d0736b8e... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/controllers/application_controller.rb M src/api/app/controllers/source_controller.rb M src/api/config/initializers/activexml.rb M src/api/lib/activexml/activexml.rb R src/api/lib/activexml/node.rb Log Message: ----------- Remove all of ActiveXML::Node Commit: b9a1ef932e247506fb24cb84565b7bf43680e76a https://github.com/openSUSE/open-build-service/commit/b9a1ef932e247506fb24cb... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/lib/activexml/transport.rb Log Message: ----------- Remove unused functions from ActiveXML::Transport Commit: 5d3ccf82dc5e9a6f47111e9d36057b43271eaa19 https://github.com/openSUSE/open-build-service/commit/5d3ccf82dc5e9a6f47111e... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/models/obs_factory/distribution_strategy_factory.rb M src/api/app/models/obs_factory/distribution_strategy_factory_ppc.rb M src/api/app/models/obs_factory/distribution_strategy_opensuse_leap15.rb M src/api/spec/models/obs_factory/distribution_strategy_factory_ppc_spec.rb M src/api/spec/models/obs_factory/distribution_strategy_factory_spec.rb M src/api/spec/models/obs_factory/distribution_strategy_opensuse_leap15_spec.rb Log Message: ----------- Don't use direct_http in staging strategy There is a function for that in the backend library Commit: be9e79475da6d22b05e47f9c31da89e93356f89b https://github.com/openSUSE/open-build-service/commit/be9e79475da6d22b05e47f... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/.rubocop.yml M src/api/app/controllers/statistics/maintenance_statistics_controller.rb M src/api/app/models/distribution.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/config/initializers/activexml.rb M src/api/lib/activexml/transport.rb Log Message: ----------- Remove ActiveXML::Transport::http_do It was only used in Package::save_file, which has a Backend function Commit: 6250a9a6da2c169fd815096cc69bba91ccf6687e https://github.com/openSUSE/open-build-service/commit/6250a9a6da2c169fd81509... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/controllers/statistics/maintenance_statistics_controller.rb M src/api/app/models/distribution.rb M src/api/app/models/project.rb A src/api/app/models/project/remote_url.rb M src/api/lib/activexml/transport.rb Log Message: ----------- Move load_external_url to Project namespace It's only used to load from remote instances, so give it a better name Commit: d4ef3ac603db3dff83d3ac9c04de345789b890e0 https://github.com/openSUSE/open-build-service/commit/d4ef3ac603db3dff83d3ac... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/controllers/statistics/maintenance_statistics_controller.rb M src/api/app/models/distribution.rb M src/api/app/models/project.rb M src/api/app/models/project/remote_url.rb Log Message: ----------- Simplifify loading from remote url ruby's OpenURI supports http_proxy and no_proxy (since 2.5), so no need to carry our own implementation of it. What's left is simplication of exception handling, but I'm not so sure which exceptions are actually left to be thrown Commit: 0ff90a78d8d7ea92b741594b353cb42cf2b0422c https://github.com/openSUSE/open-build-service/commit/0ff90a78d8d7ea92b74159... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/controllers/application_controller.rb M src/api/app/controllers/cloud/upload_jobs_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/webui/cloud/upload_jobs_controller.rb M src/api/app/controllers/webui/download_on_demand_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/jobs/consistency_check_job.rb M src/api/app/mixins/has_attributes.rb M src/api/app/models/binary_release.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action/differ/for_source.rb M src/api/app/models/bs_request_action/differ/query_builder.rb M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/bs_request_permission_check.rb M src/api/app/models/buildresult.rb M src/api/app/models/cloud/backend/upload_job.rb M src/api/app/models/directory.rb M src/api/app/models/event/build_fail.rb M src/api/app/models/obs_factory/distribution.rb M src/api/app/models/package.rb M src/api/app/models/package_build_status.rb M src/api/app/models/project.rb M src/api/app/models/service.rb M src/api/app/models/update_notification_events.rb M src/api/config/application.rb M src/api/config/initializers/airbrake.rb M src/api/lib/activexml/activexml.rb R src/api/lib/activexml/transport.rb M src/api/lib/backend/api/sources/package.rb M src/api/lib/backend/backend.rb M src/api/lib/backend/connection.rb A src/api/lib/backend/error.rb M src/api/lib/tasks/delayed_job.rake M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/patchinfo_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/models/backend/file_spec.rb M src/api/spec/models/cloud/upload_job_spec.rb M src/api/spec/models/package_spec.rb M src/api/spec/models/project_spec.rb Log Message: ----------- Rename ActiveXML::Transport::Error to Backend::Error This is the only place where it's thrown now Commit: 0a6045a1a6a2ba190a8c7784b1a77f0adebb8bf4 https://github.com/openSUSE/open-build-service/commit/0a6045a1a6a2ba190a8c77... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/config/application.rb R src/api/config/initializers/activexml.rb R src/api/lib/activexml/activexml.rb M src/api/lib/backend/error.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/patchinfo_controller_spec.rb Log Message: ----------- Remove Backend::ForbiddenError It's nowhere thrown (and wasn't since the backend refactoring) Commit: c7245f49580261bdfd1698ada84240850e6b8056 https://github.com/openSUSE/open-build-service/commit/c7245f49580261bdfd1698... Author: Stephan Kulow <coolo@suse.de> Date: 2018-09-02 (Sun, 02 Sep 2018) Changed paths: M src/api/.rubocop_todo.yml M src/api/Gemfile Log Message: ----------- Remove last traces of activexml Commit: ee325c2d56d1a8cae1fa2e79b8d21e223d53445f https://github.com/openSUSE/open-build-service/commit/ee325c2d56d1a8cae1fa2e... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2018-09-04 (Tue, 04 Sep 2018) Changed paths: M src/api/.rubocop.yml M src/api/.rubocop_todo.yml M src/api/Gemfile M src/api/app/controllers/application_controller.rb M src/api/app/controllers/cloud/upload_jobs_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/statistics/maintenance_statistics_controller.rb M src/api/app/controllers/statistics_controller.rb M src/api/app/controllers/status_controller.rb M src/api/app/controllers/status_messages_controller.rb M src/api/app/controllers/webui/cloud/upload_jobs_controller.rb M src/api/app/controllers/webui/download_on_demand_controller.rb M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/patchinfo_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/validation_helper.rb M src/api/app/jobs/consistency_check_job.rb M src/api/app/mixins/has_attributes.rb M src/api/app/models/binary_release.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action/differ/for_source.rb M src/api/app/models/bs_request_action/differ/query_builder.rb M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_permission_check.rb M src/api/app/models/buildresult.rb M src/api/app/models/cloud/backend/upload_job.rb R src/api/app/models/collection.rb M src/api/app/models/directory.rb M src/api/app/models/distribution.rb M src/api/app/models/event/build_fail.rb M src/api/app/models/obs_factory/distribution.rb M src/api/app/models/obs_factory/distribution_strategy_casp.rb M src/api/app/models/obs_factory/distribution_strategy_factory.rb M src/api/app/models/obs_factory/distribution_strategy_factory_ppc.rb M src/api/app/models/obs_factory/distribution_strategy_opensuse_leap15.rb M src/api/app/models/obs_factory/obs_project.rb M src/api/app/models/obs_factory/staging_project.rb M src/api/app/models/package.rb M src/api/app/models/package_build_status.rb M src/api/app/models/patchinfo.rb M src/api/app/models/project.rb A src/api/app/models/project/remote_url.rb M src/api/app/models/service.rb M src/api/app/models/update_notification_events.rb M src/api/app/models/worker_status.rb M src/api/config/application.rb R src/api/config/initializers/activexml.rb M src/api/config/initializers/airbrake.rb R src/api/lib/activexml/activexml.rb R src/api/lib/activexml/node.rb R src/api/lib/activexml/transport.rb M src/api/lib/backend/api/build/project.rb M src/api/lib/backend/api/build_results/binaries.rb M src/api/lib/backend/api/build_results/status.rb M src/api/lib/backend/api/search.rb M src/api/lib/backend/api/sources/package.rb M src/api/lib/backend/backend.rb M src/api/lib/backend/connection.rb A src/api/lib/backend/error.rb M src/api/lib/tasks/delayed_job.rake R src/api/script/import M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/patchinfo_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/features/webui/projects_spec.rb M src/api/spec/models/backend/file_spec.rb M src/api/spec/models/cloud/upload_job_spec.rb M src/api/spec/models/local_build_result/for_package_spec.rb M src/api/spec/models/obs_factory/distribution_strategy_factory_ppc_spec.rb M src/api/spec/models/obs_factory/distribution_strategy_factory_spec.rb M src/api/spec/models/obs_factory/distribution_strategy_opensuse_leap15_spec.rb M src/api/spec/models/package_spec.rb M src/api/spec/models/project_spec.rb M src/api/test/functional/attributes_test.rb M src/api/test/functional/build_controller_test.rb M src/api/test/functional/group_request_test.rb M src/api/test/functional/interconnect_test.rb M src/api/test/functional/kgraft_maintenance_test.rb Log Message: ----------- Merge pull request #5605 from coolo/replace_activexml Remove ActiveXML Compare: https://github.com/openSUSE/open-build-service/compare/8a15f15cba49...ee325c... **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
Henne Vogelsang