[obs-commits] [openSUSE/open-build-service] 4f9840: Enable new feature flags in development environment

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4f98401a75e5182400abb7e072b653db8d6914f5 https://github.com/openSUSE/open-build-service/commit/4f98401a75e5182400abb7... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M src/api/lib/tasks/dev.rake Log Message: ----------- Enable new feature flags in development environment Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Eduardo Navarro <enavarro@suse.com> Commit: 03f1e32f71a4e512fb37cc934ddc9a54bd5e7611 https://github.com/openSUSE/open-build-service/commit/03f1e32f71a4e512fb37cc... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb Log Message: ----------- Prevent access to notifications without feature flag Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Eduardo Navarro <enavarro@suse.com> Commit: fe91077586663e091f63e1928205d6e2498f40aa https://github.com/openSUSE/open-build-service/commit/fe91077586663e091f63e1... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M src/api/app/helpers/webui/webui_helper.rb Log Message: ----------- Define flipper_notifications? helper Commit: 1c6f3731492fb09d672472c9c3008feb5fb3e754 https://github.com/openSUSE/open-build-service/commit/1c6f3731492fb09d672472... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M src/api/app/assets/stylesheets/webui/application.scss R src/api/app/assets/stylesheets/webui/responsive_ux.scss A src/api/app/assets/stylesheets/webui/responsive_ux/responsive_ux.scss Log Message: ----------- Move responsive_ux.scss to the proper directory We want to keep all the CSS files related to one feature flag in its own directory. This will simplify enabling or disabling different features independently. Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Eduardo Navarro <enavarro@suse.com> Commit: 632ac7c04394d82e762ff4c1a3547b56013ae24e https://github.com/openSUSE/open-build-service/commit/632ac7c04394d82e762ff4... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M src/api/app/assets/stylesheets/webui/application.scss A src/api/app/assets/stylesheets/webui/notifications_redesign/notifications.scss R src/api/app/assets/stylesheets/webui/responsive_ux/_notifications.scss M src/api/app/views/webui/users/notifications/_notifications_list.html.haml Log Message: ----------- Move notifications CSS to its own directory We want to keep all the CSS files related to one feature flag in its own directory. This will simplify enabling or disabling different features independently. Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Eduardo Navarro <enavarro@suse.com> Commit: 332299ec678211b4770e5c59cc2916e43986e2a3 https://github.com/openSUSE/open-build-service/commit/332299ec678211b4770e5c... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M src/api/app/views/layouts/webui/_logged_in_user_navigation.html.haml Log Message: ----------- Add link to notifications into personal navigation All the users with notifications_redesign feature enabled, can see the Notifications link in the personal navigation bar. Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Eduardo Navarro <enavarro@suse.com> Commit: fef85813f30d2995ed5253edb26de6cf54ef479e https://github.com/openSUSE/open-build-service/commit/fef85813f30d2995ed5253... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M src/api/app/views/layouts/webui/responsive_ux/_bottom_navigation.html.haml M src/api/app/views/layouts/webui/responsive_ux/_navigation.html.haml Log Message: ----------- Check for notifications feature in responsive_ux Show the notifications link only when notifications_redesign feature is enabled. Adjusted inside responsive_ux top and bottom navigation bars. Commit: f80a080d4ff7c1753b636a8ca9bebbb0c336c123 https://github.com/openSUSE/open-build-service/commit/f80a080d4ff7c1753b636a... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M src/api/app/helpers/webui/webui_helper.rb M src/api/app/views/layouts/webui/webui.html.haml Log Message: ----------- Set body class according to feature flag Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Eduardo Navarro <enavarro@suse.com> Commit: 1367fbb87fb97a6995cf151a7d1d8b370bd53d70 https://github.com/openSUSE/open-build-service/commit/1367fbb87fb97a6995cf15... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M src/api/spec/support/beta.rb Log Message: ----------- Enable notifications_redesign feature for beta tests The new features will be enabled for beta users in tests. Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Eduardo Navarro <enavarro@suse.com> Commit: 353fb7454969fe29f377dd8ce01c6fa748c10135 https://github.com/openSUSE/open-build-service/commit/353fb7454969fe29f377dd... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M src/api/app/helpers/webui/buildresult_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/views/layouts/webui/_logged_in_user_navigation.html.haml M src/api/app/views/layouts/webui/responsive_ux/_bottom_navigation.html.haml M src/api/app/views/layouts/webui/responsive_ux/_navigation.html.haml M src/api/app/views/layouts/webui/webui.html.haml M src/api/app/views/webui/attribute/index.html.haml M src/api/app/views/webui/configuration/_tabs.html.haml M src/api/app/views/webui/main/_breadcrumb_items.html.haml M src/api/app/views/webui/main/_status_messages.html.haml M src/api/app/views/webui/main/index.html.haml M src/api/app/views/webui/package/_basic_info.html.haml M src/api/app/views/webui/package/_bottom_actions.html.haml M src/api/app/views/webui/package/_breadcrumb_items.html.haml M src/api/app/views/webui/package/_tabs.html.haml M src/api/app/views/webui/package/show.html.haml M src/api/app/views/webui/packages/branches/_breadcrumb_items.html.haml M src/api/app/views/webui/project/_basic_info.html.haml M src/api/app/views/webui/project/_bottom_actions.html.haml M src/api/app/views/webui/project/_breadcrumb_items.html.haml M src/api/app/views/webui/project/_project_packages.html.haml M src/api/app/views/webui/project/_tabs.html.haml M src/api/app/views/webui/project/show.html.haml M src/api/app/views/webui/project/subprojects.html.haml M src/api/app/views/webui/repositories/_project_repositories.html.haml M src/api/app/views/webui/repositories/index.html.haml M src/api/app/views/webui/shared/user_or_groups_roles/_index.html.haml M src/api/app/views/webui/user/_involvement.html.haml M src/api/app/views/webui/users/notifications/index.html.haml Log Message: ----------- Define a generic helper to check if one feature is enabled Instead of creating one helper method per feature (like flipper_respons?) we define a generic helper for that (feature_enabled?(feature)). Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Eduardo Navarro <enavarro@suse.com> Commit: f0b9afc82f3cdb3939720b5eaeb6f3dfb2a95dc8 https://github.com/openSUSE/open-build-service/commit/f0b9afc82f3cdb3939720b... Author: Eduardo Navarro <enavarro@suse.com> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M src/api/spec/controllers/webui/users/notifications_controller_spec.rb Log Message: ----------- Adapt notifications' controller tests Now we use a feature flag to enable the notifications. Co-authored-by: David Kang <dkang@suse.com> Co-authored-by: Saray Cabrera Padrón <scabrerapadron@suse.de> Commit: 045f30a5b32353e80f7f928c37c2b30158b82d7f https://github.com/openSUSE/open-build-service/commit/045f30a5b32353e80f7f92... Author: Victor Pereira <vpereira@suse.de> Date: 2020-08-10 (Mon, 10 Aug 2020) Changed paths: M src/api/app/assets/stylesheets/webui/application.scss A src/api/app/assets/stylesheets/webui/notifications_redesign/notifications.scss R src/api/app/assets/stylesheets/webui/responsive_ux.scss R src/api/app/assets/stylesheets/webui/responsive_ux/_notifications.scss A src/api/app/assets/stylesheets/webui/responsive_ux/responsive_ux.scss M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/helpers/webui/buildresult_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/views/layouts/webui/_logged_in_user_navigation.html.haml M src/api/app/views/layouts/webui/responsive_ux/_bottom_navigation.html.haml M src/api/app/views/layouts/webui/responsive_ux/_navigation.html.haml M src/api/app/views/layouts/webui/webui.html.haml M src/api/app/views/webui/attribute/index.html.haml M src/api/app/views/webui/configuration/_tabs.html.haml M src/api/app/views/webui/main/_breadcrumb_items.html.haml M src/api/app/views/webui/main/_status_messages.html.haml M src/api/app/views/webui/main/index.html.haml M src/api/app/views/webui/package/_basic_info.html.haml M src/api/app/views/webui/package/_bottom_actions.html.haml M src/api/app/views/webui/package/_breadcrumb_items.html.haml M src/api/app/views/webui/package/_tabs.html.haml M src/api/app/views/webui/package/show.html.haml M src/api/app/views/webui/packages/branches/_breadcrumb_items.html.haml M src/api/app/views/webui/project/_basic_info.html.haml M src/api/app/views/webui/project/_bottom_actions.html.haml M src/api/app/views/webui/project/_breadcrumb_items.html.haml M src/api/app/views/webui/project/_project_packages.html.haml M src/api/app/views/webui/project/_tabs.html.haml M src/api/app/views/webui/project/show.html.haml M src/api/app/views/webui/project/subprojects.html.haml M src/api/app/views/webui/repositories/_project_repositories.html.haml M src/api/app/views/webui/repositories/index.html.haml M src/api/app/views/webui/shared/user_or_groups_roles/_index.html.haml M src/api/app/views/webui/user/_involvement.html.haml M src/api/app/views/webui/users/notifications/_notifications_list.html.haml M src/api/app/views/webui/users/notifications/index.html.haml M src/api/lib/tasks/dev.rake M src/api/spec/controllers/webui/users/notifications_controller_spec.rb M src/api/spec/support/beta.rb Log Message: ----------- Merge pull request #9990 from saraycp/new_flipper_flags Move the notifications code to its own feature flag Compare: https://github.com/openSUSE/open-build-service/compare/df83b8790052...045f30...
participants (1)
-
Victor Pereira