Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 54fbfe62861af22c714ac6da3a71d344e5572deb https://github.com/openSUSE/open-build-service/commit/54fbfe62861af22c714ac6... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2020-07-31 (Fri, 31 Jul 2020) Changed paths: M src/api/app/controllers/webui/packages/branches_controller.rb M src/api/spec/controllers/webui/packages/branches_controller_spec.rb Log Message: ----------- Always show the message while branching failed Package::UnknownObjectError and Project::UnknownObjectError also have nice error messages that tell you exactly what is not found. Show that to people, instead of a generic message. Makes #9970 a bit more clear Commit: bdee5ca1fc9887cf4760acc72426157fa60e91a1 https://github.com/openSUSE/open-build-service/commit/bdee5ca1fc9887cf4760ac... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2020-07-31 (Fri, 31 Jul 2020) Changed paths: M src/api/spec/features/beta/webui/projects_spec.rb M src/api/spec/features/webui/projects_spec.rb Log Message: ----------- Remove duplicated test This is already tested in the branches controller spec. Commit: 169da6b10f2c5d2b1eb94180ea22ab22c817bb17 https://github.com/openSUSE/open-build-service/commit/169da6b10f2c5d2b1eb941... Author: Henne Vogelsang <hvogel@opensuse.org> Date: 2020-07-31 (Fri, 31 Jul 2020) Changed paths: M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_current_revision_parameter_is_provided_but_there_wasn_t_any_revision_before.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_source_package_does_not_exist.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_source_package_parameter_not_provided.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_source_project_does_not_exist.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_source_project_parameter_not_provided.yml A src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_the_target_package_exists_already.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_user_has_no_permissions_for_source_project.yml A src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_currrent_revision_parameter/1_1_10_1.yml A src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_currrent_revision_parameter/1_1_10_3.yml R src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_currrent_revision_parameter/1_1_8_1.yml R src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_currrent_revision_parameter/1_1_8_3.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_currrent_revision_parameter/redirects_to_the_branched_package.yml A src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_default_parameters/1_1_8_1.yml A src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_default_parameters/redirects_to_the_branched_package.yml R src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_target_package_name/1_1_7_1.yml A src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_target_package_name/1_1_9_1.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_target_package_name/redirects_to_the_branched_package.yml M src/api/spec/controllers/webui/packages/branches_controller_spec.rb M src/api/spec/features/webui/projects_spec.rb Log Message: ----------- Only test the happy path for branching as feature There is nothing special about the branching form. Only test if it works in general. Test all the other conditions in the controller test. Commit: 049d1c18e0dbf8d7a4cf325befe7b7319920484a https://github.com/openSUSE/open-build-service/commit/049d1c18e0dbf8d7a4cf32... Author: Dany Marcoux <danymarcoux@gmail.com> Date: 2020-08-03 (Mon, 03 Aug 2020) Changed paths: M src/api/app/controllers/webui/packages/branches_controller.rb M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_current_revision_parameter_is_provided_but_there_wasn_t_any_revision_before.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_source_package_does_not_exist.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_source_package_parameter_not_provided.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_source_project_does_not_exist.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_source_project_parameter_not_provided.yml A src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_the_target_package_exists_already.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/shows_an_error_if_user_has_no_permissions_for_source_project.yml A src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_currrent_revision_parameter/1_1_10_1.yml A src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_currrent_revision_parameter/1_1_10_3.yml R src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_currrent_revision_parameter/1_1_8_1.yml R src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_currrent_revision_parameter/1_1_8_3.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_currrent_revision_parameter/redirects_to_the_branched_package.yml A src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_default_parameters/1_1_8_1.yml A src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_default_parameters/redirects_to_the_branched_package.yml R src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_target_package_name/1_1_7_1.yml A src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_target_package_name/1_1_9_1.yml M src/api/spec/cassettes/Webui_Packages_BranchesController/POST_create/with_target_package_name/redirects_to_the_branched_package.yml M src/api/spec/controllers/webui/packages/branches_controller_spec.rb M src/api/spec/features/beta/webui/projects_spec.rb M src/api/spec/features/webui/projects_spec.rb Log Message: ----------- Merge pull request #9971 from hennevogel/bugfix/9970 Always show the message while branching failed Compare: https://github.com/openSUSE/open-build-service/compare/88ac674be41f...049d1c...