[openSUSE/open-build-service] 6027d8: Rename CannedResponse#decision_kind to favored
Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6027d803a6979c5cea4a7de0783b173044a6d05a https://github.com/openSUSE/open-build-service/commit/6027d803a6979c5cea4a7d... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-04-18 (Thu, 18 Apr 2024) Changed paths: M src/api/app/assets/javascripts/webui/canned_responses.js M src/api/app/components/reports_modal_component.html.haml M src/api/app/components/reports_modal_component.rb M src/api/app/models/canned_response.rb M src/api/app/views/webui/users/canned_responses/edit.html.haml M src/api/app/views/webui/users/canned_responses/index.html.haml Log Message: ----------- Rename CannedResponse#decision_kind to favored Replace `favor` with `favored` for consistency and compatibility with the upcoming refactoring on decisions. Moreover, the decision form allows canned responses for favored and cleared decisions. But also for normal comments (decision_kind nil). For those normal comments the form is now selecting `cleared` which is the value set in database by default anyway. Co-authored-by: Eduardo Navarro <enavarro@suse.com> Commit: a9f83c77bf7192e470fde040e2820d3108683499 https://github.com/openSUSE/open-build-service/commit/a9f83c77bf7192e470fde0... Author: Saray Cabrera Padrón <scabrerapadron@suse.de> Date: 2024-04-18 (Thu, 18 Apr 2024) Changed paths: M src/api/spec/components/canned_responses_dropdown_component_spec.rb M src/api/spec/factories/canned_responses.rb M src/api/spec/features/webui/canned_responses_spec.rb Log Message: ----------- Adapt canned respones specs to use favored Commit: cd8c01d0078869461328bb900be07c5ca3b79c13 https://github.com/openSUSE/open-build-service/commit/cd8c01d0078869461328bb... Author: Jacob Michalskie <jacob.michalskie@suse.com> Date: 2024-04-18 (Thu, 18 Apr 2024) Changed paths: M src/api/app/assets/javascripts/webui/canned_responses.js M src/api/app/components/reports_modal_component.html.haml M src/api/app/components/reports_modal_component.rb M src/api/app/models/canned_response.rb M src/api/app/views/webui/users/canned_responses/edit.html.haml M src/api/app/views/webui/users/canned_responses/index.html.haml M src/api/spec/components/canned_responses_dropdown_component_spec.rb M src/api/spec/factories/canned_responses.rb M src/api/spec/features/webui/canned_responses_spec.rb Log Message: ----------- Merge pull request #16010 from saraycp/favor_to_favored Rename favor to favored Compare: https://github.com/openSUSE/open-build-service/compare/a58896590705...cd8c01... To unsubscribe from these emails, change your notification settings at https://github.com/openSUSE/open-build-service/settings/notifications
participants (1)
-
Jacob Michalskie