June 2021 - Open Build Service Commits

[openSUSE/open-build-service] 6bc35d: Revert "Install listen gem"
by Victor Pereira 23 Jun '21

23 Jun '21

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6bc35d5625613926a7e45abe4fc32e375f62f262 https://github.com/openSUSE/open-build-service/commit/6bc35d5625613926a7e45… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock M src/api/Gemfile.next.lock M src/api/config/environments/development.rb Log Message: ----------- Revert "Install listen gem" This reverts commit 9b9e38912b57d2d680e55461af75dd0d7c402ff0. The changes are causing the following error in the delayed jobs in our development environment: ERROR -- : Exception rescued in listen-run_thread: IOError: closed stream Commit: cb94d5bb1c87920e5fc48c0adc4f27452bf91487 https://github.com/openSUSE/open-build-service/commit/cb94d5bb1c87920e5fc48… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock M src/api/Gemfile.next.lock M src/api/config/environments/development.rb Log Message: ----------- Merge pull request #11277 from dmarcoux/revert_install_listen_gem Revert "Install listen gem" Compare: https://github.com/openSUSE/open-build-service/compare/e9b9a7b6db71...cb94d…

1 0

[openSUSE/open-build-service] 7172a0: Store RSpec, Capybara and Minitest artifacts + tes...
by Dany Marcoux 23 Jun '21

23 Jun '21

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7172a055fd82195eb72856e3fc234da1ffff0788 https://github.com/openSUSE/open-build-service/commit/7172a055fd82195eb7285… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M .circleci/config.yml Log Message: ----------- Store RSpec, Capybara and Minitest artifacts + test results for next_rails CI Commit: 08ad6f00e05984793c3259915c21eb5f879047a7 https://github.com/openSUSE/open-build-service/commit/08ad6f00e05984793c325… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: R src/api/app/helpers/webui/flash_helper.rb M src/api/app/views/layouts/webui/_flash.html.haml R src/api/spec/helpers/webui/flash_helper_spec.rb Log Message: ----------- Move code from Webui::FlashHelper helper in the view The spec is somehow failing in Rails 6.1.x, although not in Rails 6.0.x. It's also not testing much... Commit: e9b9a7b6db71972c0268af00ca3b4775b8d25b81 https://github.com/openSUSE/open-build-service/commit/e9b9a7b6db71972c0268a… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M .circleci/config.yml R src/api/app/helpers/webui/flash_helper.rb M src/api/app/views/layouts/webui/_flash.html.haml R src/api/spec/helpers/webui/flash_helper_spec.rb Log Message: ----------- Merge pull request #11274 from openSUSE/next_rails-6 CI changes for next_rails and removal of Webui::FlashHelper Compare: https://github.com/openSUSE/open-build-service/compare/f6a31a585829...e9b9a…

1 0

[openSUSE/open-build-service]
by Dany Marcoux 23 Jun '21

23 Jun '21

Branch: refs/heads/next_rails-6 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] 6bd3d3: Handle the project and package indexing offline
by Henne Vogelsang 23 Jun '21

23 Jun '21

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6bd3d362c170130b47cb4ca399e69a6ec23f2edf https://github.com/openSUSE/open-build-service/commit/6bd3d362c170130b47cb4… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: A src/api/app/jobs/populate_to_sphinx_job.rb R src/api/app/models/concerns/append_sphinx_callbacks.rb M src/api/app/models/package.rb M src/api/app/models/project.rb Log Message: ----------- Handle the project and package indexing offline Propagating the changes to projects and packages using jobs allows us to recover better from integration errors with Sphinx. If something happened with the search service, the content will propagate to Sphinx eventually, once we have fixed whatever it is happening. https://github.com/collectiveidea/delayed_job#gory-details Commit: f6a31a585829639712920ca31ed040bc18383a7b https://github.com/openSUSE/open-build-service/commit/f6a31a585829639712920… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: A src/api/app/jobs/populate_to_sphinx_job.rb R src/api/app/models/concerns/append_sphinx_callbacks.rb M src/api/app/models/package.rb M src/api/app/models/project.rb Log Message: ----------- Merge pull request #11261 from danidoni/recover-from-sphinx-errors-when-creating-a-project Handle the project and package indexing offline Compare: https://github.com/openSUSE/open-build-service/compare/d1f2c1e1601b...f6a31…

1 0

[openSUSE/open-build-service] 08ad6f: Move code from Webui::FlashHelper helper in the view
by Dany Marcoux 23 Jun '21

23 Jun '21

Branch: refs/heads/next_rails-6 Home: https://github.com/openSUSE/open-build-service Commit: 08ad6f00e05984793c3259915c21eb5f879047a7 https://github.com/openSUSE/open-build-service/commit/08ad6f00e05984793c325… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: R src/api/app/helpers/webui/flash_helper.rb M src/api/app/views/layouts/webui/_flash.html.haml R src/api/spec/helpers/webui/flash_helper_spec.rb Log Message: ----------- Move code from Webui::FlashHelper helper in the view The spec is somehow failing in Rails 6.1.x, although not in Rails 6.0.x. It's also not testing much...

1 0

[openSUSE/open-build-service] 9d5b93: Use body as root to find the collapse/uncollapse b...
by Rubhan Azeem 23 Jun '21

23 Jun '21

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9d5b9349053f7d4bfb6eae1bf02d2e7eeae07093 https://github.com/openSUSE/open-build-service/commit/9d5b9349053f7d4bfb6ea… Author: Rubhan Azeem <rubhanazeem(a)gmail.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M src/api/app/assets/javascripts/webui/packages.js Log Message: ----------- Use body as root to find the collapse/uncollapse buttons It was needed because partials are rendered dynamically by AJAX and getting elements with class is not enough to find the element in DOM. Commit: 64fdf3ce0e8133f459be207eecdae866738414f2 https://github.com/openSUSE/open-build-service/commit/64fdf3ce0e8133f459be2… Author: Rubhan Azeem <rubhanazeem(a)gmail.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/app/assets/javascripts/webui/request.js M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/app/views/webui/request/_sourcediff_tab.html.haml A src/api/app/views/webui/request/request_action.js.erb M src/api/app/views/webui/request/show.html.haml M src/api/config/routes/webui_routes.rb M src/api/test/unit/bs_request_test.rb Log Message: ----------- Improve performance of Request#show with multiple actions Request#show was loading the complete diff history in a single HTTP request which was time consuming and even crashing the browser due to large html content. Now the content can be loaded based on separate actions. And we don't make ajax calls for already loaded diffs. Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Commit: c836233a9d1cad91135be1bcf9e6eb1b8d6690fc https://github.com/openSUSE/open-build-service/commit/c836233a9d1cad91135be… Author: Rubhan Azeem <rubhanazeem(a)gmail.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/not_setting_a_target_package/creates_a_BsRequest_with_the_source_package_name.yml M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/prefill_form_for_a_branched_package/fills_in_the_submission_reasons_and_creates_a_BsRequest.yml M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/setting_a_target_package/creates_a_BsRequest_with_target_package_name.yml M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/supersede_a_request/creates_a_BsRequest_and_supersede_only_the_selected_request_s_.yml M src/api/spec/cassettes/Comments/answering_comments.yml M src/api/spec/cassettes/MaintenanceWorkflow/maintenance_workflow.yml M src/api/spec/cassettes/Packages/adding_a_valid_file.yml M src/api/spec/cassettes/Packages/adding_an_invalid_file.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_an_existing_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_non_existent_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_role_to_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Remove_role_from_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Viewing_group_roles.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_an_existing_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_non_existent_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_role_to_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Remove_role_from_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Remove_user_from_package_/_project.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Viewing_user_roles.yml M src/api/spec/cassettes/Packages/branching_a_package_from_another_users_project/with_AutoCleanup.yml M src/api/spec/cassettes/Packages/branching_a_package_from_another_users_project/without_AutoCleanup.yml M src/api/spec/cassettes/Packages/editing_package_files/editing_an_existing_file.yml M src/api/spec/cassettes/Patchinfo/create_Patchinfo/form_complete.yml M src/api/spec/cassettes/Projects/locked_projects/fail_to_unlock.yml M src/api/spec/cassettes/Projects/maintenance_incidents/visiting_the_maintenance_overview.yml M src/api/spec/cassettes/Watchlists/add_projects_to_watchlist.yml M src/api/spec/cassettes/Watchlists/remove_projects_from_watchlist.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_4_1_3_2_1.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_4_1_3_2_2.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_superseded/1_4_1_3_1_1.yml M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/test/unit/bs_request_test.rb Log Message: ----------- Adapt tests and update cassettes Extract diffs test from #show to #request_action and update VCR cassettes Commit: d1f2c1e1601ba9e96f29fab186fbe65af2e254d6 https://github.com/openSUSE/open-build-service/commit/d1f2c1e1601ba9e96f29f… Author: Rubhan Azeem <rubhanazeem(a)gmail.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/app/assets/javascripts/webui/packages.js M src/api/app/assets/javascripts/webui/request.js M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/app/views/webui/request/_sourcediff_tab.html.haml A src/api/app/views/webui/request/request_action.js.erb M src/api/app/views/webui/request/show.html.haml M src/api/config/routes/webui_routes.rb M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/not_setting_a_target_package/creates_a_BsRequest_with_the_source_package_name.yml M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/prefill_form_for_a_branched_package/fills_in_the_submission_reasons_and_creates_a_BsRequest.yml M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/setting_a_target_package/creates_a_BsRequest_with_target_package_name.yml M src/api/spec/cassettes/Bootstrap_Requests_Submissions/submit_package/supersede_a_request/creates_a_BsRequest_and_supersede_only_the_selected_request_s_.yml M src/api/spec/cassettes/Comments/answering_comments.yml M src/api/spec/cassettes/MaintenanceWorkflow/maintenance_workflow.yml M src/api/spec/cassettes/Packages/adding_a_valid_file.yml M src/api/spec/cassettes/Packages/adding_an_invalid_file.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_an_existing_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_non_existent_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_role_to_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Remove_role_from_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Viewing_group_roles.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_an_existing_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_non_existent_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_role_to_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Remove_role_from_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Remove_user_from_package_/_project.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Viewing_user_roles.yml M src/api/spec/cassettes/Packages/branching_a_package_from_another_users_project/with_AutoCleanup.yml M src/api/spec/cassettes/Packages/branching_a_package_from_another_users_project/without_AutoCleanup.yml M src/api/spec/cassettes/Packages/editing_package_files/editing_an_existing_file.yml M src/api/spec/cassettes/Patchinfo/create_Patchinfo/form_complete.yml M src/api/spec/cassettes/Projects/locked_projects/fail_to_unlock.yml M src/api/spec/cassettes/Projects/maintenance_incidents/visiting_the_maintenance_overview.yml M src/api/spec/cassettes/Watchlists/add_projects_to_watchlist.yml M src/api/spec/cassettes/Watchlists/remove_projects_from_watchlist.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_ASCII_files/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_not_requested/for_archives/behaves_like_a_full_diff_not_requested_for/shows_the_truncated_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_ASCII_files/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/does_not_show_a_hint.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/full_diff_requested/for_archives/behaves_like_a_full_diff_requested_for/shows_the_complete_diff.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_4_1_3_2_1.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_not_superseded/1_4_1_3_2_2.yml A src/api/spec/cassettes/Webui_RequestController/GET_request_action/handling_diff_sizes/with_diff_to_superseded_set/and_the_superseded_request_is_superseded/1_4_1_3_1_1.yml M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/test/unit/bs_request_test.rb Log Message: ----------- Merge pull request #11260 from rubhanazeem/improve-req-show Improve performance of Request#show with multiple actions Compare: https://github.com/openSUSE/open-build-service/compare/36b8d065961a...d1f2c…

1 0

[openSUSE/open-build-service] 5c740e: [api] add attribute to enforce revisions in requests
by Henne Vogelsang 23 Jun '21

23 Jun '21

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5c740e33bbb92f3a3d014ddddbcaaa6c86a2a898 https://github.com/openSUSE/open-build-service/commit/5c740e33bbb92f3a3d014… Author: Adrian Schröter <adrian(a)suse.de> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/app/models/bs_request_action.rb M src/api/db/attribute_descriptions.rb A src/api/db/data/20210409135426_add_enforce_revision.rb M src/api/test/fixtures/attrib_types.yml M src/api/test/functional/attributes_test.rb M src/api/test/functional/request_controller_test.rb Log Message: ----------- [api] add attribute to enforce revisions in requests Target projects may decide always to get requests with versioned actions. Note: revisions to unexpanded sources are still possible! Commit: 201525425f1be220085c2174fc9cdaa5da1f53ea https://github.com/openSUSE/open-build-service/commit/201525425f1be220085c2… Author: Stephan Kulow <coolo(a)suse.de> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/app/models/bs_request_action.rb Log Message: ----------- Fix Xmlhash usage in BsRequestAction Commit: e32b567f0ba7ca4e7ef40ba1f1248a1b48455e65 https://github.com/openSUSE/open-build-service/commit/e32b567f0ba7ca4e7ef40… Author: Stephan Kulow <coolo(a)suse.de> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: A src/api/spec/cassettes/BsRequestAction/check_expand_errors/RevisionEnforcing_enabled/adds_revision.yml A src/api/spec/cassettes/BsRequestAction/check_expand_errors/Without_RevisionEnforcing/doesn_t_add_revision.yml M src/api/spec/models/bs_request_action_spec.rb Log Message: ----------- Add a spec for behavior with OBS:EnforceRevisionInRequests Commit: 0ce8b50e12b493b1b07086b24a4c024d440a4009 https://github.com/openSUSE/open-build-service/commit/0ce8b50e12b493b1b0708… Author: Stephan Kulow <coolo(a)suse.de> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/app/models/bs_request_action.rb A src/api/spec/cassettes/BsRequestAction/check_expand_errors/RevisionEnforcing_enabled/with__link_in_submitted_source/adds_revision.yml A src/api/spec/cassettes/BsRequestAction/check_expand_errors/RevisionEnforcing_enabled/with__link_in_submitted_source/freezes_revision.yml M src/api/spec/models/bs_request_action_spec.rb Log Message: ----------- Always set the enforced revision in requests Once the request is created, we take the given revision, expand the sources and take the revision given by the backend in the database. So if any of the components of the submitted sources is changed afterwards, they don't invalidate reviews Commit: 313fb27dcd79f9ba07a4ae39cc8d3fdad1dd26ac https://github.com/openSUSE/open-build-service/commit/313fb27dcd79f9ba07a4a… Author: Stephan Kulow <coolo(a)suse.de> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/app/models/bs_request_action.rb Log Message: ----------- Update src/api/app/models/bs_request_action.rb Make the comment a little clearer Co-authored-by: Henne Vogelsang <hvogel(a)opensuse.org> Commit: 088b1b9931b45609e92efa8f7584d631dcccd80f https://github.com/openSUSE/open-build-service/commit/088b1b9931b45609e92ef… Author: Stephan Kulow <coolo(a)suse.de> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/app/models/bs_request_action.rb A src/api/spec/cassettes/BsRequestAction/check_expand_errors/RevisionEnforcing_enabled/with__link_in_submitted_source/with_updatelink/throws_exception.yml M src/api/spec/factories/bs_requests.rb M src/api/spec/models/bs_request_action_spec.rb Log Message: ----------- Raise an exception if updatelink is used in enforced projects For OBS:EnforceRevisionsInRequests projects we want to be certain what we review is what we accept - and as such we don't want links to point anywhere, so that updatelink option is incompatible to that use case Commit: a054d7e6fdf4be79a6e4c891d02ea879def27079 https://github.com/openSUSE/open-build-service/commit/a054d7e6fdf4be79a6e4c… Author: Stephan Kulow <coolo(a)suse.de> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/app/models/bs_request_action.rb Log Message: ----------- EnforceRevision: Run the check unconditionally As Marcus pointed out if we skip the check if add_revision is set, then the user can skip that by setting add_revision, but having an updatelink option set. As we wouldn't throw the exception in these cases, it would end up in the database and potentially only noticed on accept Commit: 36b8d065961aebea83449993ba53e84c41586894 https://github.com/openSUSE/open-build-service/commit/36b8d065961aebea83449… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/app/models/bs_request_action.rb M src/api/db/attribute_descriptions.rb A src/api/db/data/20210409135426_add_enforce_revision.rb A src/api/spec/cassettes/BsRequestAction/check_expand_errors/RevisionEnforcing_enabled/adds_revision.yml A src/api/spec/cassettes/BsRequestAction/check_expand_errors/RevisionEnforcing_enabled/with__link_in_submitted_source/adds_revision.yml A src/api/spec/cassettes/BsRequestAction/check_expand_errors/RevisionEnforcing_enabled/with__link_in_submitted_source/freezes_revision.yml A src/api/spec/cassettes/BsRequestAction/check_expand_errors/RevisionEnforcing_enabled/with__link_in_submitted_source/with_updatelink/throws_exception.yml A src/api/spec/cassettes/BsRequestAction/check_expand_errors/Without_RevisionEnforcing/doesn_t_add_revision.yml M src/api/spec/factories/bs_requests.rb M src/api/spec/models/bs_request_action_spec.rb M src/api/test/fixtures/attrib_types.yml M src/api/test/functional/attributes_test.rb M src/api/test/functional/request_controller_test.rb Log Message: ----------- Merge pull request #11263 from coolo/adrianschroeter-add_revision_enforcement Add revision enforcement Compare: https://github.com/openSUSE/open-build-service/compare/04c6fe8cce61...36b8d…

1 0

[openSUSE/open-build-service] 52f35e: Update rubocop-rails to version 2.11.0
by Dany Marcoux 23 Jun '21

23 Jun '21

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 52f35e4d8c7b6069b772e21fe4bee6147deb20e4 https://github.com/openSUSE/open-build-service/commit/52f35e4d8c7b6069b772e… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop-rails to version 2.11.0 Commit: 1b9d8980bafd93a4275b70d7700fc15a24164da4 https://github.com/openSUSE/open-build-service/commit/1b9d8980bafd93a4275b7… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/.rubocop_todo.yml Log Message: ----------- Regenerate the RuboCop TODO Commit: ba3eb2f8abf5ec2582c722091182c20e74490a87 https://github.com/openSUSE/open-build-service/commit/ba3eb2f8abf5ec2582c72… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/helpers/flag_helper.rb M src/api/app/jobs/create_job.rb M src/api/app/jobs/status_history_rescaler_job.rb M src/api/app/lib/authenticator.rb M src/api/app/lib/backend/connection.rb M src/api/app/lib/backend/logger.rb M src/api/app/lib/backend/test.rb M src/api/app/lib/backend/test/tasks.rb M src/api/app/models/directory.rb M src/api/app/models/event/base.rb M src/api/app/models/event/factory.rb M src/api/app/models/package.rb M src/api/app/models/package_build_status.rb M src/api/app/models/project/update_from_xml_command.rb M src/api/app/models/service.rb M src/api/app/models/user_ldap_strategy.rb M src/api/lib/tasks/delayed_job.rake Log Message: ----------- Auto-correct Rails/EagerEvaluationLogMessage ... ... RuboCop offenses Commit: 04c6fe8cce6113729f87e0f35a727fb4960a2dc6 https://github.com/openSUSE/open-build-service/commit/04c6fe8cce6113729f87e… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/.rubocop_todo.yml M src/api/Gemfile.lock M src/api/app/helpers/flag_helper.rb M src/api/app/jobs/create_job.rb M src/api/app/jobs/status_history_rescaler_job.rb M src/api/app/lib/authenticator.rb M src/api/app/lib/backend/connection.rb M src/api/app/lib/backend/logger.rb M src/api/app/lib/backend/test.rb M src/api/app/lib/backend/test/tasks.rb M src/api/app/models/directory.rb M src/api/app/models/event/base.rb M src/api/app/models/event/factory.rb M src/api/app/models/package.rb M src/api/app/models/package_build_status.rb M src/api/app/models/project/update_from_xml_command.rb M src/api/app/models/service.rb M src/api/app/models/user_ldap_strategy.rb M src/api/lib/tasks/delayed_job.rake Log Message: ----------- Merge pull request #11270 from openSUSE/depfu/update/srcapi/rubocop-rails-2.11.0 [src/api] Update rubocop-rails: 2.9.1 → 2.11.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/3f6dd34b9742...04c6f…

1 0

[openSUSE/open-build-service]
by Dany Marcoux 23 Jun '21

23 Jun '21

Branch: refs/heads/depfu/update/srcapi/rubocop-rails-2.11.0 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] 1b9d89: Regenerate the RuboCop TODO
by Eduardo J. 23 Jun '21

23 Jun '21

Branch: refs/heads/depfu/update/srcapi/rubocop-rails-2.11.0 Home: https://github.com/openSUSE/open-build-service Commit: 1b9d8980bafd93a4275b70d7700fc15a24164da4 https://github.com/openSUSE/open-build-service/commit/1b9d8980bafd93a4275b7… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/.rubocop_todo.yml Log Message: ----------- Regenerate the RuboCop TODO Commit: ba3eb2f8abf5ec2582c722091182c20e74490a87 https://github.com/openSUSE/open-build-service/commit/ba3eb2f8abf5ec2582c72… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/helpers/flag_helper.rb M src/api/app/jobs/create_job.rb M src/api/app/jobs/status_history_rescaler_job.rb M src/api/app/lib/authenticator.rb M src/api/app/lib/backend/connection.rb M src/api/app/lib/backend/logger.rb M src/api/app/lib/backend/test.rb M src/api/app/lib/backend/test/tasks.rb M src/api/app/models/directory.rb M src/api/app/models/event/base.rb M src/api/app/models/event/factory.rb M src/api/app/models/package.rb M src/api/app/models/package_build_status.rb M src/api/app/models/project/update_from_xml_command.rb M src/api/app/models/service.rb M src/api/app/models/user_ldap_strategy.rb M src/api/lib/tasks/delayed_job.rake Log Message: ----------- Auto-correct Rails/EagerEvaluationLogMessage ... ... RuboCop offenses Compare: https://github.com/openSUSE/open-build-service/compare/52f35e4d8c7b...ba3eb…

1 0