[opensuse-kernel] Objection to CONFIG_GPIO_INTEL_MID=y
Hi Michal, In the linux-next branch you have set CONFIG_GPIO_INTEL_MID=y. I object to that. Hardware-specific drivers which can't be modularized are evil and should not be included in our kernel. I am also questioning CONFIG_ARM_ARCH_TIMER_EVTSTREAM=y in non-ARM configs. The option name looks very much ARM-specific and I wonder why it is even available on other architectures. I'll ask upstream... Thanks, -- Jean Delvare Suse L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
At Thu, 14 Nov 2013 15:22:26 +0100, Jean Delvare wrote:
I am also questioning CONFIG_ARM_ARCH_TIMER_EVTSTREAM=y in non-ARM configs. The option name looks very much ARM-specific and I wonder why it is even available on other architectures. I'll ask upstream...
Obviously a bug in Kconfig item. It should be "depends on ..." instead of "default y if ..." Takashi -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi Takashi, Le Thursday 14 November 2013 à 16:00 +0100, Takashi Iwai a écrit :
At Thu, 14 Nov 2013 15:22:26 +0100, Jean Delvare wrote:
I am also questioning CONFIG_ARM_ARCH_TIMER_EVTSTREAM=y in non-ARM configs. The option name looks very much ARM-specific and I wonder why it is even available on other architectures. I'll ask upstream...
Obviously a bug in Kconfig item. It should be "depends on ..." instead of "default y if ..."
You're right. I've posted a fix upstream: https://lkml.org/lkml/2013/11/14/427 -- Jean Delvare Suse L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Dne 14.11.2013 15:22, Jean Delvare napsal(a):
In the linux-next branch you have set CONFIG_GPIO_INTEL_MID=y. I object to that. Hardware-specific drivers which can't be modularized are evil and should not be included in our kernel.
I am also questioning CONFIG_ARM_ARCH_TIMER_EVTSTREAM=y in non-ARM configs.
Thanks for noticing this. The vanilla and linux-next branches are updated by a script, that simply does an allmodconfig with the previous config as a base. So settings like this are no surprise. I fixed both now. Michal -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (3)
-
Jean Delvare
-
Michal Marek
-
Takashi Iwai