-----Original Message----- From: Michal Kubecek Sent: 07 January 2020 12:17 To: opensuse-kernel@opensuse.org Cc: Guillaume Gardet Subject: Re: [opensuse-kernel] Some kmp fail to build for Leap 15.2 ARM

On Tue, Jan 07, 2020 at 10:10:33AM +0000, Guillaume Gardet wrote:

...

Hi,

Since mid-december, mali kmp fail to build on Leap 15.2 aarch64 with: ERROR: "mm_trace_rss_stat" [/home/abuild/rpmbuild/BUILD/driver/product/kernel/drivers/gpu/arm/midgar d/mali_kbase.ko] undefined!

JobHistory: https://build.opensuse.org/packages/mali-bifrost-kmp/job_history/devel :ARM:Factory:Contrib:Mali/openSUSE_Leap_15.2/aarch64

We probably need to add: EXPORT_SYMBOL_GPL(mm_trace_rss_stat); In mm/memory.c

But it is unclear why Tumbleweed (still at 5.3) and SLE15-SP2 are fine. Any idea what causes this difference?

The function was added by mainline commit b3d1411b6726 ("mm: emit tracepoint when RSS changes") in 5.5-rc1 so it's no surprise it's not in 5.3 TW kernel (and likely won't be even in 5.4 one).

This commit was backported to SLE15-SP2 in early December and we had some trouble with SLE15-SP2 snapshots recently so it's possible this backport didn't make it into the OBS mirror of SLE15-SP2 yet (or not into the repository you are building against) but the openSUSE-15.2 snapshot is a bit ahead.

Ok. Any idea why it needs this symbol, whereas my kmp does not require it? I guess other kmp may also be affected, so, I will send a patch for Leap 15.2 / SLE15-SP2 kernel, to export this symbol. Any objection? Guillaume

Michal Kubecek

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

-----Original Message----- From: Takashi Iwai Sent: 07 January 2020 13:59 To: Guillaume Gardet Cc: Michal Kubecek ; opensuse-kernel@opensuse.org Subject: Re: [opensuse-kernel] Some kmp fail to build for Leap 15.2 ARM

On Tue, 07 Jan 2020 13:48:40 +0100, Guillaume Gardet wrote:

...

...

-----Original Message----- From: Michal Kubecek Sent: 07 January 2020 12:17 To: opensuse-kernel@opensuse.org Cc: Guillaume Gardet Subject: Re: [opensuse-kernel] Some kmp fail to build for Leap 15.2 ARM

On Tue, Jan 07, 2020 at 10:10:33AM +0000, Guillaume Gardet wrote:

...

Hi,

Since mid-december, mali kmp fail to build on Leap 15.2 aarch64 with: ERROR: "mm_trace_rss_stat" [/home/abuild/rpmbuild/BUILD/driver/product/kernel/drivers/gpu/arm/m idgar d/mali_kbase.ko] undefined!

JobHistory: https://build.opensuse.org/packages/mali-bifrost-kmp/job_history/d evel :ARM:Factory:Contrib:Mali/openSUSE_Leap_15.2/aarch64

We probably need to add: EXPORT_SYMBOL_GPL(mm_trace_rss_stat); In mm/memory.c

But it is unclear why Tumbleweed (still at 5.3) and SLE15-SP2 are fine. Any idea what causes this difference?

The function was added by mainline commit b3d1411b6726 ("mm: emit tracepoint when RSS changes") in 5.5-rc1 so it's no surprise it's not in 5.3 TW kernel (and likely won't be even in 5.4 one).

This commit was backported to SLE15-SP2 in early December and we had some trouble with SLE15-SP2 snapshots recently so it's possible this backport didn't make it into the OBS mirror of SLE15-SP2 yet (or not into the repository you are building against) but the openSUSE-15.2 snapshot

is a bit ahead.

...

Ok. Any idea why it needs this symbol, whereas my kmp does not require it?

I guess other kmp may also be affected, so, I will send a patch for Leap 15.2 /

SLE15-SP2 kernel, to export this symbol.

...

Any objection?

Does the upstream kernel have the export, too? If yes, we may simply backport that commit. If it's not in the upstream, we should check the status with the upstream kernel at first.

AFAIK, there is no upstream commit for this export, yet. Guillaume

thanks,

Takashi

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org

-----Original Message----- From: Takashi Iwai Sent: 07 January 2020 14:22 To: Guillaume Gardet Cc: Michal Kubecek ; opensuse-kernel@opensuse.org Subject: Re: [opensuse-kernel] Some kmp fail to build for Leap 15.2 ARM

On Tue, 07 Jan 2020 14:15:51 +0100, Guillaume Gardet wrote:

...

...

-----Original Message----- From: Takashi Iwai Sent: 07 January 2020 13:59 To: Guillaume Gardet Cc: Michal Kubecek ; opensuse-kernel@opensuse.org Subject: Re: [opensuse-kernel] Some kmp fail to build for Leap 15.2 ARM

On Tue, 07 Jan 2020 13:48:40 +0100, Guillaume Gardet wrote:

...

...

-----Original Message----- From: Michal Kubecek Sent: 07 January 2020 12:17 To: opensuse-kernel@opensuse.org Cc: Guillaume Gardet Subject: Re: [opensuse-kernel] Some kmp fail to build for Leap 15.2 ARM

On Tue, Jan 07, 2020 at 10:10:33AM +0000, Guillaume Gardet wrote:

...

Hi,

Since mid-december, mali kmp fail to build on Leap 15.2 aarch64 with: ERROR: "mm_trace_rss_stat" [/home/abuild/rpmbuild/BUILD/driver/product/kernel/drivers/gpu/a rm/m idgar d/mali_kbase.ko] undefined!

JobHistory: https://build.opensuse.org/packages/mali-bifrost-kmp/job_histo ry/d evel :ARM:Factory:Contrib:Mali/openSUSE_Leap_15.2/aarch64

We probably need to add: EXPORT_SYMBOL_GPL(mm_trace_rss_stat); In mm/memory.c

But it is unclear why Tumbleweed (still at 5.3) and SLE15-SP2 are fine. Any idea what causes this difference?

The function was added by mainline commit b3d1411b6726 ("mm: emit tracepoint when RSS changes") in 5.5-rc1 so it's no surprise it's not in 5.3 TW kernel (and likely won't be even in 5.4 one).

This commit was backported to SLE15-SP2 in early December and we had some trouble with SLE15-SP2 snapshots recently so it's possible this backport didn't make it into the OBS mirror of SLE15-SP2 yet (or not into the repository you are building against) but the openSUSE-15.2 snapshot

is a bit ahead.

...

Ok. Any idea why it needs this symbol, whereas my kmp does not require it?

I guess other kmp may also be affected, so, I will send a patch for Leap 15.2 /

SLE15-SP2 kernel, to export this symbol.

...

Any objection?

Does the upstream kernel have the export, too? If yes, we may simply backport that commit. If it's not in the upstream, we should check the status with the upstream kernel at first.

AFAIK, there is no upstream commit for this export, yet.

Then let's go for the upstream at first, and backport to SLE15-SP2 afterwards. That's the upstream-first rule, after all ;)

In anyway, care to open a bugzilla entry if not done yet?

Done: https://bugzilla.opensuse.org/show_bug.cgi?id=1160253 Thanks, Guillaume

thanks,

Takashi

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org