[opensuse-kernel] [PATCH] config/armv7hl: Clean up TS-4800 support
The Technologic Systems TS-4800 is an i.MX515 board. The lpae flavor doesn't support this platform so it shouldn't include any TS-4800 driver. The default and vanilla flavors do support it. If we want them to support the board properly then all its drivers should be enabled. --- I assume we want to support the TS-4800. If this is not the case then this patch needs to be modified. Dirk? config/armv7hl/default | 4 ++-- config/armv7hl/lpae | 2 +- config/armv7hl/vanilla | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) --- a/config/armv7hl/default +++ b/config/armv7hl/default @@ -3396,7 +3396,7 @@ CONFIG_TOUCHSCREEN_USB_ETT_TC45USB=y CONFIG_TOUCHSCREEN_USB_NEXIO=y CONFIG_TOUCHSCREEN_USB_EASYTOUCH=y CONFIG_TOUCHSCREEN_TOUCHIT213=m -# CONFIG_TOUCHSCREEN_TS4800 is not set +CONFIG_TOUCHSCREEN_TS4800=m CONFIG_TOUCHSCREEN_TSC_SERIO=m CONFIG_TOUCHSCREEN_TSC200X_CORE=m CONFIG_TOUCHSCREEN_TSC2004=m @@ -7498,7 +7498,7 @@ CONFIG_DW_APB_ICTL=y CONFIG_OMAP_IRQCHIP=y CONFIG_ORION_IRQCHIP=y CONFIG_ST_IRQCHIP=y -# CONFIG_TS4800_IRQ is not set +CONFIG_TS4800_IRQ=m CONFIG_IRQ_CROSSBAR=y CONFIG_KEYSTONE_IRQ=m CONFIG_IPACK_BUS=m --- a/config/armv7hl/lpae +++ b/config/armv7hl/lpae @@ -4155,7 +4155,7 @@ CONFIG_DAVINCI_WATCHDOG=m CONFIG_RN5T618_WATCHDOG=m CONFIG_SUNXI_WATCHDOG=m CONFIG_TWL4030_WATCHDOG=m -CONFIG_TS4800_WATCHDOG=m +# CONFIG_TS4800_WATCHDOG is not set CONFIG_MAX63XX_WATCHDOG=m # CONFIG_IMX2_WDT is not set CONFIG_TEGRA_WATCHDOG=m --- a/config/armv7hl/vanilla +++ b/config/armv7hl/vanilla @@ -3392,7 +3392,7 @@ CONFIG_TOUCHSCREEN_USB_ETT_TC45USB=y CONFIG_TOUCHSCREEN_USB_NEXIO=y CONFIG_TOUCHSCREEN_USB_EASYTOUCH=y CONFIG_TOUCHSCREEN_TOUCHIT213=m -# CONFIG_TOUCHSCREEN_TS4800 is not set +CONFIG_TOUCHSCREEN_TS4800=m CONFIG_TOUCHSCREEN_TSC_SERIO=m CONFIG_TOUCHSCREEN_TSC200X_CORE=m CONFIG_TOUCHSCREEN_TSC2004=m @@ -7492,7 +7492,7 @@ CONFIG_DW_APB_ICTL=y CONFIG_OMAP_IRQCHIP=y CONFIG_ORION_IRQCHIP=y CONFIG_ST_IRQCHIP=y -# CONFIG_TS4800_IRQ is not set +CONFIG_TS4800_IRQ=m CONFIG_IRQ_CROSSBAR=y CONFIG_KEYSTONE_IRQ=m CONFIG_IPACK_BUS=m -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi Jean,
2016-02-10 14:57 GMT+01:00 Jean Delvare
The Technologic Systems TS-4800 is an i.MX515 board. The lpae flavor doesn't support this platform so it shouldn't include any TS-4800 driver. The default and vanilla flavors do support it. If we want them to support the board properly then all its drivers should be enabled.
Correct, thank you for correcting the messup.
Reviewed-By: Dirk Mueller
Resending with correct email address..
Hi Jean,
2016-02-10 14:57 GMT+01:00 Jean Delvare
The Technologic Systems TS-4800 is an i.MX515 board. The lpae flavor doesn't support this platform so it shouldn't include any TS-4800 driver. The default and vanilla flavors do support it. If we want them to support the board properly then all its drivers should be enabled.
Correct, thank you for correcting the messup.
Reviewed-By: Dirk Mueller
Am 10.02.2016 um 14:57 schrieb Jean Delvare:
The Technologic Systems TS-4800 is an i.MX515 board. The lpae flavor doesn't support this platform so it shouldn't include any TS-4800 driver. The default and vanilla flavors do support it. If we want them to support the board properly then all its drivers should be enabled. --- I assume we want to support the TS-4800. If this is not the case then this patch needs to be modified. Dirk?
There's several bugs still in Dirk's -rc1 update. It would be really
nice a) if we could get an email notification once the arm configs are
in need_update state and b) if those of us in the know about arm could
get a chance to review the updates someone pushed - I would've objected
to the armv7hl update.
This patch seems correct based on your analysis,
Reviewed-by: Andreas Färber
Hi Andreas,
in need_update state and b) if those of us in the know about arm could get a chance to review the updates someone pushed - I would've objected to the armv7hl update.
Since I'm part of the group knowing about ARM I don't think it makes sense to formalize this more than necessary. I'll ask for review on the -arm mailing list before pushing it to the kernel tree. Greetings, Dirk -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (4)
-
Andreas Färber -
Dirk Müller -
Dirk Müller -
Jean Delvare