[opensuse-kernel] please push cgroup-disable-memory.patch upstream or drop it
Hi, after searching for hours why my memory subsystem was disabled and how to enable it - reading almost all of the cgroups kernel code, of course the upstream kernel code, I found that SUSE has a patch to disable it by default. This is "Patch-mainline: not yet" since 2½ years, and I guess it should either be pushed again or dropped - especially since it is trivially replaced by "cgroups_disable=memory" on the kernel command line. And that's a place where people would actually find how to enable it again ;-) Thanks, Stefan -- Stefan Seyfried "Any ideas, John?" "Well, surrounding them's out." -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On Sun, 19 Sep 2010 16:32:33 +0200, Stefan Seyfried wrote:
after searching for hours why my memory subsystem was disabled and how to enable it - reading almost all of the cgroups kernel code, of course the upstream kernel code, I found that SUSE has a patch to disable it by default.
In which branch? Jiri -- Jiri Benc SUSE Labs -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On 09/19/2010 10:32 AM, Stefan Seyfried wrote:
Hi,
after searching for hours why my memory subsystem was disabled and how to enable it - reading almost all of the cgroups kernel code, of course the upstream kernel code, I found that SUSE has a patch to disable it by default.
This is "Patch-mainline: not yet" since 2½ years, and I guess it should either be pushed again or dropped - especially since it is trivially replaced by "cgroups_disable=memory" on the kernel command line. And that's a place where people would actually find how to enable it again ;-)
It should be dropped. We had it because there was a very, very heavy performance overhead in it when we released SLE11 (2.6.27) but it has since been fixed. It's now dropped in master. -Jeff -- Jeff Mahoney SUSE Labs -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On Mon, 20 Sep 2010 09:11:36 -0400 Jeff Mahoney <jeffm@suse.com> wrote:
It should be dropped. We had it because there was a very, very heavy performance overhead in it when we released SLE11 (2.6.27) but it has since been fixed.
This is a mainline fix, I assume? (I'm going to talk about cgroups this week, so this might be important information for my listeners ;-)
It's now dropped in master.
Cool, thanks. -- Stefan Seyfried "Any ideas, John?" "Well, surrounding them's out." -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
On 09/20/2010 09:30 AM, Stefan Seyfried wrote:
On Mon, 20 Sep 2010 09:11:36 -0400 Jeff Mahoney<jeffm@suse.com> wrote:
It should be dropped. We had it because there was a very, very heavy performance overhead in it when we released SLE11 (2.6.27) but it has since been fixed.
This is a mainline fix, I assume? (I'm going to talk about cgroups this week, so this might be important information for my listeners ;-)
Yep. The issue was that there was a contended spinlock in the middle of the fast path for memalloc. For low numbers of CPUs it was hardly noticeable but for higher numbers of CPUs it had a serious impact. It was fixed[1] in mainline shortly after LPC last year and included in 2.6.32. -Jeff [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdif... -- Jeff Mahoney SUSE Labs -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
participants (3)
-
Jeff Mahoney -
Jiri Benc -
Stefan Seyfried