-----BEGIN PGP SIGNED MESSAGE-----
On 4/28/14, 4:23 AM, Jan Beulich wrote:
> On 27.04.14 at 22:18, <jeffm(a)suse.com>
Can you take a quick look at this? I don't have any 32-bit x86
machines to test with (or more accurately, I don't really want to
have a 32-bit install *just* to test this.)
The 32-bit builds are failing because of the removal of FIX_VDSO
and I'd rather not "fix" it with the wrong thing.
Conceptionally it looks right, but I suppose this wasn't compile
tested and/or is stale, because ...
Yep, I was just looking to confirm I got the general idea right as
this code is /way/ outside my typical area of experience. :)
b/arch/x86/include/asm/unwind.h @@ -141,8 +141,9 @@ static inline
int arch_unw_user_mode(/*c #else return
user_mode_vm(&info->regs) || info->regs.ip < PAGE_OFFSET -
|| (info->regs.ip >= __fix_to_virt(FIX_VDSO) - &&
info->regs.ip < __fix_to_virt(FIX_VDSO) + PAGE_SIZE) + ||
(info->mm->context.vdso && + info->regs.ip >=
info->mm->context.vdso && + info->regs.ip <
info->mm_context.vdso + vdso32_size)
... struct unwind_frame_info has no member "mm" or "mm_context",
and the patch also doesn't add one. Depending on what your
intentions here really were, ->mm (or, if you meant
info->task->mm->, ->task and ->task->mm) may additionally need
checking to be non-NULL here.
Ok, thanks. That's easy enough.
Additionally I think this tells us that we may need to
older trees in this way too, to account for the VDSO_ENABLED case.
Yeah, it looks that way. I'd imagine the final patch should be a
pretty easy backport if we want to bother with it.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
-----END PGP SIGNATURE-----
To unsubscribe, e-mail: opensuse-kernel+unsubscribe(a)opensuse.org
To contact the owner, e-mail: opensuse-kernel+owner(a)opensuse.org