[opensuse-kernel] factory: armv7l: fix kernel build
From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001 From: "Matwey V. Kornilov"
Date: Mon, 2 Jun 2014 20:17:29 +0400 Subject: [PATCH] Replace type of paddr to uint32_t.
This patch helps to avoid the following build issue:
drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror]
msm_gem_get_iova_locked(fbdev->bo, 0, &paddr);
^
In file included from drivers/gpu/drm/msm/msm_fbdev.c:18:0:
drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but argument is of type 'dma_addr_t *'
int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id,
^
Signed-off-by: Matwey V. Kornilov
Am 11.06.2014 10:37, schrieb matwey.kornilov@gmail.com:
From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001 From: "Matwey V. Kornilov"
Date: Mon, 2 Jun 2014 20:17:29 +0400 Subject: [PATCH] Replace type of paddr to uint32_t. This patch helps to avoid the following build issue:
drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror] msm_gem_get_iova_locked(fbdev->bo, 0, &paddr); ^ In file included from drivers/gpu/drm/msm/msm_fbdev.c:18:0: drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but argument is of type 'dma_addr_t *' int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id, ^
Signed-off-by: Matwey V. Kornilov
Patch-mainline: Submitted, 1401879270 - linux-arm-msm@vger.kernel.org Signed-off-by: Matwey V. Kornilov --- This is for Factory, 3.15 is still failed for armv7l.
Ping! Patch is queued on msm-fixes-3.16 (with modified subject, additional Sob): http://cgit.freedesktop.org/~robclark/linux/commit/?h=msm-fixes-3.16&id=70bdd6c7c8e4d36b336f0b6f8b653aa9db3a6f33 Can we please get this applied as build fix for kernel-default and kernel-lpae? Thanks, Andreas
drivers/gpu/drm/msm/msm_fbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c index a752ab8..5107fc4 100644 --- a/drivers/gpu/drm/msm/msm_fbdev.c +++ b/drivers/gpu/drm/msm/msm_fbdev.c @@ -59,7 +59,7 @@ static int msm_fbdev_create(struct drm_fb_helper *helper, struct drm_framebuffer *fb = NULL; struct fb_info *fbi = NULL; struct drm_mode_fb_cmd2 mode_cmd = {0}; - dma_addr_t paddr; + uint32_t paddr; int ret, size;
sizes->surface_bpp = 32;
-- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi Andreas, Matwey, Le Saturday 21 June 2014 à 17:31 +0200, Andreas Färber a écrit :
Am 11.06.2014 10:37, schrieb matwey.kornilov@gmail.com:
From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001 From: "Matwey V. Kornilov"
Date: Mon, 2 Jun 2014 20:17:29 +0400 Subject: [PATCH] Replace type of paddr to uint32_t. This patch helps to avoid the following build issue:
drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror] msm_gem_get_iova_locked(fbdev->bo, 0, &paddr); ^ In file included from drivers/gpu/drm/msm/msm_fbdev.c:18:0: drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but argument is of type 'dma_addr_t *' int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id, ^
Signed-off-by: Matwey V. Kornilov
Patch-mainline: Submitted, 1401879270 - linux-arm-msm@vger.kernel.org Signed-off-by: Matwey V. Kornilov --- This is for Factory, 3.15 is still failed for armv7l.
Ping! Patch is queued on msm-fixes-3.16 (with modified subject, additional Sob):
Can we please get this applied as build fix for kernel-default and kernel-lpae?
The upstream discussion game me the impression that this patch would not make it upstream: http://www.spinics.net/lists/linux-arm-msm/msg09616.html -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Am 23.06.2014 15:21, schrieb Jean Delvare:
Hi Andreas, Matwey,
Le Saturday 21 June 2014 à 17:31 +0200, Andreas Färber a écrit :
Am 11.06.2014 10:37, schrieb matwey.kornilov@gmail.com:
From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001 From: "Matwey V. Kornilov"
Date: Mon, 2 Jun 2014 20:17:29 +0400 Subject: [PATCH] Replace type of paddr to uint32_t. This patch helps to avoid the following build issue:
drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror] msm_gem_get_iova_locked(fbdev->bo, 0, &paddr); ^ In file included from drivers/gpu/drm/msm/msm_fbdev.c:18:0: drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but argument is of type 'dma_addr_t *' int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id, ^
Signed-off-by: Matwey V. Kornilov
Patch-mainline: Submitted, 1401879270 - linux-arm-msm@vger.kernel.org Signed-off-by: Matwey V. Kornilov --- This is for Factory, 3.15 is still failed for armv7l.
Ping! Patch is queued on msm-fixes-3.16 (with modified subject, additional Sob):
Can we please get this applied as build fix for kernel-default and kernel-lpae?
The upstream discussion game me the impression that this patch would not make it upstream: http://www.spinics.net/lists/linux-arm-msm/msg09616.html
Rob rejected that suggestion (and confirmed on IRC): http://www.spinics.net/lists/linux-arm-msm/msg09621.html His pull was supposed to go out this weekend but missed -rc2 apparently. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi Andreas, Le Monday 23 June 2014 à 15:41 +0200, Andreas Färber a écrit :
Am 23.06.2014 15:21, schrieb Jean Delvare:
Le Saturday 21 June 2014 à 17:31 +0200, Andreas Färber a écrit :
Ping! Patch is queued on msm-fixes-3.16 (with modified subject, additional Sob):
Can we please get this applied as build fix for kernel-default and kernel-lpae?
The upstream discussion game me the impression that this patch would not make it upstream: http://www.spinics.net/lists/linux-arm-msm/msg09616.html
Rob rejected that suggestion (and confirmed on IRC): http://www.spinics.net/lists/linux-arm-msm/msg09621.html
His pull was supposed to go out this weekend but missed -rc2 apparently.
Sorry for the late reply, I have just pushed the fix to the master branch. I think it is needed on the stable branch too (i.e. kernel 3.15 is affected too), right? -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
2014-07-01 12:23 GMT+04:00 Jean Delvare
Sorry for the late reply, I have just pushed the fix to the master branch.
I think it is needed on the stable branch too (i.e. kernel 3.15 is affected too), right?
Yes, it is. p.s. ARM has been dissapeared from Kernel:HEAD. Why? -- With best regards, Matwey V. Kornilov http://blog.matwey.name xmpp:0x2207@jabber.ru -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Le Tuesday 01 July 2014 à 12:28 +0400, Matwey V. Kornilov a écrit :
2014-07-01 12:23 GMT+04:00 Jean Delvare
: Sorry for the late reply, I have just pushed the fix to the master branch.
I think it is needed on the stable branch too (i.e. kernel 3.15 is affected too), right?
Yes, it is.
OK, fix pushed to the stable kernel branch too.
p.s. ARM has been dissapeared from Kernel:HEAD. Why?
No idea, I'm not responsible for that, sorry. -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi, Le 01/07/2014 10:44, Jean Delvare a écrit :
Le Tuesday 01 July 2014 à 12:28 +0400, Matwey V. Kornilov a écrit :
2014-07-01 12:23 GMT+04:00 Jean Delvare
: Sorry for the late reply, I have just pushed the fix to the master branch.
I think it is needed on the stable branch too (i.e. kernel 3.15 is affected too), right? Yes, it is. OK, fix pushed to the stable kernel branch too.
p.s. ARM has been dissapeared from Kernel:HEAD. Why? No idea, I'm not responsible for that, sorry.
At each kernel version upgrade, ARM is disabled until "ARM people" take care of new options and re-enable ARM configs. See: http://kernel.opensuse.org/cgit/kernel-source/commit/?id=6ff907a8876f8dbf06d... Guillaume -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
2014-07-01 12:47 GMT+04:00 Guillaume Gardet
At each kernel version upgrade, ARM is disabled until "ARM people" take care of new options and re-enable ARM configs. See: http://kernel.opensuse.org/cgit/kernel-source/commit/?id=6ff907a8876f8dbf06d...
Now I see, thank you. -- With best regards, Matwey V. Kornilov http://blog.matwey.name xmpp:0x2207@jabber.ru -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Am 01.07.2014 10:47, schrieb Guillaume Gardet:
Le 01/07/2014 10:44, Jean Delvare a écrit :
Le Tuesday 01 July 2014 à 12:28 +0400, Matwey V. Kornilov a écrit :
2014-07-01 12:23 GMT+04:00 Jean Delvare
: Sorry for the late reply, I have just pushed the fix to the master branch.
I think it is needed on the stable branch too (i.e. kernel 3.15 is affected too), right? Yes, it is. OK, fix pushed to the stable kernel branch too.
p.s. ARM has been dissapeared from Kernel:HEAD. Why? No idea, I'm not responsible for that, sorry.
At each kernel version upgrade, ARM is disabled until "ARM people" take care of new options and re-enable ARM configs. See: http://kernel.opensuse.org/cgit/kernel-source/commit/?id=6ff907a8876f8dbf06d...
...which needs to wait on Xen patches to be applied first, as the SUSE config options are not available in upstream; then after getting ARM config updates applied, it takes days to get kernel build results, then the reported errors are not fixed until we get the next major kernel release update, yay. Not a single 3.15 ARM kernel got built. :-( Guillaume, quick reminder in case you'll be quicker than me: We need to remember to re-enable previously disabled Exynos/Samsung driver options in default and lpae for 3.16. Some machines like S5PV210 are not yet multi-platform, so I suggest we leave a stripped-down kernel-exynos flavor until it's completely gone. Not sure how to migrate users over to kernel-default then though, beyond editing our JeOS package list for new images. Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Not a single 3.15 ARM kernel got built. :-(
And existing 3.14 is broken. openSUSE is ready for arm! =)
Guillaume, quick reminder in case you'll be quicker than me: We need to remember to re-enable previously disabled Exynos/Samsung driver options in default and lpae for 3.16.
Please, also disable omap4 video, it was discussed that it can work as module. -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (5)
-
Andreas Färber
-
Guillaume Gardet
-
Jean Delvare
-
Matwey V. Kornilov
-
matwey.kornilov@gmail.com