On Wed, Nov 12, 2008 at 08:05:50PM +0000, Andrew Wafaa wrote:

On Wed, 12 Nov 2008 10:20:34 -0800 Greg KH wrote:

...

On Wed, Nov 12, 2008 at 10:20:25AM +0000, Andrew Wafaa wrote:

...

Morning all,

Could someone confirm the correct method for building kernel modules for >=11.1 ?

I need to create KMPs for the ASUS eeePC netbooks, for ACPI and other hardware specifics.

You do? Can you let me know exactly what is missing in our 11.1 kernel for this kind of hardware so that I can see about adding it to the main tree (as well as the upstream kernel tree at the same time)?

thanks,

greg k-h

Hi Greg (and others),

I can't say exactly what is missing but all I know is I need the following packaged as KMPs since 10.3 and I have tried without in 11.1Beta4 and failed:

ACPI - The current package by Oliver Beng on the Build service https://build.opensuse.org/package/show?package=asus_acpi&project=home%3Aappleonkel%3AEEE

This should no longer be needed, as it already is in the opensuse 11.1 kernel package by default, as it is part of mainline already.

Events - The current package by Vincent Steenhoute on the Build Service https://build.opensuse.org/package/show?package=eeeEvents&project=home%3Aciv75%3AEEE

Not sure if the events one is kernel related.

Then why is it needed? Did you try this hardware without any additional kmps added? What did not work? thanks, greg k-h -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org

On Wed, Nov 12, 2008 at 10:40:57PM +0000, Andrew Wafaa wrote:

On Wed, 12 Nov 2008 12:14:54 -0800 Greg KH wrote:

...

...

I can't say exactly what is missing but all I know is I need the following packaged as KMPs since 10.3 and I have tried without in 11.1Beta4 and failed:

ACPI - The current package by Oliver Beng on the Build service https://build.opensuse.org/package/show?package=asus_acpi&project=home%3Aappleonkel%3AEEE

This should no longer be needed, as it already is in the opensuse 11.1 kernel package by default, as it is part of mainline already.

...

Events - The current package by Vincent Steenhoute on the Build Service https://build.opensuse.org/package/show?package=eeeEvents&project=home%3Aciv75%3AEEE

Not sure if the events one is kernel related.

Then why is it needed?

Did you try this hardware without any additional kmps added? What did not work?

thanks,

greg k-h

Aloha,

I did indeed try 11.1B4 on the hardware (eeePC701-4G). ACPI doesnt seem to be working, power management complains about it.

Please file a bug for this, we'll look into it.

As for the events, that is needed to be able to utilise the hardware buttons to access volume/brightness/other functions via the keyboard. It also enables the OnScreenDisplay notifications for the button presses.

So this is a kernel module? Or is it just a userspace program? thanks, greg k-h -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org

On Thu, Nov 13, 2008 at 12:42:07AM +0100, Ruediger Oertel wrote:

On Wednesday 12 November 2008 23:40:57 Andrew Wafaa wrote:

...

On Wed, 12 Nov 2008 12:14:54 -0800 Greg KH wrote:

...

...

I can't say exactly what is missing but all I know is I need the following packaged as KMPs since 10.3 and I have tried without in 11.1Beta4 and failed:

ACPI - The current package by Oliver Beng on the Build service

https://build.opensuse.org/package/show?package=asus_acpi&project=home%3Aappleonkel%3AEEE

This should no longer be needed, as it already is in the opensuse 11.1 kernel package by default, as it is part of mainline already.

diff-ing that one against the in-kernel asus_acpi shows that it does not share much with the original module except for the name and basic infrastructure. 1459 asus_acpi.c (from kernel) 1907 asus_acpi.c (hacked up for eeecp) diff: 675 lines ...

So maybe it actually works properly? :) Context is needed as to what is missing in the in-kernel driver to require an external one. thanks, greg k-h -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org

On Thu, Nov 13, 2008 at 02:45:52AM +0100, Ruediger Oertel wrote:

...

...

https://build.opensuse.org/package/show?package=asus_acpi&project=home%3Aappleonkel%3AEEE

...

...

...

much with the original module except for the name and basic infrastructure. 1459 asus_acpi.c (from kernel) 1907 asus_acpi.c (hacked up for eeecp) diff: 675 lines ...

So maybe it actually works properly? :)

Context is needed as to what is missing in the in-kernel driver to require an external one.

On Thursday 13 November 2008 00:46:06 Greg KH wrote: [edited] the patched driver removes the support for the device the original driver was written for and adds the support for the eeepc, for example:

+#define EEEPC_HOTK_HID "ASUS010" [...] +static const struct acpi_device_id eee_device_ids[] = { + {EEEPC_HOTK_HID, 0}, + {"", 0} +}; [...] -static const struct acpi_device_id asus_device_ids[] = { - {"ATK0100", 0}, - {"", 0}, -}; [...] static struct acpi_driver asus_hotk_driver = { .name = "asus_acpi", .class = ACPI_HOTK_CLASS, - .ids = asus_device_ids, + .ids = eee_device_ids, .ops = {

That's "foolish" at the least, we should just add the new device id to the exising driver to have it work with both types of devices. That's why it is a table of ids... Can someone please file a bug and put this info in it so we can take care of it? thanks, greg k-h -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org

On Wednesday, 12 November 2008 19:24:51 Bernhard Walle wrote:

* Andrew Wafaa [2008-11-12 10:20]:

...

Morning all,

Could someone confirm the correct method for building kernel modules for >=11.1 ?

I think http://www.suse.de/~agruen/KMPM/KernelModulePackagesManual-CODE10.pdf is still valid.

Mostly, if taken with a large enough grain of salt. It need an update urgently. Andreas -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org