[opensuse-kernel] CONFIG_HID_BATTERY_STRENGTH on x86
Hi guys, Our x86 kernel settings would let us enable CONFIG_HID_BATTERY_STRENGTH. This feature sounds rather cool to me, even though I don't think I have any device implementing it, but I suspect other openSUSE users may do. Looking through git history, I see that it was briefly enabled in x86 config files, between openSUSE 12.2 M2 (commit d017ea13f) and Beta1 (commit 37113a827.) No explanation was logged as to why it got enabled and then disabled. This feature is enabled in most armv6hl and armv7hl config files, since openSUSE 13.1. Don't we want that feature enabled in i386 and x86_64 config files as well? And maybe even arm64 and ppc*? I mean, wireless keyboards can be used on any system, can't they? Thanks, -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 3/24/14, 4:50 PM, Jean Delvare wrote:
Hi guys,
Our x86 kernel settings would let us enable CONFIG_HID_BATTERY_STRENGTH. This feature sounds rather cool to me, even though I don't think I have any device implementing it, but I suspect other openSUSE users may do.
Looking through git history, I see that it was briefly enabled in x86 config files, between openSUSE 12.2 M2 (commit d017ea13f) and Beta1 (commit 37113a827.) No explanation was logged as to why it got enabled and then disabled.
Typically when an option gets disabled like that, it's because a dependency was introduced in the update that wasn't met by the rest of the config. When the dependency is removed again, there's no automatic detection that would have re-enabled that option.
This feature is enabled in most armv6hl and armv7hl config files, since openSUSE 13.1.
Don't we want that feature enabled in i386 and x86_64 config files as well? And maybe even arm64 and ppc*? I mean, wireless keyboards can be used on any system, can't they?
I don't have any objection. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.19 (Darwin) iQIcBAEBAgAGBQJTMJuHAAoJEB57S2MheeWyArUP/1q50LXsOywbb+AQrc7W6nM8 kajlDiEnzRN7fg7pUvEasChcLAupKOq70l0ejnq43cLLU7N8bKvDpZgZgtbS1zeu TaLAhwVe0XpUY8Pu/n4y3q6Vr672Drmpa0nMWn6yfNt53gYTS161XDqzhTQbsXmc Kw2crXdlB8gHEft6KakuwTQDyUfuUWKOnzqe1kfDVDTkkz7dq8Mgu/A6KwtI2qqL AhaiQHgNOk4fRHQpEkqJztcBDgeSju4sRcmOEXQZ+mkoKQW95/gioBEhy+g/x2v1 YquX4tnuk793F8oGMvFKePLP6B0unKpAvG3ZswAnhdkXmdfu19xd5cO8YTQqRx0q jLPKwwER2h7Fx5vg/Z2lrrrMdPduW1N14Uz+thwhQhYkwoRJmWYzMIBL0lR9QCuO KJxIj7xeBh3cgg1+C73DyP1ej5e6i0VqhAyu8SuZtSJsK7EljN3RvayJmbXQPikO 6GnCwlidxshIDpdMZmKAwWAAhLsooiuaHImp+txWdSjwRzrqs87JJfsDNU8fwU/1 haFJuIARjfSS/dFr1YsLFO+hurOGyxIvoRVInybdjB1grjCh6hX+jVPoiP54Zouc cAm/jTAFIOyDXUx1ETlRQn0ZLn7Rs+ByuBy6SP60UefjV3bH15uLX9ZSjPlGSgQM SgmFtgC72Xf6IgCml43u =c02N -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Mon, 24 Mar 2014, Jean Delvare wrote:
Don't we want that feature enabled in i386 and x86_64 config files as well? And maybe even arm64 and ppc*? I mean, wireless keyboards can be used on any system, can't they?
I am fine with this. Thanks Jean. -- Jiri Kosina SUSE Labs -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi Jiri, Le Friday 28 March 2014 à 14:23 -0700, Jiri Kosina a écrit :
On Mon, 24 Mar 2014, Jean Delvare wrote:
Don't we want that feature enabled in i386 and x86_64 config files as well? And maybe even arm64 and ppc*? I mean, wireless keyboards can be used on any system, can't they?
I am fine with this. Thanks Jean.
You're welcome. I've only enabled it in i386 and x86_64 kernels for now, as I don't know exactly which devices implement the feature so I am not sure how likely it is that such devices would be plugged on arm64, ppc or ppc64 systems. This can be revisited if actual use cases pop up. Or right now if you prefer to have the same setting across all kernels. -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
On Sat, 29 Mar 2014, Jean Delvare wrote:
On Mon, 24 Mar 2014, Jean Delvare wrote:
Don't we want that feature enabled in i386 and x86_64 config files as well? And maybe even arm64 and ppc*? I mean, wireless keyboards can be used on any system, can't they?
I am fine with this. Thanks Jean.
You're welcome. I've only enabled it in i386 and x86_64 kernels for now, as I don't know exactly which devices implement the feature so I am not sure how likely it is that such devices would be plugged on arm64, ppc or ppc64 systems.
In principle currently any system that has USB or Bluetooth support should be considered. I don't think this makes sense for I2C-connected peripherals. -- Jiri Kosina SUSE Labs -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Hi Jiri, Le Sunday 30 March 2014 à 04:36 -0700, Jiri Kosina a écrit :
On Sat, 29 Mar 2014, Jean Delvare wrote:
On Mon, 24 Mar 2014, Jean Delvare wrote:
Don't we want that feature enabled in i386 and x86_64 config files as well? And maybe even arm64 and ppc*? I mean, wireless keyboards can be used on any system, can't they?
I am fine with this. Thanks Jean.
You're welcome. I've only enabled it in i386 and x86_64 kernels for now, as I don't know exactly which devices implement the feature so I am not sure how likely it is that such devices would be plugged on arm64, ppc or ppc64 systems.
In principle currently any system that has USB or Bluetooth support should be considered.
That would be all our kernel flavors except */ec2 and s390x/*. So I will enable CONFIG_HID_BATTERY_STRENGTH in all our ppc*/* config files as well, and in armv7hl/exynos too, unless anyone objects. Should I also enable this in our openSUSE 13.1 kernels, so that users can make use of the feature faster? Or does anyone see any risk in doing so? Thanks, -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Am 31.03.2014 09:27, schrieb Jean Delvare:
Should I also enable this in our openSUSE 13.1 kernels, so that users can make use of the feature faster? Or does anyone see any risk in doing so?
No, userspace might be confused and we need to sort this out first. (Emergency shutdown on empty mouse battery... :-) -- Stefan Seyfried "For a successful technology, reality must take precedence over public relations, for nature cannot be fooled." -- Richard Feynman -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
Le Monday 31 March 2014 à 15:47 +0200, Stefan Seyfried a écrit :
Am 31.03.2014 09:27, schrieb Jean Delvare:
Should I also enable this in our openSUSE 13.1 kernels, so that users can make use of the feature faster? Or does anyone see any risk in doing so?
No, userspace might be confused and we need to sort this out first.
(Emergency shutdown on empty mouse battery... :-)
OK, fair enough :-D -- Jean Delvare SUSE L3 Support -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org
participants (4)
-
Jean Delvare -
Jeff Mahoney -
Jiri Kosina -
Stefan Seyfried