[opensuse-kernel] what's up with BuildRequires: kernel-dummy
Hi, what's up with kernel rpm specs containing: %if ! 0%{?opensuse_bs} BuildRequires: kernel-dummy %endif When I build my kernels based on your specs, I just kill those lines. Anybody care to explain, what's their business? While at it, what about :25,309s/2.6.25.3/%version/g in kernel-source.spec and a similar change in the others as well. Sure, other lines need adjusting on the release change as well, but that way, revision changes don't need adjusting all over.. Pete -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hans-Peter Jansen wrote:
Hi,
what's up with kernel rpm specs containing:
%if ! 0%{?opensuse_bs} BuildRequires: kernel-dummy %endif
When I build my kernels based on your specs, I just kill those lines.
Anybody care to explain, what's their business?
While at it, what about
:25,309s/2.6.25.3/%version/g
in kernel-source.spec and a similar change in the others as well.
Sure, other lines need adjusting on the release change as well, but that way, revision changes don't need adjusting all over..
kernel-dummy is used to synchronize release numbers across all the kernel flavors. It's not needed for local building, but it ensures that kernel-$flavor-$version-$release is always the same for all flavors when we build all of them. The kernel RPM spec files are generated by scripts, so things like 2.6.25.3 are auto-inserted. You can see the scripts in the kernel-source.src.rpm - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkgrGs4ACgkQLPWxlyuTD7ILSQCfXmcBTgfxFQKokZa0jubIEn/0 MswAnibsOQH/xMycABNayfLqHhSn2f00 =bapn -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
Am Mittwoch, 14. Mai 2008 schrieb Jeff Mahoney:
Hans-Peter Jansen wrote:
Hi,
what's up with kernel rpm specs containing:
%if ! 0%{?opensuse_bs} BuildRequires: kernel-dummy %endif
When I build my kernels based on your specs, I just kill those lines.
Anybody care to explain, what's their business?
While at it, what about
:25,309s/2.6.25.3/%version/g
in kernel-source.spec and a similar change in the others as well.
Sure, other lines need adjusting on the release change as well, but that way, revision changes don't need adjusting all over..
kernel-dummy is used to synchronize release numbers across all the kernel flavors. It's not needed for local building, but it ensures that kernel-$flavor-$version-$release is always the same for all flavors when we build all of them.
Shouldn't this logic should be turned inside out, like: %if 0%{?opensuse_internal_build} BuildRequires: kernel-dummy %endif and get this tag defined locally, instead of constraining external users of your kernel builds?
The kernel RPM spec files are generated by scripts, so things like 2.6.25.3 are auto-inserted. You can see the scripts in the kernel-source.src.rpm
Okay, given, I would carefully patch it up, would you be willing to apply it? Pete -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hans-Peter Jansen wrote:
Am Mittwoch, 14. Mai 2008 schrieb Jeff Mahoney:
Hans-Peter Jansen wrote:
Hi,
what's up with kernel rpm specs containing:
%if ! 0%{?opensuse_bs} BuildRequires: kernel-dummy %endif
When I build my kernels based on your specs, I just kill those lines.
Anybody care to explain, what's their business?
While at it, what about
:25,309s/2.6.25.3/%version/g
in kernel-source.spec and a similar change in the others as well.
Sure, other lines need adjusting on the release change as well, but that way, revision changes don't need adjusting all over.. kernel-dummy is used to synchronize release numbers across all the kernel flavors. It's not needed for local building, but it ensures that kernel-$flavor-$version-$release is always the same for all flavors when we build all of them.
Shouldn't this logic should be turned inside out, like: %if 0%{?opensuse_internal_build} BuildRequires: kernel-dummy %endif
and get this tag defined locally, instead of constraining external users of your kernel builds?
No, because it's not an on/off switch for us. We disable it for the opensuse build service, but I'm not sure if we have any such macro for our internal build system. Eventually, everything will use the build service - but for now it only supports i386 and x86_64, so we still need our autobuild system.
The kernel RPM spec files are generated by scripts, so things like 2.6.25.3 are auto-inserted. You can see the scripts in the kernel-source.src.rpm
Okay, given, I would carefully patch it up, would you be willing to apply it?
That depends on the patch.. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkgryc4ACgkQLPWxlyuTD7KbPwCbBqMcsqU1Fnx+6l2VE6uiikmq OFgAoJqjdu30yE+1kcSN6R5EcNxpWARV =WJmV -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org
participants (2)
-
Hans-Peter Jansen -
Jeff Mahoney