On 06/06/2013 10:57 AM, Jean Delvare wrote:
Hi Cristian,
Le Wednesday 05 June 2013 à 13:51 -0400, Cristian Rodríguez a écrit :
El 05/06/13 12:29, Jean Delvare escribió:
Hi all,
Having worked on built-in drivers which could be modularized, I am now looking for modular drivers which could be built-in. Our policy is that drivers which are not hardware-specific and are needed on a majority of systems should be built into the kernel directly.
You are missing autofs4 and af_packet , autofs4 is loaded unconditionally by systemd (required by .automount units) and af_packet is requested any time a dhcp client fires up.
Well, I admit that one of my machines is running SLED11 SP3, one is running openSUSE 12.2 and only two are running openSUSE 12.3. But testing only two machines would have resulted in too many false positives and I thought missing some modules would be better than listing too many. I already have more than enough to play with ;)
If I remove the SLED11 SP3 machine, two generic modules are indeed added to the list: * ata_generic * autofs4
No af_packet here, as the 3 systems use static IP addressing.
I don't think autofs4 should be loaded on all systems, but that's a systemd issue. Building it into the kernel is thus not the solution.
Not sure about ata_generic. On the one hand, it is included in the initrd and thus loaded on all my machines. But OTOH it is not bound to any device on these systems. So the right solution might be teach mkinitrd to only embed ata_generic when it is really needed, rather than building it into the kernel. Michal? OTOH, if driver auto-loading ends up kicking in anyway due to modalias, and there is no easy way to avoid that, then having it built-in would be just as good. Unless driver loading order matters so that specific drivers are used first. I see that ata_piix is always loaded first on my 3 machines, this might be on purpose. I'll do some tests.
Argl. Please don't. ata_generic is the absolute fallback if for some reason the system doesn't ship with ATA drivers for that particular HBA. Which _really_ shouldn't happen anymore. Please do _not_ have this module built-in.
About why the sg module is loaded, it is loaded by systemd/udev apparently a bug report was opened for that (bnc#761109 according to the logs)
Thanks for the pointer. The possibility to build sg into the kernel is mentioned in that bug as a recommendation from upstream udev developers. It's certainly worth trying, but then I don't know how the udev rule will behave (not sure if TEST=="[module/sg]" works when sg is built-in.)
The general idea here is to move over to 'bsg' for devices as far as udev is concerned. But that's a long-term goal, not sure whether we'll be able to pull that off in time for SLES12. In general I'm _quite_ unhappy with having the SCSI subsystem built in. It might be okay for openSUSE, but for SLE it will become a maintenance nightmare. Try adding a PDLP driver for a built-in module ... Is there a general consensus to move to built-in drivers for SLE 12? Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-kernel+owner@opensuse.org