> On 14.06.12 at 15:37, Jeff Mahoney
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 06/14/2012 04:53 AM, Olaf Hering wrote:
On Tue, Jun 12, Jan Beulich wrote:
> While I questioned whether doing this (for a slim boot time
> benefit this might provide) is really the right thing already
> in the past, bug 766284 points out another reason why this is
> a bad idea. Can this be reverted (in master and 12.2 at
The change below for ata_piix (and other related changes in
April 2009) was made without a bugzilla or fate reference.
Whats the practical benefit of having the drivers built into
the kernel? At least ata_piix should be a module because it
also drives emulated hardware (not only in a Xen HVM guest).
The changes came out of the faster booting effort at Intel for
Meego (or Moblin, or whatever it was called then), since the
initialization can happen in parallel rather than waiting on each
module to load in the initrd as happens with a mostly-modular
kernel. Greg KH added the changes and presented numbers as to why
it was faster at the time.
The fact that ata_piix is also used by emulated hardware is not
a reason to make it modular. It's a reason to fix the drivers to
work together, or to pull the functionality into the original
If the intended driver is modular, then that driver has no way to
tell a built-in one to not control certain devices. So the only
option then is to use Olaf's patch (which isn't really desirable
From my perspective, if there are two or more drivers for one piece
of hardware (ignore the fact that it's virtual/emulated here), they
_all_ should be modular, so that the rest of the system (e.g.
modprobe rules) can figure out the right one. The situation really
is no different than for other cases where a KMP override is