On Fri, May 16, 2008 at 03:08:40PM +0100, Jan Beulich wrote:
Apparently part of this crap managed to make it into the kernel already. I see the i2c stack reimplementation is there. Let me go shout at whoever let this happen.
This is what I just got in response to forwarding your comments to the Solarflare folks:
* I just thought I'd mention that I chatted to some of the developers here * and we do plan to change our in-tree Linux driver to use the * Linux-provided i2c code, and this will come in a subsequent patch. * Andrew Morton was happy for our current driver to be included (in the * interests of getting support in early) on the understanding that this * change is made subsequently. Hopefully the same rationale could be used * at Novell.
I have no objection to taking what is upstream right now, but I do object to taking the portion that is not upstream. So if you wish to redo your patch to be representative of the code that is currently in the 2.6.26-rc2 kernel, I'd be glad to re-review it. thanks, greg k-h -- To unsubscribe, e-mail: opensuse-kernel+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-kernel+help@opensuse.org