http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c2 --- Comment #2 from Antony J.R --- (In reply to Takashi Iwai from comment #1)

Care to report to the upstream, e.g. gitlab.freedsktop.org Issues? That's the official place for reporting. I'll keep this bug opened in case we can do some backports based on the upstream devs.

I thought this is a bug with the amdgpu and radeon drivers in the linux kernel, is it not the case?? So it is a X.Org thing? I'm a bit confused here. But I will try to talk with freedesktop folks. -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c4 --- Comment #4 from Takashi Iwai --- (In reply to Antony J.R from comment #2)

(In reply to Takashi Iwai from comment #1)

...

Care to report to the upstream, e.g. gitlab.freedsktop.org Issues? That's the official place for reporting. I'll keep this bug opened in case we can do some backports based on the upstream devs.

I thought this is a bug with the amdgpu and radeon drivers in the linux kernel, is it not the case?? So it is a X.Org thing?

gitlab.freedesktop.org also the place where the kernel graphics guys use as the primary development place in general. Use DRI/AMDGPU or such component there. -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c6 --- Comment #6 from Antony J.R --- (In reply to Takashi Iwai from comment #5)

Actually, which backlight drivers are being used there? Is it only ACPI or native driver?

And do I understand correctly that, if you switch to Nvidia driver (both mod setting and rendering), the backlight control works via /sys/class/backlight, while the same doesn't work if switching to AMDGPU?

To be exact, hybrid graphics brightness control does not work. Yes using only the discrete graphics card with nvidia non-free software enables me to control the backlight. But when switched to hybrid graphics(switchable graphics) the iGPU brightness control will not work. -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c8 --- Comment #8 from Takashi Iwai --- OK, then this sounds like a bug in amdgpu, indeed. If so, gitlab.freedesktop.org is the right place to report. Please go ahead :) -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 Takashi Iwai changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.freedesktop. | |org/drm/amd/-/issues/1438 -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c11 --- Comment #11 from Antony J.R --- Kernel bug https://bugzilla.kernel.org/show_bug.cgi?id=203905 -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c13 Takashi Iwai changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(antonyjr000@gmail | |.com) --- Comment #13 from Takashi Iwai --- I'm building an amdgpu KMP with a debug print patch, targeted for Tumbleweed kernel. Could you try the amdgpu-dbg-kmp-default from OBS home:tiwai:bsc1180749 repo, and give the dmesg output? -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c15 --- Comment #15 from Takashi Iwai --- Hm there is no added debug message. Could you rebuild initrd (e.g. run mkinitrd) and retest? -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c17 --- Comment #17 from Antony J.R --- (In reply to Takashi Iwai from comment #15)

Hm there is no added debug message. Could you rebuild initrd (e.g. run mkinitrd) and retest?

mkinitrd did the trick but now sddm does not start automatically for some reason so I have to do startx from tty but I can rollback. The updated log is in the same location -> https://github.com/antony-jr/lenovo-legion5-15arh05-scripts/blob/main/AMDGPU... For more debug info I tried to decrease the brightness to 0% and go to 100% again, hope that helps. -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c19 --- Comment #19 from Antony J.R --- (In reply to Takashi Iwai from comment #18)

Thanks. It shows that aux is used for the backlight control, and the values set there look OK through a quick glance. While you tested the brightness, it didn't change actually, right?

Could you try to read the current brightness, and check the kernel log, too?

Sorry for the late reply, the updated log is here => https://github.com/antony-jr/lenovo-legion5-15arh05-scripts/blob/main/AMDGPU... I changed the brightness and did cat /sys/class/backlight/amdgpu_bl1/brightness and /sys/class/backlight/amdgpu_bl1/actual_brightness Here the brightness changed when changed the brightness but actual_brightness is stuck at 311 constantly. The kernel log also shows that the get brightness routine output is stuck at invalid values. -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c21 --- Comment #21 from Antony J.R --- (In reply to Takashi Iwai from comment #20)

Thanks. Then I misunderstood situation as if the backlight control didn't take any effect.

I mean the backlight is constantly at maximum brightness and I can't decrease or control it. The only thing works is the brightness slider in OpenSUSE and the brightness value is only reflected in /sys/class/backlight/amdgpu_bl0/brightness file but the backlight does not change at all. I think I misled you saying "Here the brightness changed when changed the brightness but actual_brightness is stuck at 311 constantly.", Here I said /sys/class/backlight/amdgpu_bl0/brightness changes when I change the brightness slider in the OS (or Fn Keys) but the backlight still remains at maximum brightness.

Now I refreshed the OBS KMP repo to contain the possible fix. It's being rebuilt, and please give it a try later. The rpm changelog should contain the entry like: - Add a proper fix (attempt): 0001-drm-amd-display-Fix-the-brightness-read-via-aux.patch

At first, uninstall the previous KMP, just do "zypper rm amdgpu-dbg-kmp-default" Then re-install the new rpm, run mkinitrd and retest. This doesn't contain the debug prints, so report back whether it works or not.

I will report back ASAP. -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c23 --- Comment #23 from Takashi Iwai --- It's because of a mistake in the previous packaging. Now fixed and it's built, but the publishing seems taking long. You can fetch the fresh package directly via osc command before publishing, too: osc getbinaries home:tiwai:bsc1180749/amdgpu-dbg/standard/x86_64 -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c25 --- Comment #25 from Takashi Iwai --- OK, then you're hitting multiple issues, as it seems. The inconsistent value read from sysfs was addressed by my patch. But, I suppose that the main reason of the non-functional backlight is that the driver misdetected the backlight control over aux. I refreshed again the KMP with a hack patch to disable the aux support. Please give it a try later again. This will show a line "XXX ext_caps=0x..." in kernel log. -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c27 --- Comment #27 from Takashi Iwai --- OK, finally got some good news. I'm rebuilding the KMP again with a patch to add a module option "aux_backlight" instead of blindly disabling the aux backlight. So keep your working KMP for now, and check later the new KMP and test with amdgpu.aux_backlight=0 boot option. This is no solution but an acceptable workaround, I suppose. I'm going to submit two patches to upstream. Oh, BTW, which value was shown in the "XXX ext_caps=..." line? -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c29 --- Comment #29 from Takashi Iwai --- Created attachment 845786 --> http://bugzilla.opensuse.org/attachment.cgi?id=845786&action=edit Patch to add aux_backlight module option to amdgpu driver -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c32 --- Comment #32 from Antony J.R --- (In reply to Takashi Iwai from comment #31)

Alex submitted the patches including my module parameter patch to the upstream amd-gfx ML, and now I updated amdgpu-dbg KMP based on those patches. (And the debug print was dropped.)

Could you check it later together with the latest (matching) TW kernel? Once after confirming it works for you, I'll merge those patches to TW kernel.

Even after merging TW, though, we'll still need to keep the upstream bug opened until more workarounds are implemented (e.g. DMI-based quirk entries).

Many thanks. With the kernel param amdgpu.backlight=0 the backlight brightness control works with the latest TW kernel and your package at the time of writing. I wonder if we can get connected with any Lenovo or ASUS folks to find out what they did wrong? But I guess that's not gonna happen. Do they contribute anything open source in the first place?? Only time will tell :) -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c41 P changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensuse@pohw.nl --- Comment #41 from P --- Seizing the opportunity: Is there a way to see if this fix is going to be part of the KOTD? I'm in the same boat as OP, and I love to make use of the fix :-) As I'm on Leap 15.2 I could also raise a separate bug against Leap 15.2 if you guys would prefer this (maybe for tracking purposes). -- You are receiving this mail because: You are the assignee for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=1180749 http://bugzilla.opensuse.org/show_bug.cgi?id=1180749#c45 --- Comment #45 from Antony J.R --- (In reply to Takashi Iwai from comment #42)

The amdgpu.backlight module option was already merged in the upstream, so TW should have a workaround (passing amdgpu.backlight=0 boot option). This was also already merged in SLE15-SP3 / Leap 15.3 kernel, too. But I don't think we'd fix this for Leap 15.2.

The root cause of the problem hasn't been figured out yet. My bet is that it's a BIOS bug, and more proper workarounds are needed in AMDGPU driver side, but this has to be sorted out in the upstream development. Feel free to join to the upstream gitlab Issues.

It seems that without the amdgpu.backlight=0 kernel parameter the brightness control is working in hybrid mode. I don't know what fixed it maybe this https://gitlab.freedesktop.org/agd5f/linux/-/commit/f2ad3accefc63e72e9932e14... commit. But the brightness control seems to work good now in Linux 5.14.14 in TW. -- You are receiving this mail because: You are the assignee for the bug.