On Wed, 2023-04-26 at 16:45 +0200, Peter Czanik wrote:

Hi,

Where are the post build checks coming from? There are some problems which are coming up only in SLES 12 post build checks of syslog-ng:

https://build.opensuse.org/package/live_build_log/home:czanik:syslog-ng-gith...

I do weekly builds on openSUSE / SLES, and it's only then when these problems are found. My colleagues wonder, if they could run the same check in the syslog-ng CI. So, problems could be found before a PR is merged.

They live in the package 'post-build-checks' and looking at your build logs, I'd say they found some valid issues: [ 144s] E: syslog-ng 64bit-portability-issue modules/examples/inner-destinations/tls-test-validation/tls-test-validation.c:45 identified in the log from: [ 99s] modules/examples/inner-destinations/tls-test-validation/tls-test-validation.c:45:3: warning: implicit declaration of function 'X509_STORE_CTX_get0_cert' [-Wimplicit-function-declaration] [ 99s] X509 *cert = X509_STORE_CTX_get0_cert(data->ctx); [ 99s] ^ [ 99s] modules/examples/inner-destinations/tls-test-validation/tls-test-validation.c:45:16: warning: initialization makes pointer from integer without a cast [enabled by default] [ 99s] X509 *cert = X509_STORE_CTX_get0_cert(data->ctx); somewhat calls for a missing #include [ 144s] E: syslog-ng implicit-fortify-decl lib/multi-line/smart-multi-line.c:112, 144 raised from the warning in the buildlog: [ 89s] lib/multi-line/smart-multi-line.c:112:3: warning: implicit declaration of function 'strlen' [-Wimplicit-function-declaration] [ 89s] gint len = strlen(regexp); [ 89s] lib/multi-line/smart-multi-line.c:144:18: warning: incompatible implicit declaration of built-in function 'strlen' [enabled by default] [ 89s] gint len = strlen(line); => missing includes Hth, Dominique

Citeren Peter Czanik :

I do weekly builds on openSUSE / SLES, and it's only then when these problems are found. My colleagues wonder, if they could run the same check in the syslog-ng CI. So, problems could be found before a PR is merged.

Depending on how much effort you want to spend, adding -Werror-implicit-function-declaration or -Werror to the CFLAGS should do the trick.