Dear openSUSE Team,
on behalf of Wolfgang Rosenauer I commit the following information regarding the submit request of MozillaFirefox-kde4-addon from mozilla:Factory:
This package contains an addon which makes Firefox use Plasma's notification service for its messages. Author of the addon is Andreas Demmer mail@andreas-demmer.de.
So far no security issues are known, and those are highly unlikely, since everything the plugin does is calling kdialog. It is published under the GPLv3.
For questions please do not hesitate to concact me or Wolfgang.
Cheers, Johannes
Johannes Engel wrote:
Dear openSUSE Team,
on behalf of Wolfgang Rosenauer I commit the following information regarding the submit request of MozillaFirefox-kde4-addon from mozilla:Factory:
This package contains an addon which makes Firefox use Plasma's notification service for its messages. Author of the addon is Andreas Demmermail@andreas-demmer.de.
So far no security issues are known, and those are highly unlikely, since everything the plugin does is calling kdialog. It is published under the GPLv3.
Could the code be made available in a way that it 1) can be integrated code-wise into common Mozilla code, 2) is GPLv2/LGPLv2/MPL-tri-licensed, 3) can run-time switch to use it if kde4/plasma is used and else fall back to what Mozilla uses now?
I would love to see KDE integration like that in upstream Mozilla source and I'm willing to push for it in the Mozilla community if the code, legalisms and cooperation with the code authors allow this upstreaming.
Robert Kaiser
Hi Robert,
Am 24.07.2009 20:47, schrieb Robert Kaiser:
Johannes Engel wrote:
This package contains an addon which makes Firefox use Plasma's notification service for its messages. Author of the addon is Andreas Demmermail@andreas-demmer.de.
For some questions it would be easier to talk to Andreas Demmer since he's most likely not reading opensuse-factory. I'm interested to stay in the loop though.
http://www.andreas-demmer.de/projekte/software/
Some comments below.
Could the code be made available in a way that it
- can be integrated code-wise into common Mozilla code,
The implementation is probably too hackish for inclusion into mozilla code. It's actually starting a shell script from JS which calls the k helper tools.
- is GPLv2/LGPLv2/MPL-tri-licensed,
The author would have to answer that.
- can run-time switch to use it if kde4/plasma is used and else fall
back to what Mozilla uses now?
I would like to see that since it's currently not clear to me what happens exactly if that addon is installed but not used within KDE4. (I _fear_ we are losing notifications completely in that case which needs to be addressed in any case).
As sidenote from previous discussions about that topic: I think it would be pretty easy to add a KDE <-> Gnome detection in the mozilla code and keep some kind of desktop flag throughout the application. Someone proposed to have it in widget's nsToolkit class but I'm not sure if it would be easily accessible from JS in that case.
I would love to see KDE integration like that in upstream Mozilla source and I'm willing to push for it in the Mozilla community if the code, legalisms and cooperation with the code authors allow this upstreaming.
The initial step IMHO is to get a global flag into the core which can be easily accessed from C++ and JS contexts to recognize Gnome or KDE (at first stage). A very easy example which could be done along with it is to disable the "Set as desktop background" from the context menu if not running under Gnome since that is extremely confusing and can just be hidden if not running in Gnome. If you can come up with a good place for the global detection I would be willing to do some coding to create the basic support ;-)
Wolfgang
On Friday 24 of July 2009, Wolfgang Rosenauer wrote:
As sidenote from previous discussions about that topic: I think it would be pretty easy to add a KDE <-> Gnome detection in the mozilla code and keep some kind of desktop flag throughout the application. Someone proposed to have it in widget's nsToolkit class but I'm not sure if it would be easily accessible from JS in that case.
Just in case somebody starts doing this, see the part related to KDE_FULL_SESSION in /usr/bin/startkde.
I would love to see KDE integration like that in upstream Mozilla source and I'm willing to push for it in the Mozilla community if the code, legalisms and cooperation with the code authors allow this upstreaming.
The initial step IMHO is to get a global flag into the core which can be easily accessed from C++ and JS contexts to recognize Gnome or KDE (at first stage). A very easy example which could be done along with it is to disable the "Set as desktop background" from the context menu if not running under Gnome since that is extremely confusing and can just be hidden if not running in Gnome.
Gee, bad jokes about missing basic functionality now apply to both GNOME and KDE?
If you can come up with a good place for the global detection I would be willing to do some coding to create the basic support ;-)
FYI, it looks very likely that the default browser in KDE for 11.2 will be Firefox (http://en.opensuse.org/KDE/Meetings/20090723#Default_Web_Browser).
-
Johannes Engel -
Lubos Lunak -
Robert Kaiser -
Wolfgang Rosenauer