[opensuse-factory] Re: are we able to add make check for phantomjs package ?

Hi, As suggested , I added 'make check' in the spec file and then tried to build it, but still unable to execute test cases. I am looping in Atul Sowani , one of my team mate, to weigh in on OBS if required, as he has already worked on porting the same. The log for make check is as below : make -f Makefile.phantomjs check [ 1684s] make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/phantomjs-2.1.1+git20160125.482b91d/src' [ 1684s] make[1]: Nothing to be done for 'check'. [ 1684s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/phantomjs-2.1.1+git20160125.482b91d/src' [ 1684s] + exit 0 Regards Zaid Golwala On 5 April 2016 at 20:45, Normand wrote:

I am changing the email subject from initial thread, to clearly state what is the need.

On 05/04/2016 15:42, Zaid Golwala wrote:

...

Hi Michel,

I was able to build phantomjs based on the link you provided me , but I am unable to verify from the build logs if phantomjs testcases were executed or not.

I do not know the details of this package but looking at spec file there is no %check section. May be you could try in your home by adding in spec: %check make check

There is may be good reason why this is not present yet in spec. You should probably discuss with package maintainers.

...

Also the tarball which is present in the link , can you confirm if that a customized tarball to exclude certain testcases or is as is from Git source.

as said before I assume the tarball in OBS is from tar_scm service so I do not expect it to be customized.

But if you need to exclude some testcases then why not to add patches ? to avoid those tests to be run.

...

Regards Zaid Golwala

On 4 April 2016 at 18:39, Normand wrote:

...

On 09/03/2016 15:00, Zaid Golwala wrote:

...

Hi,

I am looking to build phantom.js on OBS on Suse12.1 .

The code for phantom.js is structured in such a way that it requires to fetch the source code for QT test suite from GIT Hub repository while building the code.

Is there any way we can do that in a spec file or do we need to download all the code and in a tarball before starting the build.

Hello Zaid, What is missing for you in the phantomjs tarball present in OBS ? (1)

Did you noticed the _service file with tar_scm service and submodules enable flag, so that all git submodules of phantomjs are present in tarball BEFORE start of build.

(1) https://build.opensuse.org/package/show/devel:languages:nodejs/phantomjs

...

Regards Zaid Golwala

-- Michel Normand

-- To unsubscribe, e-mail: opensuse-factory+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-factory+owner@opensuse.org