On Friday 15 September 2006 10:00 am, Jigish Gohil wrote:

On 9/15/06, Dennis Sieben wrote:

...

Dear buildserver maintainers,

I finally started my first project in the buildservice. But only a src.rpm is build. It looks to me like all sections below %prep aren't used. Normally I would expect a line like "Executing(%prep)" after the setup of the build environment. But this doesn't happen. Maybe one can take a look at this. This happens in the package gstreamer-plugins-moodbar in home:d7. Maybe it's just a fault of me because I'm quite new to the buildservice.

Could it be because you are running rm before 'make'?

%install rm -rf "$RPM_BUILD_ROOT" make -i install DESTDIR=$RPM_BUILD_ROOT

No. That's normal. Cleaning the destdir before make install is desirable since there could be unwanted files left over from previous failed builds. -- James Oakley jfunk@funktronics.ca --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

On Friday 15 September 2006 12:15 pm, Marcus Rueckert wrote:

On 2006-09-15 11:25:27 -0300, James Oakley wrote:

...

...

Could it be because you are running rm before 'make'?

%install rm -rf "$RPM_BUILD_ROOT" make -i install DESTDIR=$RPM_BUILD_ROOT

No. That's normal. Cleaning the destdir before make install is desirable since there could be unwanted files left over from previous failed builds.

you dont need that anymore. since ages already.

%install %makeinstall

He was referring to the the rm command. %install doesn't clean the buildroot, at least not on 10.2-alpha4: jfunk@maus:~> rpm --eval '%makeinstall' make DESTDIR= install Sure, with the build service it's not so important anymore, but many people still do local builds, myself included. -- James Oakley jfunk@funktronics.ca --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

On 2006-09-18 13:27:48 +0200, Marcus Rueckert wrote:

On 2006-09-15 15:09:55 -0300, James Oakley wrote:

...

...

%install %makeinstall

He was referring to the the rm command.

%install doesn't clean the buildroot, at least not on 10.2-alpha4:

afaik y2pmbuild/build do. and imho thats the better way to build anyway. less side effects.

The BuildRoot is deleted and created by rpmbuild _before_ anything in the %build and %install section will be executed: Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.63507 + umask 022 + cd /home/marcus/packages/BUILD + /bin/rm -rf /var/tmp/libast-0.7-build ++ dirname /var/tmp/libast-0.7-build + /bin/mkdir -p /var/tmp + /bin/mkdir /var/tmp/libast-0.7-build So the buildroot is "clean"

...

jfunk@maus:~> rpm --eval '%makeinstall' make DESTDIR= install

normally buildroot build be set here though.

The output is correct because the %{buildroot} variable isn't set. Marcus --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

On Friday 15 September 2006 15:11, Michael Schroeder wrote:

On Fri, Sep 15, 2006 at 02:57:43PM +0200, Dennis Sieben wrote:

...

Dear buildserver maintainers,

I finally started my first project in the buildservice. But only a src.rpm is build. It looks to me like all sections below %prep aren't used. Normally I would expect a line like "Executing(%prep)" after the setup of the build environment. But this doesn't happen. Maybe one can take a look at this. This happens in the package gstreamer-plugins-moodbar in home:d7. Maybe it's just a fault of me because I'm quite new to the buildservice.

Your specfile contains an error:

%define gstlibdir %{_libdir]/gstreamer-%{gst_major_ver} ^^^^^^^^^^

this should be '}' instead if ']'...

Yes that was it. Thanks. Is there any chance that these syntax errors can be detected inside the buildservice? If the buildservice could give an error message like syntax error in spec file it would be fine. Just building the src.rpm leaves open too many possible reasons. Regards, Dennis Sieben