[opensuse-buildservice] [RFC/patch] obs/webclient: make table out of waiting/blocked/average statistics
Hi !
Please review this patch for the webclient - if there're no objections I'd like to commit it to svn.
The patch creates a table out of the statistics on the bottom of the monitor page.
Old: http://img5.imageshack.us/img5/7285/monitorold.png New: http://img528.imageshack.us/img528/5344/monitornew.png
Best, Jan-Simon
Am Freitag, 29. Mai 2009 16:45:11 schrieb Jan-Simon Möller:
Hi !
Please review this patch for the webclient - if there're no objections I'd like to commit it to svn.
The patch creates a table out of the statistics on the bottom of the monitor page.
Is the arch.nil? check really needed ?
Otherwise it looks really like an improvement :)
bye adrian
Am Friday 29 May 2009 16:54:03 schrieb Adrian Schröter:
Am Freitag, 29. Mai 2009 16:45:11 schrieb Jan-Simon Möller:
Hi !
Please review this patch for the webclient - if there're no objections I'd like to commit it to svn.
The patch creates a table out of the statistics on the bottom of the monitor page.
Is the arch.nil? check really needed ?
Yes - look at build.o.o: Average has only x86_64 listed atm so we'd get a backtrace on e.g. arch = armv5el as the next line tries nil.has_attribute? .
Best, Jan-Simon
buildservice@lists.opensuse.org
-
Adrian Schröter -
Jan-Simon Möller