On Fri, Nov 17, 2006 at 08:41:32PM +0530, Jigish Gohil wrote:

We are using the following in our repository, you can check those specs out.

%if "%_repository" == "SUSE_Linux_10.1" || "%_repository" == "SLE_10" BuildRequires: xorg-x11-compat70-devel %endif %if "%_repository" != "SUSE_Linux_10.0" BuildRequires: libdrm-devel %endif

This makes it hard for people that import your package and use different repository names. I think it's better to use %if 0%{?suse_version} >= 1010 BuildRequires: xorg-x11-compat70-devel %endif %if 0%{?suse_version} != 1000 BuildRequires: libdrm-devel %endif Cheers, Michael. -- Michael Schroeder mls@suse.de main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

On Nov 17, 06 20:50:02 +0530, Jigish Gohil wrote:

On 11/17/06, Michael Schroeder wrote:

...

This makes it hard for people that import your package and use different repository names. I think it's better to use

%if 0%{?suse_version} >= 1010 BuildRequires: xorg-x11-compat70-devel %endif %if 0%{?suse_version} != 1000 BuildRequires: libdrm-devel %endif

Yeah that was a special case, as XOrg7_SUSE_Linux_10.1 doesn't require xorg-x11-compat70-devel too and caused a clash in BS.

Also, it would have to be %if 0%{?suse_version} <= 1010 ...

The above way is proper.

Also remember that it's only about SUSE, so supporting other distributions adds additional work. Matthias -- Matthias Hopf __ __ __ Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@mshopf.de Phone +49-911-74053-715 __) |_| __) |__ labs www.mshopf.de --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org