[opensuse-buildservice] [PATCH] distinguish between local and worker builds
Hi, Here is a tiny patch that define a macro when packages are built inside OBS so that special packages built locally can be treated differently. Anas diff --git a/src/backend/bs_worker b/src/backend/bs_worker index 948dd0b..2bbc838 100755 --- a/src/backend/bs_worker +++ b/src/backend/bs_worker @@ -1431,6 +1431,7 @@ sub dobuild { push @args, '--oldpackages', $oldpkgdir if $oldpkgdir && -d $oldpkgdir; push @args, '--norootforbuild' unless $BSConfig::norootexceptions && grep {"$projid/$packid" =~ /^$_$/} keys %$BSConfig::norootexceptions; push @args, '--baselibs-internal'; + push @args, '--define', "running_in_obs 1"; push @args, '--lint'; push @args, '--dist', "$buildroot/.build.config"; push @args, '--rpmlist', "$buildroot/.build.rpmlist";-- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Tue, Sep 21, 2010 at 02:27:47PM +0100, Anas Nashif wrote:
Here is a tiny patch that define a macro when packages are built inside OBS so that special packages built locally can be treated differently.
What's the concrete use case? I.e., what special packages are you talking about? Thanks, Michael. -- Michael Schroeder mls@suse.de SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On 2010-09-21, at 2:42 PM, Michael Schroeder wrote:
On Tue, Sep 21, 2010 at 02:27:47PM +0100, Anas Nashif wrote:
Here is a tiny patch that define a macro when packages are built inside OBS so that special packages built locally can be treated differently.
What's the concrete use case? I.e., what special packages are you talking about?
In our case that would be the kernel. When built in OBS, the kernel is built from multiple spec files, so the kernel package would only build the source and links to the kernel package, i.e. kernel-netbook would build in parallel. when building the kernel package locally however, we want to make sure the developer builds all variants, i.e. if I submit a patch to variant A, we want to make sure all variants also build, even if the developer only cares about variant A. Anas
Thanks, Michael.
-- Michael Schroeder mls@suse.de SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
-- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Le mardi 21 septembre 2010 à 14:46 +0100, Anas Nashif a écrit :
On 2010-09-21, at 2:42 PM, Michael Schroeder wrote:
On Tue, Sep 21, 2010 at 02:27:47PM +0100, Anas Nashif wrote:
Here is a tiny patch that define a macro when packages are built inside OBS so that special packages built locally can be treated differently.
What's the concrete use case? I.e., what special packages are you talking about?
In our case that would be the kernel. When built in OBS, the kernel is built from multiple spec files, so the kernel package would only build the source and links to the kernel package, i.e. kernel-netbook would build in parallel. when building the kernel package locally however, we want to make sure the developer builds all variants, i.e. if I submit a patch to variant A, we want to make sure all variants also build, even if the developer only cares about variant A.
Why not just set this macro in your project configuration ? -- Frederic Crozat <fcrozat@novell.com> Novell -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
participants (3)
-
Anas Nashif -
Frederic Crozat -
Michael Schroeder