On 03.12.2013 21:34, Dimstar / Dominique Leuenberger wrote:

On Tue, 2013-12-03 at 21:24 +0100, Stephan Kulow wrote:

...

Hi,

I merged a project I started in August - native mail notifications in OBS. It needs further improvements, but just in case you deploy master and you suddenly get emails - don't be suprised :)

Thanks for the heads up!

...

For build.opensuse.org it will replace hermes mails in the mid term, but not before we have a UI to configure it and most likely event type by event type.

I'd appreciate an option similar to the one in Bugzilla: skip mail if *I* trigger the action (not to self)

BTW: what do people want to see in the From? A generic foobar or the name of the one creating the event? An alternative is to set the Reply-To. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

On 04.12.2013 12:16, Jan Engelhardt wrote:

On Wednesday 2013-12-04 11:56, Stephan Kulow wrote:

...

...

BTW: what do people want to see in the From? A generic foobar or the name of the one creating the event? An alternative is to set the Reply-To.

Perhaps it should work like the email interface plugin of Bugzilla, in that replies get recorded into the SR. Then we would not need to decline requests all the time to just make a comment.

You can make comments in the webui, no need to make things more complex by adding a mail interface to OBS IMO. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

On Wed, 2013-12-04 at 20:07 +0100, Stephan Kulow wrote:

Am 03.12.2013 21:34, schrieb Dimstar / Dominique Leuenberger:

...

A good initial candidate to be enabled are comments on requests, packages and projects... in the current form, they go completely unnoticed in most cases (and it also doesn't help that on the webui request page they are on the bottom)

As a start I implemented mails for comments in requests - I only email the creator though.

I wonder - who should get mail too?

- target maintainer - source maintainer - current reviewers - accepted reviewers - open reviews - people previously commenting - any other candidates?

Hmm. that sounds in any case like a place for disaster.. I myself would prefer 'too many' of those mails as opposed to missing some. Of the list above, I'd say 'accepted reviewers' is likely the least interested in it.. The others sound rather logical.. Dominique -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

Am 04.12.2013 20:29, schrieb Dimstar / Dominique Leuenberger:

...

I wonder - who should get mail too?

- target maintainer - source maintainer - current reviewers - accepted reviewers - open reviews - people previously commenting - any other candidates?

Hmm. that sounds in any case like a place for disaster.. I myself would prefer 'too many' of those mails as opposed to missing some.

Of the list above, I'd say 'accepted reviewers' is likely the least interested in it..

The others sound rather logical..

Well, if Sascha accepted a review and you look at it too and notice that Sascha overlooked something, wouldn't you want Sascha to know? :) Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

On 12/05/2013 09:24 AM, Stephan Kulow wrote:

On 03.12.2013 21:24, Stephan Kulow wrote:

...

The first step will be to send mails for review - which does not work I deployed that now and sent out some emails - before disabling it again.

So factory reviewers should have got some email - please review their content and let's find ways to improve them.

Can I reply to the review email with "approve" or comment on it? That would be cool ;) Content looks fine to me, thanks, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

On 12/05/2013 09:24 AM, Stephan Kulow wrote:

...

On 03.12.2013 21:24, Stephan Kulow wrote:

...

The first step will be to send mails for review - which does not work I deployed that now and sent out some emails - before disabling it again.

So factory reviewers should have got some email - please review their content and let's find ways to improve them.

Can I reply to the review email with "approve" or comment on it? Then we would need to think of a way to transmit secrets in the reply-to

On 05.12.2013 09:44, Andreas Jaeger wrote: header, so I can be more certain that it's you. I don't really like trusting emails. It might be ok for comments added, but surely not for commands. Greetings, Stephan

That would be cool ;)

Content looks fine to me, thanks,

-- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

Here is my take on the notifications. Let's start with some types that we will likely have: 1) request accepted 2) request declined 3) request revoked 4) request superseded 5) review accepted 6) review declined 7) review added 8) comment added On Thursday 05 December 2013 07:04:19 Stephan Kulow wrote:

Am 04.12.2013 20:29, schrieb Dimstar / Dominique Leuenberger:

...

...

I wonder - who should get mail too?

- target maintainer

Wants 1,2,3,4

...

...

- source maintainer

Wants 1,2,5,6,7,8

...

...

- current reviewers

Wants 5,6,7,8. Reviewers don't care what happens with requests afterwards (hence no 1,2,3,4)

...

...

- accepted reviewers

Wants 5,6,7,8. The same as current reviewers IMO (like coolo implied already)

...

...

- open reviews

How is that different to "current reviewers" ? I think that's

...

...

- people previously commenting

Want 1,2,3,4,8. Commenter only are most likely not interested in reviews.

...

...

- any other candidates?

Hmm. that sounds in any case like a place for disaster.. I myself would prefer 'too many' of those mails as opposed to missing some.

Of the list above, I'd say 'accepted reviewers' is likely the least interested in it..

The others sound rather logical..

Well, if Sascha accepted a review and you look at it too and notice that Sascha overlooked something, wouldn't you want Sascha to know? :)

I agree here, though Sascha already has far too much mails too. It depends how the commenting feature will fit in. So I wonder how notifications will be configurable, i.e. either OBS-wide or per-project? It would be perfect to have some global config (also easy to start with) but allow to override with per-project specific things. This would allow to mute stuff in devel:$boring, whereas I always want stuff for openSUSE:Factory. Others may have different preferences. -- With kind regards, Sascha Peilicke SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg)

Quoting Andreas Jaeger :

On 12/05/2013 09:24 AM, Stephan Kulow wrote:

...

On 03.12.2013 21:24, Stephan Kulow wrote:

...

The first step will be to send mails for review - which does not work I deployed that now and sent out some emails - before disabling it again.

So factory reviewers should have got some email - please review their content and let's find ways to improve them.

Can I reply to the review email with "approve" or comment on it?

What would be the outcome if multiple reviewers approve / decline, with conflicting messages? If we WOULD do that, I guess the mails should be forcibly PGP signed and the key added as property to the user account (that could be interesting for 'connect' anyway.. ) so the mailer could validate that the approve / decline is indeed coming from one of the expected reviewers. For comments I could see big potential.. could be very efficient to initiate dialogs on packages. Dominique -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

On Thursday 05 December 2013 09:50:00 Stephan Kulow wrote:

On 05.12.2013 09:44, Andreas Jaeger wrote:

...

On 12/05/2013 09:24 AM, Stephan Kulow wrote:

...

On 03.12.2013 21:24, Stephan Kulow wrote:

...

The first step will be to send mails for review - which does not work

I deployed that now and sent out some emails - before disabling it again.

So factory reviewers should have got some email - please review their content and let's find ways to improve them.

Can I reply to the review email with "approve" or comment on it?

Then we would need to think of a way to transmit secrets in the reply-to header, so I can be more certain that it's you. I don't really like trusting emails. It might be ok for comments added, but surely not for commands.

Yeah, usually you would have to generate (and store) a secret for every mail for which you could reply to and trigger some server-side code. That secret then would have to be valid only for a certain amount of time and you have to do all kinds of server-side checks (mail headers, the secret). It's like a "reset password" URL. IMO later, let the notification be finalized first. -- With kind regards, Sascha Peilicke SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg)

On 05.12.2013 09:58, Dominique Leuenberger a.k.a. Dimstar wrote:

Quoting Andreas Jaeger :

...

On 12/05/2013 09:24 AM, Stephan Kulow wrote:

...

On 03.12.2013 21:24, Stephan Kulow wrote:

...

The first step will be to send mails for review - which does not work I deployed that now and sent out some emails - before disabling it again.

So factory reviewers should have got some email - please review their content and let's find ways to improve them.

Can I reply to the review email with "approve" or comment on it?

What would be the outcome if multiple reviewers approve / decline, with conflicting messages?

If we WOULD do that, I guess the mails should be forcibly PGP signed and the key added as property to the user account (that could be interesting for 'connect' anyway.. )

so the mailer could validate that the approve / decline is indeed coming from one of the expected reviewers.

For comments I could see big potential.. could be very efficient to initiate dialogs on packages.

That reminds me that I need to map the threading of comments to the emails. Which will be even more fun to remap on incoming emails. It would all be so much easier if comments where a plain list ;( Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

On 05.12.2013 10:04, Dominique Leuenberger a.k.a. Dimstar wrote:

Quoting Stephan Kulow :

...

On 05.12.2013 09:56, Stephan Kulow wrote:

...

...

But as far as I know you now, I'm expecting you to change the system in the next 15 minutes so that a reviewer can change his opinion :)

That's a valid expectation ;)

osc review reopen -G opensuse-review-team <ID>

-> done

I'm an MCSA => most Clicking System Administrator. any way to do it with a mouse? :) Webui?

Just go to your mailer, copy the command out of the mail using the mouse and paste it in an xterm using middle click :) Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

On 05.12.2013 09:54, Dominique Leuenberger a.k.a. Dimstar wrote:

I did receive two of those mails.. very good start IMHO.

some 'technicalities' first: - The X-Mailer is different between 'hermes' and 'new' notifications. Hermes: openSUSE Notification System 'New : OBS Notification System

so anybody doing filtering on 'mailer' to catch hermes notifications falls in a trap. I'm afraid we'll have to live with that. I'm not going to make the X-Mailer configurable and the hermes@opensuse.org in the From is a temporary aid too, it's just not hermes ;)

The 'new' notifications do also not carry a X-Hermes-Msg-Type: header (which is what I used to filter them away :) )

They do have one if there is a Hermes-Msg-Type. But Hermes never had a "Review wanted" message type and I'm not going to lie ;) But yes, I too filtered for that. Perhaps I just put a 'none' in there? Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

On 05.12.2013 10:11, Stephan Kulow wrote:

They do have one if there is a Hermes-Msg-Type. But Hermes never had a "Review wanted" message type and I'm not going to lie ;)

But yes, I too filtered for that. Perhaps I just put a 'none' in there?

Even worse, I just double checked. I filter for "OBS" in the Msg-Type. So me too will have to adapt the mail filter. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

Quoting Stephan Kulow :

...

The 'new' notifications do also not carry a X-Hermes-Msg-Type: header (which is what I used to filter them away :) )

They do have one if there is a Hermes-Msg-Type. But Hermes never had a "Review wanted" message type and I'm not going to lie ;)

But yes, I too filtered for that. Perhaps I just put a 'none' in there?

Stephan, is this a static, defined, standardized and approved list? Otherwise, I'm pretty sure it can be extended and new status introduced into the field. Otherwise, 'none', 'unknown', 'not yet defined' would be options.. It really makes life easier to filter based on expected headers (I don't l;ike filtering on sender addresses). Dominique -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05.12.2013 14:45, Michal Vyskocil wrote:

On Thu, Dec 05, 2013 at 09:50:00AM +0100, Stephan Kulow wrote:

...

On 05.12.2013 09:44, Andreas Jaeger wrote:

...

On 12/05/2013 09:24 AM, Stephan Kulow wrote:

...

On 03.12.2013 21:24, Stephan Kulow wrote:

...

The first step will be to send mails for review - which does not work I deployed that now and sent out some emails - before disabling it again.

So factory reviewers should have got some email - please review their content and let's find ways to improve them.

Can I reply to the review email with "approve" or comment on it? Then we would need to think of a way to transmit secrets in the reply-to header, so I can be more certain that it's you. I don't really like trusting emails. It might be ok for comments added, but surely not for commands.

Would be application/pgp-signed sufficient? I know that you wouldn't be able to accept requests from your favourite web interface, but most of reasonable MUAs cope with GPG well.

Yeah. But you guys figure how long it took to get mail notifications, right? Guess how long it will take to get mail commands working with GPG :) Greetings, Stephan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iD8DBQFSoIXBwFSBhlBjoJYRAqo1AKC8lyA+TagMpPu2AyhqWXWcwVd9qgCePbEY hY3AMt2NAZyqqnnpA12bD0E= =v2bS -----END PGP SIGNATURE----- -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org