[opensuse-buildservice] Is osc source validator supposed to recognize a commented out escaped %
Hi, is it an intended feature in the osc source validator that it picks up "#%{xx}" as a macro? It's fine if I shouldn't submit things like this to major repos like factory but when I'm working on a package it's a #%{xx} pain in the neck. The source validator is a fantastic tool but that quirk which results in the message "ERROR: source_validator failed" is going to drive me mad. Could somebody please at least enable a switch to turn it off or make it ignore comments. I'm going to have to uninstall it again. Please don't suggest that I help out and fix it, I estimate that the source validator has already cost me a couple of days preventing me from completing things I'm supposed to be doing. Thanks very much. Dave Plater
On 2010-10-02 22:18:18 +0200, Dave Plater wrote:
Date: Sat, 02 Oct 2010 22:18:18 +0200 From: Dave Plater davejplater@gmail.com Subject: [opensuse-buildservice] Is osc source validator supposed to recognize a commented out escaped % To: opensuse-buildservice@opensuse.org
Hi, is it an intended feature in the osc source validator that it picks up "#%{xx}" as a macro? It's fine if I shouldn't submit things like this to major repos like factory but when I'm working on a package it's a #%{xx} pain in the neck. The source validator is a fantastic tool but that quirk which results in the message "ERROR: source_validator failed" is going to drive me mad. Could somebody please at least enable a switch to turn it off or make it ignore comments. I'm going to have to uninstall it again. Please don't suggest that I help out and fix it, I estimate that the source validator has already cost me a couple of days preventing me from completing things I'm supposed to be doing. Thanks very much.
why not make it: #{...}
darix
On 2010-10-02 22:18:18 +0200, Dave Plater wrote:
Hi, is it an intended feature in the osc source validator that it picks up "#%{xx}" as a macro? It's fine if I shouldn't submit things like this to major repos like factory but when I'm working on a package it's a #%{xx} pain in the neck.
Yes that's expected (IMHO). For instance consider the following (multiline) macro: %define foo bla \ echo "bar"
If you write in your spec file "#%foo" it still will print out "bar". You need to escape the macro: "#%%foo". Btw. you can also use "osc ci --skip-validation" (which isn't recommended).
Marcus
On 10/02/2010 11:32 PM, Marcus Hüwe wrote:
On 2010-10-02 22:18:18 +0200, Dave Plater wrote:
Hi, is it an intended feature in the osc source validator that it picks up "#%{xx}" as a macro? It's fine if I shouldn't submit things like this to major repos like factory but when I'm working on a package it's a #%{xx} pain in the neck.
Yes that's expected (IMHO). For instance consider the following (multiline) macro: %define foo bla \ echo "bar"
If you write in your spec file "#%foo" it still will print out "bar". You need to escape the macro: "#%%foo".
The first time I encountered this I had commented in blender .spec about the reason for a file which told the wrapper script which version was installed to enable an update of $HOME/.blender, in the comment was %{version} and changing it to %%{version} didn't work. I'd requested a change upstream, I'm not sure yet, haven't finished blender yet, it looks like the wrapper is no longer needed.
Btw. you can also use "osc ci --skip-validation" (which isn't recommended).
Marcus
It will prevent headaches though and it's easier than zypper rm. Thanks Dave P
buildservice@lists.opensuse.org
-
Dave Plater -
Marcus Hüwe -
Marcus Rueckert