[opensuse-buildservice] debtransform patches
Hello, I've used the debtransform functionality of the buildservice and I'll like to propose the two attached patches: 1) Debian-based distros require the tarball to be .tar.gz , which is annoying with cross-distro packaging. This patch adds support for using .tar.bz2 or .zip and debtransform converts the archive to .tar.gz , in addition to renaming it as it does now. I've tested this locally with osc build and it seems to work fine. If this is accepted, can you give me an estimate for when it gets deployed? It'd save me a bit of writing in a howto, but I don't insist :). 2) Applying patches using debian.series has a different default for the -p argument of patch. While .spec defaults to -p0, debtransform defaults to -p1. This is again annoying with cross-distro packaging. This is a backwards-incompatible change, but I would consider this to be a bugfix and I expect there aren't many packages that rely on the default in debtransform now, because of it not being consistent with .spec . -- Lubos Lunak KDE developer -------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: l.lunak@suse.cz , l.lunak@kde.org Lihovarska 1060/12 tel: +420 284 028 972 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz
On Mon, Jun 29, 2009 at 03:16:02PM +0200, Lubos Lunak wrote:
I've used the debtransform functionality of the buildservice and I'll like to propose the two attached patches:
1) Debian-based distros require the tarball to be .tar.gz , which is annoying with cross-distro packaging. This patch adds support for using .tar.bz2 or .zip and debtransform converts the archive to .tar.gz , in addition to renaming it as it does now. I've tested this locally with osc build and it seems to work fine.
Why don't you just use ".gz" instead?
2) Applying patches using debian.series has a different default for the -p argument of patch. While .spec defaults to -p0, debtransform defaults to -p1.
IIRC this is to be compatible to the "quilt" series file. Cheers, Michael. -- Michael Schroeder mls@suse.de SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Tuesday 30 of June 2009, Michael Schroeder wrote:
On Mon, Jun 29, 2009 at 03:16:02PM +0200, Lubos Lunak wrote:
I've used the debtransform functionality of the buildservice and I'll like to propose the two attached patches:
1) Debian-based distros require the tarball to be .tar.gz , which is annoying with cross-distro packaging. This patch adds support for using .tar.bz2 or .zip and debtransform converts the archive to .tar.gz , in addition to renaming it as it does now. I've tested this locally with osc build and it seems to work fine.
Why don't you just use ".gz" instead?
Because rpmlint then complains to me. Or maybe because there are advantages to using the original tarball, like being to able to easily check it really is the original tarball (which makes Debian requiring .tar.gz rather funny, because it is otherwise so much against modifying the tarball for these reasons).
2) Applying patches using debian.series has a different default for the -p argument of patch. While .spec defaults to -p0, debtransform defaults to -p1.
IIRC this is to be compatible to the "quilt" series file.
:( . Well, I suppose somebody wanting to do a shared .rpm/.deb build from just one source will need a syncing script anyway. -- Lubos Lunak KDE developer -------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: l.lunak@suse.cz , l.lunak@kde.org Lihovarska 1060/12 tel: +420 284 084 672 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On 2009-06-29 15:16:02 +0200, Lubos Lunak wrote:
I've used the debtransform functionality of the buildservice and I'll like to propose the two attached patches:
1) Debian-based distros require the tarball to be .tar.gz , which is annoying with cross-distro packaging. This patch adds support for using .tar.bz2 or .zip and debtransform converts the archive to .tar.gz , in addition to renaming it as it does now. I've tested this locally with osc build and it seems to work fine.
this is not true. debian handles .bz2 and even .lzma/.xz. you just need to specify the right format in the dsc file (format 3)
If this is accepted, can you give me an estimate for when it gets deployed? It'd save me a bit of writing in a howto, but I don't insist :).
2) Applying patches using debian.series has a different default for the -p argument of patch. While .spec defaults to -p0, debtransform defaults to -p1. This is again annoying with cross-distro packaging. This is a backwards-incompatible change, but I would consider this to be a bugfix and I expect there aren't many packages that rely on the default in debtransform now, because of it not being consistent with .spec .
format 3 has optional quilt support (format 3.0 quilt) darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Tuesday 30 of June 2009, Marcus Rueckert wrote:
On 2009-06-29 15:16:02 +0200, Lubos Lunak wrote:
I've used the debtransform functionality of the buildservice and I'll like to propose the two attached patches:
1) Debian-based distros require the tarball to be .tar.gz , which is annoying with cross-distro packaging. This patch adds support for using .tar.bz2 or .zip and debtransform converts the archive to .tar.gz , in addition to renaming it as it does now. I've tested this locally with osc build and it seems to work fine.
this is not true. debian handles .bz2 and even .lzma/.xz. you just need to specify the right format in the dsc file (format 3)
That seems to fail the reality check. Definitely at least with the build service: dpkg-source: error: source package format `3.0' is not supported (Perl module Dpkg::Source::Package::V3 is required) -- Lubos Lunak KDE developer -------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: l.lunak@suse.cz , l.lunak@kde.org Lihovarska 1060/12 tel: +420 284 084 672 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On 2009-06-30 16:44:20 +0200, Lubos Lunak wrote:
On Tuesday 30 of June 2009, Marcus Rueckert wrote:
On 2009-06-29 15:16:02 +0200, Lubos Lunak wrote:
I've used the debtransform functionality of the buildservice and I'll like to propose the two attached patches:
1) Debian-based distros require the tarball to be .tar.gz , which is annoying with cross-distro packaging. This patch adds support for using .tar.bz2 or .zip and debtransform converts the archive to .tar.gz , in addition to renaming it as it does now. I've tested this locally with osc build and it seems to work fine.
this is not true. debian handles .bz2 and even .lzma/.xz. you just need to specify the right format in the dsc file (format 3)
That seems to fail the reality check. Definitely at least with the build service:
dpkg-source: error: source package format `3.0' is not supported (Perl module Dpkg::Source::Package::V3 is required)
what distro are we talking about? darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Tuesday 30 of June 2009, Marcus Rueckert wrote:
On 2009-06-30 16:44:20 +0200, Lubos Lunak wrote:
On Tuesday 30 of June 2009, Marcus Rueckert wrote:
this is not true. debian handles .bz2 and even .lzma/.xz. you just need to specify the right format in the dsc file (format 3)
That seems to fail the reality check. Definitely at least with the build service:
dpkg-source: error: source package format `3.0' is not supported (Perl module Dpkg::Source::Package::V3 is required)
what distro are we talking about?
Ubuntu:8.10 or Ubuntu:9.04, make your pick. -- Lubos Lunak KDE developer -------------------------------------------------------------- SUSE LINUX, s.r.o. e-mail: l.lunak@suse.cz , l.lunak@kde.org Lihovarska 1060/12 tel: +420 284 084 672 190 00 Prague 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
participants (3)
-
Lubos Lunak -
Marcus Rueckert -
Michael Schroeder