Dominique, Thanks for pointing out the way. I've made most of the changes you recommended and it seems to work properly. I've also took some notes on the webpages you pointed for future usage. If it's not pushing too much... I've also hammer-packaged notifyconf, which is a tool that can used to configure the notify-osd (packaged with patch to enable it), so that users can tune it to their taste. This stuff around notifyconf has been most challenging and that spec is by far more complicated. Could you also point some directions please? I've tried to make it according to the directions you have pointed me before. Some references: https://launchpad.net/notifyconf https://build.opensuse.org/package/show?package=notifyconf&project=home:ketheriel Thanks for the great help. Nelson. On Mon, 2010-09-06 at 22:19 +0200, Dominique Leuenberger wrote:
Hi Nelson,
Nelson Marques <nmo.marques@gmail.com> 09/06/10 9:35 PM >>> Hi all,
My name is Nelson and I'm toying around with osc and build service for some time. Though I'm far for being proficient with openSUSE tools or openSUSE packaging, I'm trying to get hang of this.
I've taken notify-osd[1] and notifyconf[2] which are based on launchpad and tried to build them (with some questionable success), and not exactly following the standard rules.
I would love to make this packages available as an option for GNOME users on openSUSE. I have much too learn and and I do have some spare time to work them out.
Any feedback on faulty stuff on the specs and some help with links to documents where I can get information to work around some flaws detected will be most welcomed, so that they can comply with openSUSE standards.
My build service user name is 'ketheriel' and I have my home here[3].
First, let me welcome here! It's great to see some new names popping by.
As for your spec file, I did have a look at it and there is actually not many things that would need to be changed at all. I'd say you got a very good start on this one. Most of the things I probably won't find links though to point out where it's documented... somewhere in the wiki; starting point would be [0].
Small things like the Group selected for the package: System/Libraries is really meant for libraries. Stuff, that should only ever be pulled in as a dependency. [1] Shows a list of valid groups, together with explanation which one could be used in what case. Then, the build log can give you valuable information about common errors at the end. In your case, it spit's out that you use a macro, %doc, in the changelog. Can be possibly dangerous, as macros are also expanded there. Rewriting this as %%doc would solve this warning.
Your %prep section could probably just be changed to %prep %setup -q %patch0 -p0
Setup will create the subfolder named %{name}-%{verision} and this will be set as the new base folder. As such, you also do not have to change inside this folder. Less to type, less places, an error can slip in.
%build section: %configure already contains a --prefix parameter, which is set to %{_prefix}. In case of openSUSE this actually is evaluated to /usr, as such your parameter is just redundant. Does this app work with parallel building? You can try to use %__make %{?_smp_mflags} (this will expand to something like "make -j 4", depending on the host it runs on)
%install section: Do not rm the %buildroot. This is done in %clean For make install DESTDIR=$RPM_BUILD_ROOT, you can use the macro %make_install
%files section: That's all fine. Only if you would change the %prep to just be %setup, you would have to remove the various %name-%version references... but other than that, this is all fine.
As for %changelog, at openSUSE we split this out in an external file, the .changes file. Using "osc vc" you can create a new entry at the top of the file with the correct timestamp and formatting. The general rule there is to not exceed the 67 characters (same as the dashed line).
I think that's all I see for now. Should you have any questions left, feel free to ask.
Best regards, Dominique
[0] http://en.opensuse.org/openSUSE:Packaging_guidelines [1] http://old-en.opensuse.org/SUSE_Package_Conventions/RPM_Groups
-- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org