Dominique, Thanks for your input. It took me a while to accomplish that one. The $RPM_BUILD_ROOT inherits from Fedora. It was particulary challenging that one because there was no autotools for QT, and I really can't patch it because my knowledge is very narrow on computer science (my field is actually marketing management). The main reason why I'm doing this is because I wanted to try out and maybe write a small article about openSUSE's Build Service. First I wanted some 'field experience' and face the challenges a new packager might feel so that later I can contact Build Service's liaison and gather some more intel to accomplish it :) But since everything seems to go fine, maybe it's time to pick a project and aim for having them on a 'visible' repo for our users to have an alternative :) I'll be around :) Once more, thanks for your kind support. Nelson On Tue, 2010-09-07 at 09:30 +0200, Dominique Leuenberger wrote: <snip>
I had a look at this spec and I have to say there is really nothing wrong with it! Good work!
Of course there can be some styling addressed, but generally, the spec is absolutely fine. Thins I would change (which most of them are personal taste.. so don't worry about them too much:) Replace $RPM_BUILD_ROOT with %{buildroot} It looks less shouty :) other than that it's the same.. as said: personal taste.
In the install section, where you copy the .desktop file, you could make use of the fact it's listed as source file (Source1 in your case) and use install %{S:1} <destination> But as you can imagine, this also expands to the same you already have.
Best regards, Dominique
-- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org