Every time I upgrade (replace) bs_publish, I need to fix it with the following issue: gpgcheck=1 is *always* added. IMO, it should only be added if the packages are actually signed. The current code: print FILE "gpgcheck=1\n"; if (!@$signargs) { print FILE "gpgkey=$BSConfig::gpg_standard_key\n" if ( defined($BSConfig::gpg_standard_key) ); } else { print FILE "gpgkey=$BSConfig::repodownload/$prp_ext/repodata/repomd.xml.key\n"; } I would change that to: if (!@$signargs) { if ( defined($BSConfig::gpg_standard_key) ) { print FILE "gpgcheck=1\n"; print FILE "gpgkey=$BSConfig::gpg_standard_key\n"; } } else { print FILE "gpgcheck=1\n"; print FILE "gpgkey=$BSConfig::repodownload/$prp_ext/repodata/repomd.xml.key\n"; } -- Jon -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org