https://bugzilla.novell.com/show_bug.cgi?id=445189
Summary: boot.rootfsck doesn't remount root rw Product: openSUSE 11.1 Version: Factory Platform: All OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: jslaby@novell.com QAContact: qa@suse.de Found By: ---
When on battery or fastboot is set, root partition is not remounted rw.
This causes the rest of system to not boot -- each service fails with read-only filesystem error.
https://bugzilla.novell.com/show_bug.cgi?id=445189
User jslaby@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=445189#c1
--- Comment #1 from Jiri Slaby jslaby@novell.com 2008-11-16 13:30:11 MST --- Well, the core problem here is, that the root is remounted to ro and rw while fscking which has a side effect of enabling write on the partition.
It should switch to rw in any case (especially if user passes ro on the kernel cmdline).
https://bugzilla.novell.com/show_bug.cgi?id=445189
Andreas Jaeger aj@novell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.provo.novell.com |werner@novell.com
https://bugzilla.novell.com/show_bug.cgi?id=445189
Dr. Werner Fink werner@novell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |werner@novell.com AssignedTo|werner@novell.com |ro@novell.com
https://bugzilla.novell.com/show_bug.cgi?id=445189
User werner@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=445189#c2
--- Comment #2 from Dr. Werner Fink werner@novell.com 2008-11-17 03:36:33 MST --- IMHO If the user says `ro' it has to be `ro' ... this is exactly what I expect if I use `ro'.
https://bugzilla.novell.com/show_bug.cgi?id=445189
User ro@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=445189#c3
Ruediger Oertel ro@novell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |jslaby@novell.com
--- Comment #3 from Ruediger Oertel ro@novell.com 2008-11-17 04:20:51 MST --- initial comment and comment #1 seem to contradict each other. what exactly are you trying to do ?
if the boot commandline contains "ro", then the root-fs should remain "ro", if the boot commandline does not contain "ro" then the root-fs should be normally checked and remounted "rw".
(And most of this is done inside the initrd anyway).
what exactly is the problem ?
https://bugzilla.novell.com/show_bug.cgi?id=445189
User jslaby@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=445189#c4
--- Comment #4 from Jiri Slaby jslaby@novell.com 2008-11-17 15:37:38 MST --- ro and rw are kernel parameters and should have nothing to do with userspace scripts. I expect bootup scripts to remount the root rw if it is safe (after fsck, being clean, ...).
I usually put ro on the kernel commandline to not let the kernel mount it rw, even if it is the kernel default. When I use no initrd, it remains ro while being on battery or fastboot flag is used unlike in at least debian and fedora, where it behaves properly(tm).
https://bugzilla.novell.com/show_bug.cgi?id=445189
User werner@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=445189#c5
--- Comment #5 from Dr. Werner Fink werner@novell.com 2008-11-18 03:05:26 MST --- There are a lot of flags used on the kernels command line which are only used in user space (e.g. `confirm'), there are parameters for both the kernel and the user space, and at last but not least there are flags which belongs to the kernel only. The flag `ro' IMHO belongs to both the kernel and the user space ... e.g. I use this flag mostly combinded for booting into single user mode.
Beside this not using initrd will force the file system check of the root file system done by boot.rootfsck, that is that this scripts is readed from the same partition which is checked. Normally this should be done by the initrd.
https://bugzilla.novell.com/show_bug.cgi?id=445189
User ro@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=445189#c6
Ruediger Oertel ro@novell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Info Provider|jslaby@novell.com |kukuk@novell.com
--- Comment #6 from Ruediger Oertel ro@novell.com 2008-11-19 03:58:31 MST --- any thoughts from your side Thorsten ?
the main question is: should "ro" on the boot commandline end up with "/" mounted "ro" or "rw" after booting is finished ?
https://bugzilla.novell.com/show_bug.cgi?id=445189
User jslaby@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=445189#c7
--- Comment #7 from Jiri Slaby jslaby@novell.com 2008-11-19 04:14:18 MST --- (In reply to comment #5 from Werner Fink)
There are a lot of flags used on the kernels command line which are only used in user space (e.g. `confirm'), there are parameters for both the kernel and the user space, and at last but not least there are flags which belongs to the kernel only. The flag `ro' IMHO belongs to both the kernel and the user space ... e.g. I use this flag mostly combinded for booting into single user mode.
The other most used distros doesn't share your opinion. Fedora adds readonlyroot boot parameter, debian doesn't add anything and mounts rw unconditionaly unless you specify ro in fstab.
Beside this not using initrd will force the file system check of the root file system done by boot.rootfsck,
Well, no. I repeat that this happens unless fastboot is specified or being on battery. I can't see a path in the code which would do this in these particular cases.
that is that this scripts is readed from the same partition which is checked. Normally this should be done by the initrd.
Initrd slows down boot significantly and many users simply doesn't use it. Even boot scripts count with this, except this bug. (Beside the fact I haven't tested this situation with initrd, so that I can't verify or refute if it is remounted rw.)
https://bugzilla.novell.com/show_bug.cgi?id=445189
User jslaby@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=445189#c8
--- Comment #8 from Jiri Slaby jslaby@novell.com 2008-11-19 04:16:27 MST --- (In reply to comment #6 from Ruediger Oertel)
the main question is: should "ro" on the boot commandline end up with "/" mounted "ro" or "rw" after booting is finished ?
Whatever Thorsten utters as a fact from now on, it'll still remain a bug if I pass nothing on the commandline. Kernel defaults to ro and nobody will remount it rw in that case anyway.
https://bugzilla.novell.com/show_bug.cgi?id=445189
User kukuk@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=445189#c9
Thorsten Kukuk kukuk@novell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kukuk@novell.com Status|NEEDINFO |NEW Info Provider|kukuk@novell.com |
--- Comment #9 from Thorsten Kukuk kukuk@novell.com 2008-11-19 04:18:16 MST --- (In reply to comment #6 from Ruediger Oertel)
any thoughts from your side Thorsten ?
the main question is: should "ro" on the boot commandline end up with "/" mounted "ro" or "rw" after booting is finished ?
We had this discussion already some month ago. "ro" is a pure kernel option and does not overwrite /etc/fstab.
We fixed that bug already for the case the fsck is running, so seems we need to fix it for the case that fsck is not running.
meand, if fstab says "ro", don't mount it rw, else mount it rw.
https://bugzilla.novell.com/show_bug.cgi?id=445189
User jslaby@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=445189#c10
--- Comment #10 from Jiri Slaby jslaby@novell.com 2008-11-19 04:22:46 MST --- (In reply to comment #9 from Thorsten Kukuk)
meand, if fstab says "ro", don't mount it rw, else mount it rw.
Seems OK to me. I'll also appreciate fedora's readonlyroot parameter as mentioned in comment #7. Should I create a new "enhancement bug" for this, or does the parameter look like a nonsense in your eyes?
https://bugzilla.novell.com/show_bug.cgi?id=445189
Ruediger Oertel ro@novell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |ASSIGNED Component|Basesystem |Basesystem Version|Factory |unspecified AssignedTo|ro@novell.com |bnc-team-screening@forge.pr | |ovo.novell.com Product|openSUSE 11.1 |openSUSE 11.2
https://bugzilla.novell.com/show_bug.cgi?id=445189
Martin Mrazik mmrazik@novell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW
https://bugzilla.novell.com/show_bug.cgi?id=445189
Cyril Hrubis chrubis@novell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |ro@novell.com |ovo.novell.com |
https://bugzilla.novell.com/show_bug.cgi?id=445189
User ro@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=445189#c11
Ruediger Oertel ro@novell.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #11 from Ruediger Oertel ro@novell.com 2009-03-02 05:01:00 MST --- I think it makes sense to have a way of specifying on the cmdline if "/" should stay "ro" and "readonlyroot" is a proper name to do this.
-
bugzilla_noreply＠novell.com