[Bug 1035118] New: plasma5-workspace.x86_64: W: invalid-desktopfile
http://bugzilla.opensuse.org/show_bug.cgi?id=1035118 Bug ID: 1035118 Summary: plasma5-workspace.x86_64: W: invalid-desktopfile Classification: openSUSE Product: openSUSE.org Version: unspecified Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: 3rd party software Assignee: hrvoje.senjan@gmail.com Reporter: simonf.lees@suse.com QA Contact: opensuse-communityscreening@forge.provo.novell.com Found By: --- Blocker: --- plasma5-workspace.x86_64: W: invalid-desktopfile /usr/share/applications/org.kde.klipper.desktop value item "TrayIcon" in key "Categories" in group "Desktop Entry" is a reserved category, so a "OnlyShowIn" key must be included .desktop file is not valid, check with desktop-file-validate -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1035118 http://bugzilla.opensuse.org/show_bug.cgi?id=1035118#c1 Benjamin Greiner <code@bnavigator.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P4 - Low Status|NEW |CONFIRMED CC| |code@bnavigator.de Severity|Normal |Minor --- Comment #1 from Benjamin Greiner <code@bnavigator.de> --- This is because upstream only uses `NotShowIn=KDE` but actually wants to show the icon in other environments. By the spec, this prevents the use of `TrayIcon`. Upstream does not include `TrayIcon` as category but has the main category `Utility` without a subcategory. As OpenSUSE requires a valid subcategory, I propose to switch to `Utility;TextEditor`. See also the thread here: https://lists.debian.org/debian-qt-kde/2016/09/msg00068.html -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1035118 http://bugzilla.opensuse.org/show_bug.cgi?id=1035118#c2 Christophe Giboudeaux <christophe@krop.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe@krop.fr --- Comment #2 from Christophe Giboudeaux <christophe@krop.fr> --- (In reply to Benjamin Greiner from comment #1)
This is because upstream only uses `NotShowIn=KDE` but actually wants to show the icon in other environments. By the spec, this prevents the use of `TrayIcon`. Upstream does not include `TrayIcon` as category but has the main category `Utility` without a subcategory.
As OpenSUSE requires a valid subcategory, I propose to switch to `Utility;TextEditor`.
See also the thread here: https://lists.debian.org/debian-qt-kde/2016/09/msg00068.html
As a KDE maintainer, I disagree. The problem *is* the openSUSE policies wrt desktop categories which don't respect the menu spec. To make it short: - "Desktop entries should list all categories that clearly apply. They should not list categories that only vaguely or possibly apply" [1]. So, 'TextEditor' is a no-go. - 'X-' prefixed categories are valid - Additional categories are not mandatory - The menu spec also says the "related" categories in the additional categories table are only "suggestions" [2] [1] https://standards.freedesktop.org/menu-spec/latest/ar01s03.html [2] https://standards.freedesktop.org/menu-spec/latest/apas02.html « The Related Categories column lists one or more categories that are *suggested* to be used in conjunction with the Additional Category » When brp-check-suse is fixed to respect the policies, I'd be more than happy to revert categories back to 'Qt;KDE;Utility;X-KDE-Utilities-Desktop;' -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1035118 http://bugzilla.opensuse.org/show_bug.cgi?id=1035118#c3 --- Comment #3 from Benjamin Greiner <code@bnavigator.de> --- That may be true but `TrayIcon` without `OnlyShowIn` violates the XDG spec, which in my eyes is a more severe violation than having the *additional* requirement by SUSE to hava a valid subcategory. brp-check-suse and update-desktop-file actually allow Utility;X-SUSE-DesktopUtility. How about that one? I updated the wiki for the SUSE guidelines to list it. https://en.opensuse.org/openSUSE:Packaging_desktop_menu_categories#Utility -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1035118 http://bugzilla.opensuse.org/show_bug.cgi?id=1035118#c4 Christophe Giboudeaux <christophe@krop.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Christophe Giboudeaux <christophe@krop.fr> --- As suggested on the submit request, this is not something that can be fixed unless the brp-check-suse wrong behaviour is fixed. (the fix is to revert to upstream categories) -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com