[Bug 525274] New: gftp-2.0.18-251.39: 2 * missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=525274 Summary: gftp-2.0.18-251.39: 2 * missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package gftp-2.0.18-251.39 For source code file gftp-2.0.18/lib/config_file.c around line 200 is the source code for the function gftp_read_bookmarks. I notice the following code if ((bmfile = fopen (tempstr, "r")) == NULL) but no corresponding matching calls to fclose. This looks like a resource leak to me. Suggest add calls to fclose to close the leak. Similar problems with local variable conffile in function gftp_read_config_file. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525274 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |sbrabec@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525274 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=525274#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:54:44 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525274 http://bugzilla.novell.com/show_bug.cgi?id=525274#c Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pgajdos@novell.com AssignedTo|sbrabec@novell.com |pgajdos@novell.com -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525274 http://bugzilla.novell.com/show_bug.cgi?id=525274#c2 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |UPSTREAM --- Comment #2 from Petr Gajdos <pgajdos@novell.com> 2010-05-03 11:29:47 UTC --- I have sent patch to masneyb@gftp.org. Closing. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com