[Bug 529617] New: quagga-0.99.13-1.5: missing call to close
http://bugzilla.novell.com/show_bug.cgi?id=529617 Summary: quagga-0.99.13-1.5: missing call to close Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package quagga-0.99.13-1.5 For source code file quagga-0.99.13/lib/pid_output.c around line 70 is the source code for the function pid_output. I notice the following line of code fd = open (path, O_RDWR | O_CREAT, PIDFILE_MASK); but I fail to notice a call to close. This looks like a resource leak to me. Suggest add call to close. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529617 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |prusnak@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529617 Pavol Rusnak <prusnak@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|quagga-0.99.13-1.5: missing |JJ: quagga-0.99.13-1.5: |call to close |missing call to close -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529617 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=529617#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:54:57 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=529617 https://bugzilla.novell.com/show_bug.cgi?id=529617#c2 Pavol Rusnak <prusnak@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX Severity|Normal |Major --- Comment #2 from Pavol Rusnak <prusnak@novell.com> 2010-11-12 19:37:52 CET --- wontfix -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com