http://bugzilla.opensuse.org/show_bug.cgi?id=948771 http://bugzilla.opensuse.org/show_bug.cgi?id=948771#c2 Fabian Vogt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fvogt@suse.com --- Comment #2 from Fabian Vogt --- To the "systemd-fstab-generator" messages: The "root=" parameter in /proc/cmdline is equvalent to an entry in /etc/fstab, so the warning is expected and necessary (although it could be worded better) as the mount options in /etc/fstab for / are ignored. See also http://lists.opensuse.org/opensuse-factory/2015-10/msg00138.html The goal is to remove "root=" from the default kernel commandline, but that's a multi-stage process. If the warning is too annoying or has any other side effects it'd definitely be possible to revert the patch or just remove the warning. I can confirm that the other errors are also there for me. The udev error is actually even in the sg3_utils upstream package and a result of a rogue commented line. The kdm_config warning is a result of /var/adm/kdmrc.sysconfig (its purpose is to have the information from sysconfig entries). The kdm_greet error has been there for a long time already, I remember seeing it in 13.1. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=948771 http://bugzilla.opensuse.org/show_bug.cgi?id=948771#c4 --- Comment #4 from Fabian Vogt ---

This way it will override any other unit and no extraneous warning will be generated.

That's the correct approach to avoid the warning, but we WANT the warning to appear. It notifies us that mount options for / (for example, discard on XFS which can not be changed at runtime by "mount -o remount,discard") may have been ignored. Once root= is gone from the cmdline it's not an issue anymore. I agree that this patch should've been delayed a bit, but it's not that big of an issue, I hope :-) -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=948771 http://bugzilla.opensuse.org/show_bug.cgi?id=948771#c9 Franck Bui changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fbui@suse.com --- Comment #9 from Franck Bui --- (In reply to Fabian Vogt from comment #4)

...

This way it will override any other unit and no extraneous warning will be generated.

That's the correct approach to avoid the warning, but we WANT the warning to appear. It notifies us that mount options for / (for example, discard on XFS which can not be changed at runtime by "mount -o remount,discard") may have been ignored. Once root= is gone from the cmdline it's not an issue anymore. I agree that this patch should've been delayed a bit, but it's not that big of an issue, I hope :-)

@Fabian: if I'm understanding the new behaviour of dracut correctly, any modifications regarding the rootfs in /etc/fstab by the admin requires now to regenerate the initrd, which is something that is unusual. Is this also the case for other partitions in /etc/fstab or it concerns only / partition ? Thanks. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=948771 http://bugzilla.opensuse.org/show_bug.cgi?id=948771#c14 Andrei Borzenkov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mchang@suse.com --- Comment #14 from Andrei Borzenkov --- (In reply to Fabian Vogt from comment #4)

That's the correct approach to avoid the warning, but we WANT the warning to appear.

In this case grub should be patched to not add automatically root= at all. Otherwise these warnings will be present on every system. There are already far too many users unnecessary alarmed by them. Is it guaranteed that generated initrd will always include correct /etc/fstab line for root? Do we support any other alternative initrd generator that does not do it? Adding mchang to Cc. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=948771 http://bugzilla.opensuse.org/show_bug.cgi?id=948771#c16 --- Comment #16 from Michael Chang --- (In reply to Andrei Borzenkov from comment #14)

(In reply to Fabian Vogt from comment #4)

Is it guaranteed that generated initrd will always include correct /etc/fstab line for root? Do we support any other alternative initrd generator that does not do it?

You made the point, removing root= is risky unless we know how to detect that dracut setup correctly and reliably. :) -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=948771 http://bugzilla.opensuse.org/show_bug.cgi?id=948771#c23 --- Comment #23 from Michael Chang --- (In reply to Fabian Vogt from comment #13)

(In reply to Franck Bui from comment #9)

...

(In reply to Fabian Vogt from comment #4) ... @Fabian: if I'm understanding the new behaviour of dracut correctly, any modifications regarding the rootfs in /etc/fstab by the admin requires now to regenerate the initrd, which is something that is unusual. Only if the location of / or critical mount options were changed.

No. This basically means we need to re-generate initrd to get everything synced to be in safe side. It's hard to distinguish by how mount options is modified and also it's importance. The other problem is user need to be trained to know the new trick.

With root= on the grub cmdline you had to regenerate the bootloader config and it would break in most cases, as grub2-mkconfig doesn't look at /etc/fstab at all AFAICS.

I don't know why grub2 (or any other boot-config) would break without /etc/fstab. The root= is meant to tell kernel or initrd where to look up root partition, then they can take over the control from this given information they would need before they can proceed. Thanks. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=948771 http://bugzilla.opensuse.org/show_bug.cgi?id=948771#c25 --- Comment #25 from Michael Chang --- (In reply to Andrei Borzenkov from comment #17)

(In reply to Michael Chang from comment #15)

sysroot.mount is generated by systemd-fstab-generator, it know nothing about dracut host mode (or whether initrd had been created by dracut for that matter). /sysroot mount point in /etc/fstab is SUSE-specific patch. So now generator runs twice - first for root= kernel command line and next for /sysroot in initrd /etc/fstab.

Thanks for explaining. That sounds a mess really. :( -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=948771 Andrei Dziahel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |develop7@develop7.info -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=948771 http://bugzilla.opensuse.org/show_bug.cgi?id=948771#c31 Bjørn Lie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |zaitor@opensuse.org Resolution|FIXED |--- Assignee|jthumshirn@suse.com |fvogt@suse.com --- Comment #31 from Bjørn Lie --- The sg3_utils part of this bug is fixed indeed, but we still have the dracut/grub vs systemd-generator issue. bjolie@drude:~> journalctl -b | grep systemd-fstab-generator nov. 03 16:41:06 drude systemd-fstab-generator[90]: Failed to create mount unit file /run/systemd/generator/sysroot.mount, as it already exists. Duplicate entry in /etc/fstab? nov. 03 16:41:06 drude systemd[87]: /usr/lib/systemd/system-generators/systemd-fstab-generator failed with error code 1. nov. 03 16:41:07 drude systemd-fstab-generator[375]: Failed to create mount unit file /run/systemd/generator/sysroot.mount, as it already exists. Duplicate entry in /etc/fstab? nov. 03 16:41:07 drude systemd[372]: /usr/lib/systemd/system-generators/systemd-fstab-generator failed with error code 1. bjolie@drude:~> Therefor reopening bug, and reassigning to what might be the wrong person. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=948771 http://bugzilla.opensuse.org/show_bug.cgi?id=948771#c35 --- Comment #35 from Oliver Kurz --- *** Bug 955172 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=948771 http://bugzilla.opensuse.org/show_bug.cgi?id=948771#c37 Marcos Mello changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marcosfrm@gmail.com --- Comment #37 from Marcos Mello --- We are here: https://github.com/systemd/systemd/blob/master/src/fstab-generator/fstab-gen... A more useful message would be welcome. Something among these lines? (I really suck at C) http://paste.opensuse.org/view/raw/71349205 -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.opensuse.org/show_bug.cgi?id=948771 http://bugzilla.opensuse.org/show_bug.cgi?id=948771#c42 Fabian Vogt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #42 from Fabian Vogt --- SR to factory took a bit longer, there were a lot of broken packages in the same staging project. -- You are receiving this mail because: You are on the CC list for the bug.