[Bug 395816] New: Installation: Loading the Timezone dialog could be faster
https://bugzilla.novell.com/show_bug.cgi?id=395816 Summary: Installation: Loading the Timezone dialog could be faster Product: openSUSE 11.1 Version: Alpha 0 Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: P5 - None Component: YaST2 AssignedTo: jsuchome@novell.com ReportedBy: locilka@novell.com QAContact: jsrain@novell.com Found By: --- Created an attachment (id=219157) --> (https://bugzilla.novell.com/attachment.cgi?id=219157) YaST log Loading the Timezone dialog in installation takes some time that users are not informed what's happening. For a normal installation, this is only once, but when you go back and forward the dialogs, the initialization is always the same. This is mostly because the Timezone module doesn't remember being already initialized. For a simple solution, this could be used: --- cut --- boolean initialized = false; void Timezone () { if (initialized) { y2milestone ("Already initialized"); return; } ... } --- cut --- See the last few lines of YaST log. The logs comes from going_back=true. Note: this is on a VERY fast hardware :) ;) You see some longer delays on a normal HW. If the _already_initialized_ patch is used, we could import the Timezone when installation is initialized (with a Progress dialog) so that would speed-up even the fist-dialog loading. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=395816 User jsuchome@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=395816#c1 Jiří Suchomel <jsuchome@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Jiří Suchomel <jsuchome@novell.com> 2008-06-02 00:42:16 MDT --- This is strange, code in constructor should be evaluated only once. I'll investigate. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=395816 User jsuchome@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=395816#c2 Jiří Suchomel <jsuchome@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |coolo@novell.com --- Comment #2 from Jiří Suchomel <jsuchome@novell.com> 2008-06-20 04:27:18 MDT --- The problem is not in initialization (constructor code is called once), but when the time zone entries are sorted according to current language. I can do some optimization, but it won't be much better. One thing that could help visually would be to open the dialog soon and fill the widget data once they are ready. But TimezoneSelector doesn't support changing/entering `Items (via ChangeWidget) after it is shown. Coolo, could you add it? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=395816 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=395816#c3 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |coolo@novell.com Status|NEEDINFO |ASSIGNED Info Provider|coolo@novell.com | --- Comment #3 from Stephan Kulow <coolo@novell.com> 2008-06-20 06:00:49 MDT --- provide me with a ycp test case and assign it to me -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=395816 User jsuchome@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=395816#c4 --- Comment #4 from Jiří Suchomel <jsuchome@novell.com> 2008-06-24 03:41:01 MDT --- Created an attachment (id=223947) --> (https://bugzilla.novell.com/attachment.cgi?id=223947) test case Well, OK, I could do the same thing with UI::ReplaceWidget, so implementing `Items property might have sense only when it is faster than replacing whole widget.... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=395816 User jsuchome@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=395816#c5 Jiří Suchomel <jsuchome@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsuchome@novell.com AssignedTo|jsuchome@novell.com |coolo@novell.com Status|ASSIGNED |NEW --- Comment #5 from Jiří Suchomel <jsuchome@novell.com> 2008-06-24 03:41:53 MDT --- Just decide yourself if it is worth the work. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=395816 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=395816#c6 --- Comment #6 from Stephan Kulow <coolo@novell.com> 2008-06-24 03:47:18 MDT --- I would expect replacing the widget to be more expensive as the worldmap needs to be loaded and scaled twice then. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=395816 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=395816#c7 --- Comment #7 from Stephan Kulow <coolo@novell.com> 2008-06-24 03:52:08 MDT --- ok, I experimented with your test case and if you take out the event loop, you get a test case that can be timed with "time y2base" - I get around 1.4s-1.7s with just showing a blank timezone and around 1.5s-1.9s with having the replacewidget call in. So at least on my hardware, the effort to implement changewidget doesn't seem to be justified. I look how hard it is. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=395816 User coolo@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=395816#c8 Stephan Kulow <coolo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #8 from Stephan Kulow <coolo@novell.com> 2008-08-01 03:46:46 MDT --- I missed the time so far and I doubt I find the time to save 0.1s. so I go WONTFIX -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com