[Bug 793027] New: collectl init script errors/fails
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c0 Summary: collectl init script errors/fails Classification: openSUSE Product: openSUSE 12.2 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: Other AssignedTo: tabraham@suse.com ReportedBy: tabraham@suse.com QAContact: qa-bugs@suse.de Found By: Development Blocker: --- The collectl init script looks in the wrong location for the collectl binary and calls rc_status and rc_exit before sourcing /etc/rc.status Therefore it exits with errors when start/stop/status is attempted. # /etc/init.d/collectl start Cannot find /usr/bin/collectl/etc/init.d/collectl: line 27: rc_status: command not found /etc/init.d/collectl: line 28: rc_exit: command not found redirecting to systemctl ... This results in the inability to start/stop/status the collectl service. The relevant code: COLLECTL=/usr/bin/collectl if [ ! -f $COLLECTL ]; then echo -n "Cannot find $COLLECTL" rc_status -s rc_exit fi -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c1 --- Comment #1 from Thomas Abraham <tabraham@suse.com> 2012-12-05 21:45:14 UTC --- Created an attachment (id=515877) --> (http://bugzilla.novell.com/attachment.cgi?id=515877) patch that sources /etc/rc.status before rc_status/rc_exit are called and corrects location to look for collectl script -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c2 --- Comment #2 from Thomas Abraham <tabraham@suse.com> 2012-12-06 15:12:49 UTC --- fix submitted via submitrequest 144420 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c3 --- Comment #3 from Thomas Abraham <tabraham@suse.com> 2012-12-06 19:56:59 UTC --- created maintenancerequest 144445 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c Thomas Abraham <tabraham@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |maintenance@opensuse.org -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c4 --- Comment #4 from Bernhard Wiedemann <bwiedemann@suse.com> 2012-12-06 21:00:08 CET --- This is an autogenerated message for OBS integration: This bug (793027) was mentioned in https://build.opensuse.org/request/show/144445 Maintenance / -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c5 Marcus Meissner <meissner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |meissner@suse.com --- Comment #5 from Marcus Meissner <meissner@suse.com> 2012-12-07 10:25:27 UTC --- i had to decline the mr as it has no source diffs. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c6 --- Comment #6 from Thomas Abraham <tabraham@suse.com> 2012-12-07 20:32:08 UTC --- I think I got it right this time. created maintenancerequest 144653 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c7 --- Comment #7 from Bernhard Wiedemann <bwiedemann@suse.com> 2012-12-07 22:00:08 CET --- This is an autogenerated message for OBS integration: This bug (793027) was mentioned in https://build.opensuse.org/request/show/144653 Maintenance / -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c8 --- Comment #8 from Bernhard Wiedemann <bwiedemann@suse.com> 2012-12-08 18:00:08 CET --- This is an autogenerated message for OBS integration: This bug (793027) was mentioned in https://build.opensuse.org/request/show/144720 Maintenance / -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c9 Benjamin Brunner <bbrunner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|maintenance@opensuse.org | --- Comment #9 from Benjamin Brunner <bbrunner@suse.com> 2012-12-17 14:50:19 CET --- Thanks for the new submission. I started an update, see openSUSE:Maintenance:1172 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c10 Benjamin Brunner <bbrunner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #10 from Benjamin Brunner <bbrunner@suse.com> 2012-12-27 13:32:59 CET --- Update released for 12.1 and 12.2. Resolved fixed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c11 --- Comment #11 from Swamp Workflow Management <swamp@suse.de> 2012-12-27 13:10:41 UTC --- openSUSE-RU-2012:1695-1: An update that has one recommended fix can now be installed. Category: recommended (important) Bug References: 793027 CVE References: Sources used: openSUSE 12.2 (src): collectl-3.4.3-10.4.1 openSUSE 12.1 (src): collectl-3.4.3-7.4.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c12 --- Comment #12 from Thomas Abraham <tabraham@suse.com> 2013-04-15 15:32:52 UTC --- This fix didn't make it into openSUSE 12.3. I created maintenance request 170879 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c13 Thomas Abraham <tabraham@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #13 from Thomas Abraham <tabraham@suse.com> 2013-04-15 15:33:48 UTC --- reopened for openSUSE 12.3 maintenance -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c Thomas Abraham <tabraham@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEEDINFO InfoProvider| |maintenance@opensuse.org -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c14 --- Comment #14 from Thomas Abraham <tabraham@suse.com> 2013-04-15 15:55:44 UTC --- bah. I believe I neglected to include the patchinfo in maintenancerequest 170879. submitted maintenancerequest 170883 including the patchinfo -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c15 Benjamin Brunner <bbrunner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |REOPENED InfoProvider|maintenance@opensuse.org | --- Comment #15 from Benjamin Brunner <bbrunner@suse.com> 2013-04-16 11:03:12 CEST --- Thanks for your submission. I'll remove the package collectl in the incident (duplicate, see collectl.openSUSE_12.3_Update). Additionally i'll add the name of the patch to your .changes-entry. Please see sr#157362 (submission to Factory), too. Could you add the patch-name in the .changes-file of the package from the devel-project Base:System and submit it to factory again, please. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c16 --- Comment #16 from Benjamin Brunner <bbrunner@suse.com> 2013-04-16 11:05:53 CEST --- New changelog-entry is: ------------------------------------------------------------------- Mon Apr 15 00:19:21 UTC 2013 - tabraham@suse.com -- fix for collectl init script (bnc #793027) +- fix for collectl init script (bnc#793027) + + added bug-793027.patch ------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c17 Mark Seger <mjseger@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjseger@gmail.com --- Comment #17 from Mark Seger <mjseger@gmail.com> 2013-04-20 18:22:40 UTC --- As the author of collectl, I'd like to fix this in the source kit. Looking at the patch it looks like it changes the location to look for collectl to /usr/sbin but my INSTALL and RPM already points it there and I'm currently installing in /usr/bin which is where all the other linux distros install it. So, I'd like to get someone to confirm - does suse really use /usr/sbin or am I reading the patch wrong? I'm also guessing this patch is based on an older version of the start script because someone had asked me awhile ago to fix it and the code now looks like this: [ -r /etc/rc.status ] && . /etc/rc.status rc_reset COLLECTL=/usr/sbin/collectl if [ ! -f $COLLECTL ]; then echo -n "Cannot find $COLLECTL" rc_status -s rc_exit fi BUT as I said the bug is collectl is sitting in /usr/bin and not /usr/sbin so it still doesn't work. At the very least I'd appreciate being copied on future bug reports so we can better keep the code in sync. If I don't hear otherwise I'll simply continue to install in /usr/bin and change my start script to point there instead of /usr/sbin. -mark -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c18 --- Comment #18 from Thomas Abraham <tabraham@suse.com> 2013-04-20 21:25:16 UTC --- Mark, I'm the one that sent you the patch. This is the original bug for that patch. I reopened the bug to get an update released for openSUSE 12.3 because, for some reason, the patch didn't get into the release for 12.3. It did go out in a 12.2 update, though. We do install collectl in /usr/sbin, so this addresses the problem. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c19 Benjamin Brunner <bbrunner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #19 from Benjamin Brunner <bbrunner@suse.com> 2013-04-23 15:41:45 CEST --- Mark and Tom thanks for verifying. I doublechecked it and collectl is located in /usr/sbin. I'll release the update for openSUSE 12.3 and close the bug. Feel free to reopen it if something is missing. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c20 --- Comment #20 from Mark Seger <mjseger@gmail.com> 2013-04-23 19:46:32 UTC --- I just want to make sure, is collectl really supposed to be deployed in /usr/sbin or is that the real problem? All other distros deploy to /usr/bin and I was just wondering why suse is different? The bottom line is clearly the init script and the location of collectl need to match and I'm happy to do whatever suse does, but I also wanted to make sure deploying in /usr/sbin is the intent and not a mistake. -mark -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c21 --- Comment #21 from Thomas Abraham <tabraham@suse.com> 2013-04-23 20:17:25 UTC --- Mark, I find it in /usr/sbin on openSUSE as far back as openSUSE 11.1 (collectl-2.6.4-2.26). I didn't check previous versions. I'm not sure why SUSE is different. I thought it safest to change the init script to point at /usr/sbin and evaluate moving collectl to /usr/bin in a future release (likely openSUSE 13.1). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c22 --- Comment #22 from Mark Seger <mjseger@gmail.com> 2013-04-23 22:02:36 UTC --- so just that you all understand and while I realize there are distro-specific releases typically maintained by others, my RPMs and INSTALL script checks for suse and 'does the right thing'. Unfortunately it installs in /usr/bin but the init script points to /usr/sbin. groan... my thought is to leave it in /usr/bin and change the init script, especially if you're considering doing that at some time in the future as it would be more consistent with the rest of the linux landscape. -mark -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c23 --- Comment #23 from Thomas Abraham <tabraham@suse.com> 2013-04-23 22:38:23 UTC --- My fear is that changing this would break scripts and/or cron jobs that users have pointing to /usr/sbin/collectl. While, I can move it and replace /usr/sbin/collectl with a symlink to /usr/bin/collectl (or a script that warns that it has moved?), this would still be SUSE specific. ...and then for consistency, I would do the same for openSUSE 12.2. (I'd have to check maintenance policy to see if that would even be acceptable for a maintenance update). Since 12.2 already has the script fixed in a maintenance update, I'd rather keep 12.3 consistent with this and make a clean break in 13.1 and change this along with providing the most recent collectl release. So, we will get consistent with the rest of the Linux landscape, but I think this is a better change for a major release than a maintenance update. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c24 --- Comment #24 from Mark Seger <mjseger@gmail.com> 2013-04-24 19:02:06 UTC --- ok, fair enough. I'll change my install to place it in /usr/sbin on suse I'm also thinking rather than try to get fancy and install in different places depending on the suse version, perhaps we should just stick to /usr/sbin for the foreseeable future. -mark -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=793027 https://bugzilla.novell.com/show_bug.cgi?id=793027#c25 --- Comment #25 from Swamp Workflow Management <swamp@suse.de> 2013-06-10 10:12:54 UTC --- openSUSE-RU-2013:0943-1: An update that has one recommended fix can now be installed. Category: recommended (important) Bug References: 793027 CVE References: Sources used: openSUSE 12.3 (src): collectl-3.4.3-12.7.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com