https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c1 --- Comment #1 from Thomas Saupe 2011-08-30 15:48:55 UTC --- Created an attachment (id=448446) --> (http://bugzilla.novell.com/attachment.cgi?id=448446) open-iscsi-umount.patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c3 Thomas Saupe changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #448680|0 |1 is obsolete| | --- Comment #3 from Thomas Saupe 2011-08-31 14:20:57 UTC --- Created an attachment (id=448700) --> (http://bugzilla.novell.com/attachment.cgi?id=448700) iscsi-multipath-patch Did a little more polishing on the patch to properly reflect the start and stop of multipathing for iscsi devices. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c4 Dennis Olsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |D.Olsson@Netzwerk-Design.de --- Comment #4 from Dennis Olsson 2011-09-28 18:31:06 CEST --- Sinec you are polishing the script, how about changing: cat /proc/mounts | sed -ne '/^\/dev\/.*/p' | while read d m t o x; do to the less resource demanding (one less process running) and even more readable: sed -ne '/^\/dev\/.*/p' /proc/mounts | while read d m t o x; do ?? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c6 --- Comment #6 from Thomas Saupe 2011-10-31 09:11:12 UTC --- Dennis, thanks for the hint. Still I would prefer to wait for approval from the open-iscsi maintainer before going further here. Joseph, just do a: patch -p0 https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c8 --- Comment #8 from Per Jessen 2011-10-31 14:35:41 UTC --- (In reply to comment #4)

Sinec you are polishing the script, how about changing:

cat /proc/mounts | sed -ne '/^\/dev\/.*/p' | while read d m t o x; do

to the less resource demanding (one less process running) and even more readable:

sed -ne '/^\/dev\/.*/p' /proc/mounts | while read d m t o x; do

How about grep ^/dev /proc/mounts | while read d m t o x; do -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c10 Thomas Saupe changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #448700|0 |1 is obsolete| | --- Comment #10 from Thomas Saupe 2011-11-02 16:14:56 UTC --- Created an attachment (id=459966) --> (http://bugzilla.novell.com/attachment.cgi?id=459966) patch update Thanks for the hints and reports, updated the patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c12 Thomas Saupe changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #459966|0 |1 is obsolete| | --- Comment #12 from Thomas Saupe 2011-11-03 09:47:52 UTC --- Created an attachment (id=460140) --> (http://bugzilla.novell.com/attachment.cgi?id=460140) patch update2 One more correction to the patch. Thanks Per for pointing this out. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c14 --- Comment #14 from Dennis Olsson 2011-11-03 16:57:38 CET --- Created an attachment (id=460273) --> (http://bugzilla.novell.com/attachment.cgi?id=460273) Another update of patch. Thomas, I had a go at you patch, but found that it did not like my mounts of e.g. loop devices (spitted out errors). So, I made a code review and rewrite and came up with this one. As I do not have multipath, I have not been able to test whether I have gotten it right with this part, but at least the patch now works with my setup using loops, LVM and iSCSI. I have not obsoleted your patch, as I do not know, whether you agree with my patch version. :-) Hope you like my patch suggestion, just as it would be nice, if you would test my patch in a multipath iSCSI environment. Many thanks in advance. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c16 --- Comment #16 from Per Jessen 2011-11-03 18:00:43 UTC --- One comment - the test for any "iscsi devices at all", isn't that superfluous? I mean, when this script is being run at startup or shutdown, we can assume that iscsi _is_ in use. Otherwise the script looks good, my first test showed no problems. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=714995 https://bugzilla.novell.com/show_bug.cgi?id=714995#c Petr Uzel changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P2 - High Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=714995 http://bugzilla.novell.com/show_bug.cgi?id=714995#c20 Petr Uzel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |WONTFIX --- Comment #20 from Petr Uzel --- I am sorry, but I was not able to find time to look into this bug. Now the affected openSUSE versions are no longer supported, so I will close this bug. If it can still be reproduced with current and supported openSUSE version, please reopen. Thanks. -- You are receiving this mail because: You are on the CC list for the bug.