[Bug 440883] New: Banshee cannot handle command line with paths containing spaces
https://bugzilla.novell.com/show_bug.cgi?id=440883 Summary: Banshee cannot handle command line with paths containing spaces Product: openSUSE 11.1 Version: Beta 3 Platform: x86-64 OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Banshee AssignedTo: abockover@novell.com ReportedBy: 1kfmm4x02@sneakemail.com QAContact: abockover@novell.com Found By: Other It looks as if Banshee has trouble with paths passed via the command line that contain spaces. How to reproduce: 1) Take an audio file and make two copies of it, naming the first "music.flac" and the second "music 1.flac" (use an appropriate extension depending on the type of the audio file). 2) Open a command shell in the directory containing these two audio files. 3) Execute "banshee-1 ./music.flac". 4) The file should open in Banshee. (This actually doesn't work every time, but that is probably another bug.) 5) Clear the playlist and quit Banshee. 6) Execute "banshee-1 ./music\ 1.flac". Expected result: Banshee should start playing "music 1.flac". Actual result: Banshee starts but isn't playing "music 1.flac". You can vary the sequence by placing the audio files in two directories, one called "banshee" and one called "banshee test directory": "banshee-1 banshee/music.flac" works, "banshee-1 banshee\ test\ directory/music.flac" does not. The behavior can also be seen in Dolphin (KDE 4.1). However, Gnome's Nautilus seems to handle it better. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User 1kfmm4x02@sneakemail.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c1 --- Comment #1 from Per Ångström <1kfmm4x02@sneakemail.com> 2008-11-11 12:52:21 MST --- The problem persists in Banshee 1.4.0.1 (OpenSuse 11.1 Beta 3 + updates): I cannot get Dolphin to play audio files in Banshee by double-clicking on them if either the file name or the full path contains spaces. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User 1kfmm4x02@sneakemail.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c2 --- Comment #2 from Per Ångström <1kfmm4x02@sneakemail.com> 2008-11-16 06:42:18 MST --- I have filed bug 445492 to point out the specific problems this bug creates for the integration with Dolphin and Konqueror. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User abockover@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c3 --- Comment #3 from Aaron Bockover <abockover@novell.com> 2008-11-20 14:27:51 MST --- This sounds like it's a bug in Dolphin/Konqueror. The Banshee .desktop file specifies that files passed should be encoded as URIs, meaning spaces should be eliminated.
From /usr/share/applications/banshee.desktop:
Exec=banshee --play-enqueued --enqueue %U -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User abockover@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c4 --- Comment #4 from Aaron Bockover <abockover@novell.com> 2008-11-20 14:32:30 MST --- Created an attachment (id=254096) --> (https://bugzilla.novell.com/attachment.cgi?id=254096) Boo script for extra debugging info a) Run Banshee, go to Preferences, then the Extensions tab, and enable the Boo Script extension. Quit Banshee. b) Download the attachment and put it in ~/.config/banshee-1/boo-scripts (create the directory if it does not exist) c) Run Banshee as you would to reproduce this bug. d) Attach the ~/.config/banshee-1/log file to this bug, but ensure it includes some lines similar to this first (otherwise the script did not run and the output is useless): Environment.GetCommandLineArgs: /usr/lib/banshee-1/Banshee.exe --redirect-log --play-enqueued file:///home/aaron/Desktop/Test%20With%20Spaces.ogv ApplicationContext.CommandLine.Files: file:///home/aaron/Desktop/Test%20With%20Spaces.ogv As you can see in my test, the files with spaces are properly encoded as URIs by Nautilus, thus respecting the %U argument in the Exec line of the .desktop file. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User abockover@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c5 Aaron Bockover <abockover@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abockover@novell.com AssignedTo|abockover@novell.com |kde-maintainers@suse.de Component|Banshee |KDE4 Applications QAContact|abockover@novell.com |qa@suse.de Summary|Banshee cannot handle command line with paths |Konqueror/Dolphin does not respect %U in |containing spaces |.desktop file or properly quote spaced file | |names --- Comment #5 from Aaron Bockover <abockover@novell.com> 2008-11-20 14:37:50 MST --- Okay, testing optional. Turns out I did have KDE4 installed :) This is the output I get with Konq: Environment.GetCommandLineArgs: /usr/lib/banshee-1/Banshee.exe --redirect-log --play-enqueued /home/aaron/Desktop/Test With Spaces.ogg ApplicationContext.CommandLine.Files: /home/aaron/Desktop/Test With Spaces.ogg As you can see, Konq is indeed not respecting the %U. Furthermore there is absolutely no way for Banshee to know how to handle it because the file is not even properly quoted on the command line. Environment.GetCommandLineArgs is the lowest level way of reading command line arguments and already at that level the file name is split up. This is a Konq/Dolphin bug all the way. Moving to KDE. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User abockover@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c6 --- Comment #6 from Aaron Bockover <abockover@novell.com> 2008-11-20 14:39:55 MST --- Regarding the command line, you need to quote the path, as do the file managers (but the real issue here is not respecting %U to URI encode the paths). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User abockover@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c7 --- Comment #7 from Aaron Bockover <abockover@novell.com> 2008-11-20 14:41:30 MST --- *** Bug 445492 has been marked as a duplicate of this bug. *** https://bugzilla.novell.com/show_bug.cgi?id=445492 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User llunak@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c8 Lubos Lunak <llunak@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kde-maintainers@suse.de |abockover@novell.com Component|KDE4 Applications |Banshee QAContact|qa@suse.de |abockover@novell.com Summary|Konqueror/Dolphin does not respect %U in |Banshee does not handle spaced file names |.desktop file or properly quote spaced file |correctly |names | --- Comment #8 from Lubos Lunak <llunak@novell.com> 2008-11-24 06:03:45 MST --- What exactly makes you believe Banshee not handling filenames with spaces passed from command line is a KDE problem at all? This doesn't work properly even without KDE used, and KDE passes correct arguments (and correctly handled) when used, I checked. My guess is the wrapper script is broken. As for (not) respecting %U, "A list of URLs. Each URL is passed as a separate argument to the executable program. Local files may either be passed as file: URLs or as file path." (http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-lates...) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User abockover@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c9 --- Comment #9 from Aaron Bockover <abockover@novell.com> 2008-11-24 09:56:02 MST --- Regarding the wrapper, that could indeed be the case. I will look into that. Regarding %U, touché I guess as well, although it's particularly annoying that local paths are special cased here. In any regard %U should be moot if the wrapper is indeed broken. To clarify though, I didn't assign to KDE because of the spaces, I did because of the difference in handling %U. Apologies for that, though I think it would be useful for KDE to behave similarly to GNOME here, and the spec should be updated to not special case local file URIs. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User abockover@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c10 --- Comment #10 from Aaron Bockover <abockover@novell.com> 2008-11-24 10:02:18 MST --- Created an attachment (id=254881) --> (https://bugzilla.novell.com/attachment.cgi?id=254881) Patch to fix wrapper script Yes, the wrapper script was broken. It looks like it was a regression from when logging was implemented and $@ was pulled out and move to another variable causing it to be unquoted. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 Aaron Bockover <abockover@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Normal |Critical Priority|P5 - None |P2 - High -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User abockover@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c11 --- Comment #11 from Aaron Bockover <abockover@novell.com> 2008-11-24 10:03:52 MST --- Confirmed fixed through Konqueror, Dolphin, and the command line. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 Aaron Bockover <abockover@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Critical |Major -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 Aaron Bockover <abockover@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Banshee does not handle spaced file names |[FIXED-FOR-RC2] Banshee does not handle spaced |correctly |file names correctly -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User abockover@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c12 Aaron Bockover <abockover@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #12 from Aaron Bockover <abockover@novell.com> 2009-01-12 09:50:24 MST --- A fix for this bug has been submitted and checked in to SLED 11 RC2. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User 1kfmm4x02@sneakemail.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c13 --- Comment #13 from Per Ångström <1kfmm4x02@sneakemail.com> 2009-01-15 08:48:58 MST --- Am I right in concluding that the fix is not in openSUSE 11.1, final version? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440883 User abockover@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440883#c14 --- Comment #14 from Aaron Bockover <abockover@novell.com> 2009-01-15 10:19:25 MST --- It is not in 11.1 final, but may make it as an online update. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com