[Bug 440852] New: opensm-3.2.2-4.1: undefined code
https://bugzilla.novell.com/show_bug.cgi?id=440852 Summary: opensm-3.2.2-4.1: undefined code Product: openSUSE 11.1 Version: Factory Platform: All OS/Version: openSUSE 11.0 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just tried to build the OpenSuse factory package opensm-3.2.2-4.1 and the compiler said cl_ptr_vector.c:312: warning: operation on 'i' may be undefined The source code is if (pfn_callback(i, (void *)p_vector->p_ptr_array[--i], I agree with the compiler, the code is undefined. Suggest code rework. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440852
Marcus Meissner
https://bugzilla.novell.com/show_bug.cgi?id=440852
John Jolly
https://bugzilla.novell.com/show_bug.cgi?id=440852
User jjolly@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=440852#c1
John Jolly
https://bugzilla.novell.com/show_bug.cgi?id=440852
User dcb314@hotmail.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=440852#c2
David Binderman
I cannot duplicate this with the most recent opensm build on x86_64.
Try adding compiler flag -Wall. But better still, don't bother trying to duplicate it. Mark 1 eyeball in simple visual inspection mode should be able to find the offending line of code or be able to verify that the problem has been fixed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440852
User dcb314@hotmail.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=440852#c3
--- Comment #3 from David Binderman
Try adding compiler flag -Wall.
I looked at version 3.2.3_20081117_b70e2d2-2.18, some four months later, and the problem still isn't fixed. I don't understand how a bug can be P2 high priority and yet nothing happens for four months. Further, the compiler also said cl_list.c:462: warning: operation on 'item_count' may be undefined cl_list.c:496: warning: operation on 'item_count' may be undefined which both also appear to be seriously broken code. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440852
John Jolly
participants (1)
-
bugzilla_noreply@novell.com