http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c1

Josef Reidinger jreidinger@suse.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |jreidinger@suse.com, | |lslezak@suse.com Flags| |needinfo?(lslezak@suse.com)

--- Comment #1 from Josef Reidinger jreidinger@suse.com --- Lada - you work the most with translation, do you have idea?

http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c3

--- Comment #3 from Josef Reidinger jreidinger@suse.com --- (In reply to Martin Vidner from comment #2)

msgfmt should be able to check this, at least in theory:

http://linux.die.net/man/1/msgfmt --check-format check language dependent format strings

It should check that the format strings are not changed(=broken by translation), just permuted.

maybe this bug is about missing ruby support in msgfmt?

http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c5

Ladislav Slezák lslezak@suse.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(lslezak@suse.com) |

--- Comment #5 from Ladislav Slezák lslezak@suse.com --- With Ruby it's a bit more complicated, the GNU Gettext does not support Ruby at all. The translatable texts are collected by Ruby rgettext (https://github.com/ruby-gettext/gettext) and at runtime YaST uses fast_gettext gem (https://github.com/grosser/fast_gettext) for actual translation.

That means beside adapting the GNU gettext to support the ruby-format, we would need to fix Ruby gettext to write this flag when creating the POT file...

http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c7

--- Comment #7 from Karl Eichwalder ke@suse.com --- (In reply to Martin Vidner from comment #6)

See also https://bugzilla.suse.com/show_bug.cgi?id=954505 "yast ruby msg extractor (xgettext) does not support format marker"

Thanks for the reminder!

I'd vote to report it upstream. I'd have reported it upstream, if I'd be familiar with Rudy. In the past, the gettext maintainers (Bruno) wanted to know the specifics about the format specifiers and then implemented it (ycp). I guess Ruby is rather complex, but why not trying? It's rather important to us ((open)SUSE).

http://bugzilla.suse.com/show_bug.cgi?id=980329

Ladislav Slezák lslezak@suse.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED

http://bugzilla.suse.com/show_bug.cgi?id=980329

Karl Eichwalder ke@suse.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1026156

http://bugzilla.suse.com/show_bug.cgi?id=980329

Karl Eichwalder ke@suse.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1023608

http://bugzilla.suse.com/show_bug.cgi?id=980329

Karl Eichwalder ke@suse.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- Severity|Normal |Enhancement

http://bugzilla.suse.com/show_bug.cgi?id=980329

Stefan Hundhammer shundhammer@suse.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|yast-internal@suse.de |shundhammer@suse.com

http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c14

--- Comment #14 from Stefan Hundhammer shundhammer@suse.com --- Native support for Ruby in the gettext tools would be most welcome.

Once that arrives, it will supersede our post-processing solution: This new script does not override an existing format. If a message already has a format marker, that one has priority, and we do not attempt to add another one (which might conflict with the existing one).

Thanks for the update!

http://bugzilla.suse.com/show_bug.cgi?id=980329 http://bugzilla.suse.com/show_bug.cgi?id=980329#c16

Stefan Hundhammer shundhammer@suse.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED

--- Comment #16 from Stefan Hundhammer shundhammer@suse.com --- The fix will become available with yast2-devtools-4.2.6.

But it can already be used independently if downloaded from here:

https://github.com/yast/yast-devtools/blob/master/build-tools/scripts/po_add...

It doesn't need any YaST development environment, only Ruby (which all SUSE users should have installed anyway for YaST) and the "gettext" Ruby gem for that Ruby version (see ruby --version)

sudo zypper in ruby2.6-rubygem-gettext

For more details, see

https://github.com/yast/yast-devtools/pull/152

All YaST .pot files that we generate from now on should already contain format flags generated by this script, so they will trickle down to the translators with the normal translation workflow.

https://bugzilla.suse.com/show_bug.cgi?id=980329

Lukas Ocilka locilka@suse.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(shundhammer@suse. | |com)