[Bug 1214528] [Build 20230822] icewm segfaults during installation

https://bugzilla.suse.com/show_bug.cgi?id=1214528 https://bugzilla.suse.com/show_bug.cgi?id=1214528#c5 --- Comment #5 from Simon Lees <simonf.lees@suse.com> --- (In reply to Fabian Vogt from comment #3)
(In reply to Fabian Vogt from comment #2)
I guess some of the refactoring upstream broke assumptions in the MMX (!) code.
Yep.
commit ee61df687706d4907fb9dcc8f402ee8bdc321db2 Author: Kim Woelders <kim@woelders.dk> Date: Tue May 9 15:36:25 2023 +0200
scaling: Change ypoints[] from pointers to indices
diff --git a/src/lib/scale.c b/src/lib/scale.c index 9307553..a79c3fc 100644 --- a/src/lib/scale.c +++ b/src/lib/scale.c @@ -11,8 +11,9 @@ /*\ NB: If you change this, don't forget asm_scale.S \*/ struct _imlib_scale_info { int *xpoints; - uint32_t **ypoints; - int *xapoints, *yapoints; + int *ypoints; + int *xapoints; + int *yapoints; int xup_yup; uint32_t *pix_assert; };
You can guess what was forgotten here.
I'll presume asm_scale.S given it hasn't changed. I'm not competent enough with intel assembly to come up with a patch, so i'll accept your disabling MXX as a work around for now and I'll raise this with upstream. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@suse.com